Change in vdsm[master]: cancel migration: remove event sync

Shahar Havivi has uploaded a new change for review.

Change subject: cancel migration: remove event sync
......................................................................

cancel migration: remove event sync

no need to sync if we are before migrateToURI2(),
libvirt handle that well...

Change-Id: I0f226e3376b95b64b015885715c0db32eecc5c63
---
M vdsm/libvirtvm.py
M vdsm/vm.py
2 files changed, 5 insertions(+), 10 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/33/2533/1
--
To view, visit http://gerrit.ovirt.org/2533
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I0f226e3376b95b64b015885715c0db32eecc5c63
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com&gt;

[Haim Ateya]

Haim Ateya has posted comments on this change.

Change subject: cancel migration: remove event sync
......................................................................


Patch Set 1: Verified

--
To view, visit http://gerrit.ovirt.org/2533
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0f226e3376b95b64b015885715c0db32eecc5c63
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Haim Ateya <hateya(a)redhat.com&gt;
Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com&gt;

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: cancel migration: remove event sync
......................................................................


Patch Set 1: I would prefer that you didn't submit this

(1 inline comment)

....................................................
File vdsm/libvirtvm.py
Line 438:                 self._preparingMigrationEvt = False
I do not understand the motivation for this patch. Do you suggest that if abortJob is
called just before migrateToURI, migration would fail? That sounds very odd, to say the
least.

--
To view, visit http://gerrit.ovirt.org/2533
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0f226e3376b95b64b015885715c0db32eecc5c63
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com&gt;

Shahar Havivi has posted comments on this change.

Change subject: cancel migration: remove event sync
......................................................................


Patch Set 1: Verified

--
To view, visit http://gerrit.ovirt.org/2533
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0f226e3376b95b64b015885715c0db32eecc5c63
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com&gt;
Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com&gt;

Shahar Havivi has abandoned this change.

Change subject: cancel migration: remove event sync
......................................................................


Patch Set 1: Abandoned

--
To view, visit http://gerrit.ovirt.org/2533
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: I0f226e3376b95b64b015885715c0db32eecc5c63
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Haim Ateya <hateya(a)redhat.com&gt;
Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com&gt;
Gerrit-Reviewer: oVirt Jenkins CI Server

Shahar Havivi has posted comments on this change.

Change subject: cancel migration: remove event sync
......................................................................


Patch Set 1: (1 inline comment)

....................................................
File vdsm/libvirtvm.py
Line 438:                 self._preparingMigrationEvt = False
without that patch I get a lot of races (vm is staying in unknown status)
with this patch I have no race.
I am letting Haim test it, so wait with you enthusiastic ack

--
To view, visit http://gerrit.ovirt.org/2533
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0f226e3376b95b64b015885715c0db32eecc5c63
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com&gt;