Eduardo has uploaded a new change for review.
Change subject: Simplify Drive.libvirtName(). ......................................................................
Simplify Drive.libvirtName().
Change-Id: Idce3ad8b10a9e75f2c93a83d1ca071d4841ce744 --- M vdsm/vm.py 1 file changed, 5 insertions(+), 10 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/71/271/1 -- To view, visit http://gerrit.ovirt.org/271 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange Gerrit-Change-Id: Idce3ad8b10a9e75f2c93a83d1ca071d4841ce744 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo ewarszaw@redhat.com
Igor Lvovsky has posted comments on this change.
Change subject: Simplify Drive.libvirtName(). ......................................................................
Patch Set 1: Looks good to me, but someone else must approve
-- To view, visit http://gerrit.ovirt.org/271 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Idce3ad8b10a9e75f2c93a83d1ca071d4841ce744 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo ewarszaw@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com
Federico Simoncelli has posted comments on this change.
Change subject: Simplify Drive.libvirtName(). ......................................................................
Patch Set 1: I would prefer that you didn't submit this
(1 inline comment)
.................................................... File vdsm/vm.py Line 71: return "".join((preffix, letter)) I remember Dan wanted to support more than 26 disks (just like libvirt does, eg: hdaa hdab, etc...). "preffix" is a typo. I'd use something simpler, clearer and faster as: "return prefix + letter".
-- To view, visit http://gerrit.ovirt.org/271 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Idce3ad8b10a9e75f2c93a83d1ca071d4841ce744 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo ewarszaw@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com
Dan Kenigsberg has posted comments on this change.
Change subject: Simplify Drive.libvirtName(). ......................................................................
Patch Set 1: Do not submit
I'm afraid we need the complexity.. Any reason not to abandon this?
-- To view, visit http://gerrit.ovirt.org/271 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Idce3ad8b10a9e75f2c93a83d1ca071d4841ce744 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo ewarszaw@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: ilvovsky@gmail.com
Eduardo has abandoned this change.
Change subject: Simplify Drive.libvirtName(). ......................................................................
Patch Set 1: Abandoned
I'll be back...
-- To view, visit http://gerrit.ovirt.org/271 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: abandon Gerrit-Change-Id: Idce3ad8b10a9e75f2c93a83d1ca071d4841ce744 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo ewarszaw@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: ilvovsky@gmail.com
vdsm-patches@lists.fedorahosted.org