10:26 a.m.
Hello Nir Soffer, Dan Kenigsberg, Francesco Romani,
I'd like you to do a code review. Please visit
http://gerrit.ovirt.org/32056
to review the following change.
Change subject: tool: Fix compatibility with Python 2.6
......................................................................
tool: Fix compatibility with Python 2.6
Commit 398d016b58 was merged too quickly, before Python developers could
add set literals to Python 2.6. Since this is quite late now to add it,
I think we should use the good old set() syntax.
Change-Id: I77c02b69eaf1852b227d04c194461e542f0a096a
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1132677
Signed-off-by: Nir Soffer <nsoffer(a)redhat.com>
Reviewed-on: http://gerrit.ovirt.org/31734
Reviewed-by: Francesco Romani <fromani(a)redhat.com>
Tested-by: Francesco Romani <fromani(a)redhat.com>
Reviewed-by: Dan Kenigsberg <danken(a)redhat.com>
---
M lib/vdsm/tool/configurators/libvirt.py
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/56/32056/1
diff --git a/lib/vdsm/tool/configurators/libvirt.py
b/lib/vdsm/tool/configurators/libvirt.py
index c1ee527..da19da2 100644
--- a/lib/vdsm/tool/configurators/libvirt.py
+++ b/lib/vdsm/tool/configurators/libvirt.py
@@ -112,7 +112,7 @@
content['removeConf'](self, content['path'])
def getRequires(self):
- return {'certificates'}
+ return set(['certificates'])
def _getPersistedFiles(self):
"""
--
To view, visit http://gerrit.ovirt.org/32056
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I77c02b69eaf1852b227d04c194461e542f0a096a
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: mooli tayer <mtayer(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
9:17 p.m.
Yaniv Bronhaim has posted comments on this change.
Change subject: tool: Fix compatibility with Python 2.6
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/32056
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I77c02b69eaf1852b227d04c194461e542f0a096a
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: mooli tayer <mtayer(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-HasComments: No
7:27 p.m.
oVirt Jenkins CI Server has posted comments on this change.
Change subject: tool: Fix compatibility with Python 2.6
......................................................................
Patch Set 3:
Build Failed
http://jenkins.ovirt.org/job/vdsm_3.5_create-rpms_merged/114/ : FAILURE
--
To view, visit http://gerrit.ovirt.org/32056
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I77c02b69eaf1852b227d04c194461e542f0a096a
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: mooli tayer <mtayer(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: mooli tayer <mtayer(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
4:21 p.m.
Yaniv Bronhaim has submitted this change and it was merged.
Change subject: tool: Fix compatibility with Python 2.6
......................................................................
tool: Fix compatibility with Python 2.6
Commit 398d016b58 was merged too quickly, before Python developers could
add set literals to Python 2.6. Since this is quite late now to add it,
I think we should use the good old set() syntax.
Change-Id: I77c02b69eaf1852b227d04c194461e542f0a096a
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1127877
Signed-off-by: Nir Soffer <nsoffer(a)redhat.com>
Reviewed-on: http://gerrit.ovirt.org/31734
Reviewed-by: Francesco Romani <fromani(a)redhat.com>
Tested-by: Francesco Romani <fromani(a)redhat.com>
Reviewed-by: Dan Kenigsberg <danken(a)redhat.com>
Reviewed-on: http://gerrit.ovirt.org/32056
Reviewed-by: Yaniv Bronhaim <ybronhei(a)redhat.com>
Tested-by: mooli tayer <mtayer(a)redhat.com>
---
M lib/vdsm/tool/configurators/libvirt.py
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Nir Soffer: Looks good to me, but someone else must approve
Yaniv Bronhaim: Looks good to me, approved
mooli tayer: Verified
--
To view, visit http://gerrit.ovirt.org/32056
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I77c02b69eaf1852b227d04c194461e542f0a096a
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: mooli tayer <mtayer(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: mooli tayer <mtayer(a)redhat.com>
6:01 a.m.
mooli tayer has posted comments on this change.
Change subject: tool: Fix compatibility with Python 2.6
......................................................................
Patch Set 2: Verified+1
--
To view, visit http://gerrit.ovirt.org/32056
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I77c02b69eaf1852b227d04c194461e542f0a096a
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: mooli tayer <mtayer(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: mooli tayer <mtayer(a)redhat.com>
Gerrit-HasComments: No
5:30 p.m.
Nir Soffer has posted comments on this change.
Change subject: tool: Fix compatibility with Python 2.6
......................................................................
Patch Set 2: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/32056
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I77c02b69eaf1852b227d04c194461e542f0a096a
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: mooli tayer <mtayer(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-HasComments: No
2:17 p.m.
Francesco Romani has posted comments on this change.
Change subject: tool: Fix compatibility with Python 2.6
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/32056
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I77c02b69eaf1852b227d04c194461e542f0a096a
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: mooli tayer <mtayer(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-HasComments: No
3523
days inactive
3528
days old
vdsm-patches@lists.fedorahosted.org
6 comments
5 participants
participants (5)
-
fromani＠redhat.com -
Jenkins CI RO -
mtayer＠redhat.com -
Nir Soffer -
ybronhei＠redhat.com