Change in vdsm[master]: Make misc.py conform pep8 and other minor cleanup

Saggi Mizrahi has uploaded a new change for review.

Change subject: Make misc.py conform pep8 and other minor cleanup
......................................................................

Make misc.py conform pep8 and other minor cleanup

Change-Id: Ifd94b8b8223a99765c519f5a321043986795b7c7
---
M vdsm/storage/misc.py
1 file changed, 216 insertions(+), 115 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/47/3047/1
--
To view, visit http://gerrit.ovirt.org/3047
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ifd94b8b8223a99765c519f5a321043986795b7c7
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi(a)redhat.com&gt;

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: Make misc.py conform pep8 and other minor cleanup
......................................................................


Patch Set 2: Looks good to me, approved

--
To view, visit http://gerrit.ovirt.org/3047
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifd94b8b8223a99765c519f5a321043986795b7c7
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com&gt;

[Dan Kenigsberg]

Dan Kenigsberg has submitted this change and it was merged.

Change subject: Make misc.py conform pep8 and other minor cleanup
......................................................................


Make misc.py conform pep8 and other minor cleanup

Change-Id: Ifd94b8b8223a99765c519f5a321043986795b7c7
---
M vdsm/storage/misc.py
1 file changed, 216 insertions(+), 115 deletions(-)

Approvals:
  Dan Kenigsberg: Verified; Looks good to me, approved


--
To view, visit http://gerrit.ovirt.org/3047
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ifd94b8b8223a99765c519f5a321043986795b7c7
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com&gt;

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: Make misc.py conform pep8 and other minor cleanup
......................................................................


Patch Set 2: Verified

--
To view, visit http://gerrit.ovirt.org/3047
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifd94b8b8223a99765c519f5a321043986795b7c7
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com&gt;

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: Make misc.py conform pep8 and other minor cleanup
......................................................................


Patch Set 1: I would prefer that you didn't submit this

--
To view, visit http://gerrit.ovirt.org/3047
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifd94b8b8223a99765c519f5a321043986795b7c7
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: Make misc.py conform pep8 and other minor cleanup
......................................................................


Patch Set 1: (2 inline comments)

....................................................
File vdsm/storage/misc.py
Line 64: sys.path.append("../")
that's just horrible. we've gut to stop  doing this. (comment unrelated to patch,
of course)

Line 92: # Buffsize is 1K because I tested it on some use cases and 1k was fastets If
I love reformatting, but a missing period before the "If you find" does not let
me push this change

--
To view, visit http://gerrit.ovirt.org/3047
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifd94b8b8223a99765c519f5a321043986795b7c7
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;