Change in vdsm[master]: tests: Avoid printing objects that reference None

Dima Kuznetsov has uploaded a new change for review.

Change subject: tests: Avoid printing objects that reference None
......................................................................

tests: Avoid printing objects that reference None

One of the current ioprocess tests checks who holds reference to the
ioprocess object, but since only a weak reference is stored, if the
object is freed, we check who holds reference to None, and apparently
quite a lot things do.

Change-Id: I9770873d70ec962837574fe32e8b4cb613e7c696
Signed-off-by: Dima Kuznetsov <dkuznets(a)redhat.com&gt;
---
M tests/outOfProcessTests.py
1 file changed, 5 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/78/34978/1

diff --git a/tests/outOfProcessTests.py b/tests/outOfProcessTests.py
index 974e2e1..f905282 100644
--- a/tests/outOfProcessTests.py
+++ b/tests/outOfProcessTests.py
@@ -76,10 +76,11 @@
             gc.collect()
             time.sleep(1)
             gc.collect()
-            logging.info("GARBAGE: %s", gc.garbage)
-            refs = gc.get_referrers(ioproc())
-            logging.info(refs)
-            logging.info(gc.get_referrers(*refs))
+            if ioproc() is not None:
+                logging.info("GARBAGE: %s", gc.garbage)
+                refs = gc.get_referrers(ioproc())
+                logging.info(refs)
+                logging.info(gc.get_referrers(*refs))
             self.assertEquals(ioproc(), None)
         finally:
             oop.IOPROC_IDLE_TIME = idle


-- 
To view, visit http://gerrit.ovirt.org/34978
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I9770873d70ec962837574fe32e8b4cb613e7c696
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dima Kuznetsov <dkuznets(a)redhat.com&gt;

Yeela Kaplan has posted comments on this change.

Change subject: tests: Avoid printing objects that reference None
......................................................................


Patch Set 1: Verified+1

-- 
To view, visit http://gerrit.ovirt.org/34978
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9770873d70ec962837574fe32e8b4cb613e7c696
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dima Kuznetsov <dkuznets(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com&gt;
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com&gt;
Gerrit-Reviewer: Yeela Kaplan <ykaplan(a)redhat.com&gt;
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No

Yaniv Bronhaim has posted comments on this change.

Change subject: tests: Avoid printing objects that reference None
......................................................................


Patch Set 1: Code-Review+1

-- 
To view, visit http://gerrit.ovirt.org/34978
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9770873d70ec962837574fe32e8b4cb613e7c696
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dima Kuznetsov <dkuznets(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com&gt;
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com&gt;
Gerrit-Reviewer: Yeela Kaplan <ykaplan(a)redhat.com&gt;
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: tests: Avoid printing objects that reference None
......................................................................


Patch Set 1:

Build Failed 

http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/13449/ : FAILURE

http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/13288/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/12498/ : FAILURE

http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created_staging/61/ : FAILURE

-- 
To view, visit http://gerrit.ovirt.org/34978
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9770873d70ec962837574fe32e8b4cb613e7c696
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dima Kuznetsov <dkuznets(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com&gt;
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com&gt;
Gerrit-Reviewer: Yeela Kaplan <ykaplan(a)redhat.com&gt;
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No

Yeela Kaplan has posted comments on this change.

Change subject: tests: Avoid printing objects that reference None
......................................................................


Patch Set 1: Code-Review+1

-- 
To view, visit http://gerrit.ovirt.org/34978
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9770873d70ec962837574fe32e8b4cb613e7c696
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dima Kuznetsov <dkuznets(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com&gt;
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com&gt;
Gerrit-Reviewer: Yeela Kaplan <ykaplan(a)redhat.com&gt;
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: tests: Avoid printing objects that reference None
......................................................................


Patch Set 1: Code-Review+2

Raising

-- 
To view, visit http://gerrit.ovirt.org/34978
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9770873d70ec962837574fe32e8b4cb613e7c696
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dima Kuznetsov <dkuznets(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com&gt;
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com&gt;
Gerrit-Reviewer: Yeela Kaplan <ykaplan(a)redhat.com&gt;
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No

[Dan Kenigsberg]

Dan Kenigsberg has submitted this change and it was merged.

Change subject: tests: Avoid printing objects that reference None
......................................................................


tests: Avoid printing objects that reference None

One of the current ioprocess tests checks who holds reference to the
ioprocess object, but since only a weak reference is stored, if the
object is freed, we check who holds reference to None, and apparently
quite a lot things do.

Change-Id: I9770873d70ec962837574fe32e8b4cb613e7c696
Signed-off-by: Dima Kuznetsov <dkuznets(a)redhat.com&gt;
Reviewed-on: http://gerrit.ovirt.org/34978
Reviewed-by: Yaniv Bronhaim <ybronhei(a)redhat.com&gt;
Reviewed-by: Yeela Kaplan <ykaplan(a)redhat.com&gt;
Tested-by: Yeela Kaplan <ykaplan(a)redhat.com&gt;
Reviewed-by: Dan Kenigsberg <danken(a)redhat.com&gt;
---
M tests/outOfProcessTests.py
1 file changed, 5 insertions(+), 4 deletions(-)

Approvals:
  Yeela Kaplan: Verified; Looks good to me, but someone else must approve
  Yaniv Bronhaim: Looks good to me, but someone else must approve
  Dan Kenigsberg: Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/34978
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I9770873d70ec962837574fe32e8b4cb613e7c696
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dima Kuznetsov <dkuznets(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com&gt;
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com&gt;
Gerrit-Reviewer: Yeela Kaplan <ykaplan(a)redhat.com&gt;
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: tests: Avoid printing objects that reference None
......................................................................


Patch Set 2:

Build Failed 

http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc21-x86_64_merged/184/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_create-rpms-el6-x86_64_merged/207/ : FAILURE

http://jenkins.ovirt.org/job/vdsm_master_create-rpms_merged_test_debug/400/ : FAILURE

http://jenkins.ovirt.org/job/vdsm_master_verify-error-codes_merged/6032/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_create-rpms-el7-x86_64_merged/205/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc20-x86_64_merged/200/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/4193/ : ABORTED

-- 
To view, visit http://gerrit.ovirt.org/34978
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9770873d70ec962837574fe32e8b4cb613e7c696
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dima Kuznetsov <dkuznets(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com&gt;
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com&gt;
Gerrit-Reviewer: Yeela Kaplan <ykaplan(a)redhat.com&gt;
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No