Adam Litke has uploaded a new change for review.
Change subject: storageServer: Fix isConnected for LocalDirectoryConnections ......................................................................
storageServer: Fix isConnected for LocalDirectoryConnections
The current isConnected method for LocalDirectoryConnection objects checks if the source path exists. It should instead check for the presence of the symlink in '/rhev/datacenter/mnt/.
Change-Id: I093691e3a1dabb0822ead63c567dc965a63bfc3e Signed-off-by: Adam Litke agl@us.ibm.com --- M vdsm/storage/storageServer.py 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/86/3586/1 -- To view, visit http://gerrit.ovirt.org/3586 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange Gerrit-Change-Id: I093691e3a1dabb0822ead63c567dc965a63bfc3e Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke agl@us.ibm.com
Saggi Mizrahi has posted comments on this change.
Change subject: storageServer: Fix isConnected for LocalDirectoryConnections ......................................................................
Patch Set 1: Looks good to me, but someone else must approve
-- To view, visit http://gerrit.ovirt.org/3586 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I093691e3a1dabb0822ead63c567dc965a63bfc3e Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke agl@us.ibm.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com
Adam Litke has posted comments on this change.
Change subject: storageServer: Fix isConnected for LocalDirectoryConnections ......................................................................
Patch Set 1: Verified
Tested and found that it does fix reconnecting to the same local directory.
-- To view, visit http://gerrit.ovirt.org/3586 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I093691e3a1dabb0822ead63c567dc965a63bfc3e Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke agl@us.ibm.com Gerrit-Reviewer: Adam Litke agl@us.ibm.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com
Dan Kenigsberg has posted comments on this change.
Change subject: storageServer: Fix isConnected for LocalDirectoryConnections ......................................................................
Patch Set 1: Looks good to me, approved
-- To view, visit http://gerrit.ovirt.org/3586 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I093691e3a1dabb0822ead63c567dc965a63bfc3e Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke agl@us.ibm.com Gerrit-Reviewer: Adam Litke agl@us.ibm.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com
Dan Kenigsberg has submitted this change and it was merged.
Change subject: storageServer: Fix isConnected for LocalDirectoryConnections ......................................................................
storageServer: Fix isConnected for LocalDirectoryConnections
The current isConnected method for LocalDirectoryConnection objects checks if the source path exists. It should instead check for the presence of the symlink in '/rhev/datacenter/mnt/.
Change-Id: I093691e3a1dabb0822ead63c567dc965a63bfc3e Signed-off-by: Adam Litke agl@us.ibm.com --- M vdsm/storage/storageServer.py 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: Adam Litke: Verified Saggi Mizrahi: Looks good to me, but someone else must approve Dan Kenigsberg: Looks good to me, approved
-- To view, visit http://gerrit.ovirt.org/3586 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged Gerrit-Change-Id: I093691e3a1dabb0822ead63c567dc965a63bfc3e Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke agl@us.ibm.com Gerrit-Reviewer: Adam Litke agl@us.ibm.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com
vdsm-patches@lists.fedorahosted.org