[NEW PATCH] BZ#729251 vds_bootstrap: Removed a reference to an obselete netconsole option. (via gerrit-bot)

New patch submitted by Gal Hammer ([e-mail])

You can review this change at: http://gerrit.usersys.redhat.com/909

commit b70673418d3bacb772c42acfc97d16c9635f61cf
Author: Gal Hammer 
Date:   Wed Sep 7 15:27:51 2011 +0300

BZ#729251 vds_bootstrap: Removed a reference to an obselete netconsole option.

Change-Id: Ie0b90a78f7c9c49af7b70e50db71f6621274ad4f

diff --git a/vds_bootstrap/vds_bootstrap.py b/vds_bootstrap/vds_bootstrap.py
index 3f8423c..bc64d93 100755
--- a/vds_bootstrap/vds_bootstrap.py
+++ b/vds_bootstrap/vds_bootstrap.py
@@ -785,7 +785,7 @@ def VdsValidation(iurl, subject, random_num, rev_num, orgName, systime, usevdcre
 def main():
     """
         Usage: vds_compat.py [-r rev_num] [-O organizationName] [-t systemTime]
-            [-n netconsole_host:port] [-u (seProductRepo) true|false ] <url> <subject> <random_num>
+            [-u (seProductRepo) true|false ] <url> <subject> <random_num>
     """
     try:
         rev_num = None
@@ -800,9 +800,6 @@ def main():
                 orgName = v
             if o == "-t":
                 systime = v
-            if o == "-n":
-                # TODO: remove me as soon as possible (BZ#689726)
-                pass
             if o == "-u":
                 usevdcrepo = (v.upper() == 'TRUE')
         url = args[0]

Change in vdsm[master]: BZ#729251 vds_bootstrap: Removed a reference to an obselete ...

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: BZ#729251 vds_bootstrap: Removed a reference to an obselete netconsole option.
......................................................................

Patch Set 1: I would prefer that you didn't submit this

(1 inline comment)

Thanks for your patch, but I think that we should not remove -n as long as RHEV-M is capable of sending it.

....................................................
File vds_bootstrap/vds_bootstrap.py
Line 795:         opts, args = getopt.getopt(sys.argv[1:], "r:O:t:n:u:")
keeping n: here is not nice - but it can be done only after fixing RHEV-M's backend/manager/modules/bll/src/main/java/org/nogah/bll/VdsInstaller.java

--
To view, visit http://gerrit.usersys.redhat.com/909
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie0b90a78f7c9c49af7b70e50db71f6621274ad4f
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Gal Hammer 
Gerrit-Reviewer: Dan Kenigsberg

Change in vdsm[master]: BZ#729251 vds_bootstrap: Removed a reference to an obselete ...

Gal Hammer has posted comments on this change.

Change subject: BZ#729251 vds_bootstrap: Removed a reference to an obselete netconsole option.
......................................................................

Patch Set 1: (1 inline comment)

....................................................
File vds_bootstrap/vds_bootstrap.py
Line 795:         opts, args = getopt.getopt(sys.argv[1:], "r:O:t:n:u:")
Done

--
To view, visit http://gerrit.usersys.redhat.com/909
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie0b90a78f7c9c49af7b70e50db71f6621274ad4f
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Gal Hammer 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Gal Hammer

Change in vdsm[master]: BZ#729251 vds_bootstrap: Removed a reference to an obselete ...

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: BZ#729251 vds_bootstrap: Removed a reference to an obselete netconsole option.
......................................................................

Patch Set 2: I would prefer that you didn't submit this

keeping -1 as long as backend/manager/modules/bll/src/main/java/org/nogah/bll/VdsInstaller.java uses -n.

--
To view, visit http://gerrit.usersys.redhat.com/909
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie0b90a78f7c9c49af7b70e50db71f6621274ad4f
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Gal Hammer 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Gal Hammer

Change in vdsm[master]: BZ#729251 vds_bootstrap: Removed a reference to an obselete ...

[Dan Kenigsberg]

Dan Kenigsberg has abandoned this change.

Change subject: BZ#729251 vds_bootstrap: Removed a reference to an obselete netconsole option.
......................................................................

Patch Set 2: Abandoned

moved upstream

http://gerrit.ovirt.org/1931

--
To view, visit http://gerrit.usersys.redhat.com/909
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: Ie0b90a78f7c9c49af7b70e50db71f6621274ad4f
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Gal Hammer 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Doron Fediuck
Gerrit-Reviewer: Gal Hammer