Dan Kenigsberg has posted comments on this change.
Change subject: test: unstable jsonrpc tests ......................................................................
Patch Set 1: Code-Review-1
(1 comment)
http://gerrit.ovirt.org/#/c/24624/1//COMMIT_MSG Commit Message:
Line 5: CommitDate: 2014-02-18 11:06:32 +0100 Line 6: Line 7: test: unstable jsonrpc tests Line 8: Line 9: I am not sure whether this will fix test instability because I am not Your commit message should state which instability you are trying to fix. In any case, another instability is still here:
====================================================================== FAIL: testLeakFd (miscTests.WatchCmd) ---------------------------------------------------------------------- Traceback (most recent call last): File "/home/jenkins/workspace/vdsm_unit_tests_gerrit/vdsm/tests/miscTests.py", line 988, in testLeakFd self.assertEquals(openFdNum(), openFds) AssertionError: 78 != 79 -------------------- >> begin captured logging << -------------------- Line 10: able to recreate it (saw only one failure in jenkins history). The ssl Line 11: flag was not passed to constructReactor so plain tcp reactors were Line 12: reused which might caused the issue. Line 13:
vdsm-patches@lists.fedorahosted.org