Change in vdsm[ovirt-3.5]: ssl: ssl socket may throw sslerror during reading

[Piotr Kliczewski]

Piotr Kliczewski has uploaded a new change for review.

Change subject: ssl: ssl socket may throw sslerror during reading
......................................................................

ssl: ssl socket may throw sslerror during reading

When client closes socket in not clean way sometimes we can get SSLError
with unexpected eof. When this situation occurs we need to make sure to
handle this situation properly.

Bug-Url: https://bugzilla.redhat.com/1265965
Change-Id: I8de60d91f81b08e9cb78df07f09d2bcc903c1bad
Signed-off-by: pkliczewski 
---
M lib/yajsonrpc/betterAsyncore.py
1 file changed, 3 insertions(+), 0 deletions(-)

git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/59/46659/1

diff --git a/lib/yajsonrpc/betterAsyncore.py b/lib/yajsonrpc/betterAsyncore.py
index 70bfb7e..f4fe768 100644
--- a/lib/yajsonrpc/betterAsyncore.py
+++ b/lib/yajsonrpc/betterAsyncore.py
@@ -24,6 +24,7 @@
 from threading import Lock

from collections import deque
+from M2Crypto import SSL

# This is a copy of the standard library asyncore converted to support
@@ -299,6 +300,8 @@
                 return ''
             else:
                 raise
+        except SSL.SSLError:
+            self.handle_close()

def send(self, data):
         try:

[e-mail] has posted comments on this change.

Change subject: ssl: ssl socket may throw sslerror during reading
......................................................................

Patch Set 1:

* Update tracker::#1265965::OK
* Check Bug-Url::OK
* Check Public Bug::#1265965::OK, public bug
* Check Product::#1265965::OK, Correct product Red Hat Enterprise Virtualization Manager
* Check TR::#1265965::OK, correct target release 3.5.6
* warn_if_not_merged_to_previous_branch: OK

[Piotr Kliczewski]

Piotr Kliczewski has posted comments on this change.

Change subject: ssl: ssl socket may throw sslerror during reading
......................................................................

Patch Set 1: Verified+1

Verified on ovirt-3.6 branch by running in local env and network tests env.

Yaniv Bronhaim has posted comments on this change.

Change subject: ssl: ssl socket may throw sslerror during reading
......................................................................

Patch Set 2: Code-Review+2 Continuous-Integration+1

Yaniv Bronhaim has submitted this change and it was merged.

Change subject: ssl: ssl socket may throw sslerror during reading
......................................................................

ssl: ssl socket may throw sslerror during reading

When client closes socket in not clean way sometimes we can get SSLError
with unexpected eof. When this situation occurs we need to make sure to
handle this situation properly.

Bug-Url: https://bugzilla.redhat.com/1265965
Change-Id: I8de60d91f81b08e9cb78df07f09d2bcc903c1bad
Signed-off-by: pkliczewski 
Reviewed-on: https://gerrit.ovirt.org/46659
Reviewed-by: Yaniv Bronhaim 
Continuous-Integration: Yaniv Bronhaim 
---
M lib/yajsonrpc/betterAsyncore.py
1 file changed, 3 insertions(+), 0 deletions(-)

Approvals:
  Piotr Kliczewski: Verified
  Yaniv Bronhaim: Looks good to me, approved; Passed CI tests

[e-mail] has posted comments on this change.

Change subject: ssl: ssl socket may throw sslerror during reading
......................................................................

Patch Set 2:

* Update tracker::#1265965::OK
* Check Bug-Url::OK
* Check Public Bug::#1265965::OK, public bug
* Check Product::#1265965::OK, Correct product Red Hat Enterprise Virtualization Manager
* Check TM::#1265965::OK, correct target milestone ovirt-3.5.6
* Check merged to previous::OK, change not open on any previous branch

[e-mail] has posted comments on this change.

Change subject: ssl: ssl socket may throw sslerror during reading
......................................................................

Patch Set 3:

* Update tracker::#1265965::OK
* Set MODIFIED::bug 1265965::::#1265965::::IGNORE, not oVirt prod but Red Hat Enterprise Virtualization Manager