Hunt Xu has uploaded a new change for review.
Change subject: XMLRPCServer: support listening on ipv6 addresses ......................................................................
XMLRPCServer: support listening on ipv6 addresses
Which ip address should be listened on: * if one is specified in the configuration, listen on it, the ip address family of the connection is decided by the ip specified; * if not specified, listen on all the addresses (both ipv4 and ipv6); * specify 0.0.0.0 in the configuration leads to listen on all ipv4 addresses only; * for the future support of listening only on ipv6 addresses, we may use socket.setsockopt(socket.IPPROTO_IPV6, socket.IPV6_V6ONLY, 1) on the server's socket.
Change-Id: Ib89c349e800cb37134ef71281dd9754dd1d7cf4b Signed-off-by: huntxu mhuntxu@gmail.com --- M vdsm/clientIF.py 1 file changed, 2 insertions(+), 5 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/21/11521/1
diff --git a/vdsm/clientIF.py b/vdsm/clientIF.py index 841e962..375caa97 100644 --- a/vdsm/clientIF.py +++ b/vdsm/clientIF.py @@ -131,11 +131,8 @@
if addr: return addr - try: - addr = netinfo.getaddr(self.defaultBridge) - except: - pass - return addr + else: + return '::'
def _loadBindingXMLRPC(self): from BindingXMLRPC import BindingXMLRPC
-- To view, visit http://gerrit.ovirt.org/11521 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange Gerrit-Change-Id: Ib89c349e800cb37134ef71281dd9754dd1d7cf4b Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Hunt Xu mhuntxu@gmail.com
oVirt Jenkins CI Server has posted comments on this change.
Change subject: XMLRPCServer: support listening on ipv6 addresses ......................................................................
Patch Set 1:
Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/1018/ (1/3)
-- To view, visit http://gerrit.ovirt.org/11521 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ib89c349e800cb37134ef71281dd9754dd1d7cf4b Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Hunt Xu mhuntxu@gmail.com Gerrit-Reviewer: oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.
Change subject: XMLRPCServer: support listening on ipv6 addresses ......................................................................
Patch Set 1:
Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/129/ (2/3)
-- To view, visit http://gerrit.ovirt.org/11521 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ib89c349e800cb37134ef71281dd9754dd1d7cf4b Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Hunt Xu mhuntxu@gmail.com Gerrit-Reviewer: oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.
Change subject: XMLRPCServer: support listening on ipv6 addresses ......................................................................
Patch Set 1:
Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/983/ (3/3)
-- To view, visit http://gerrit.ovirt.org/11521 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ib89c349e800cb37134ef71281dd9754dd1d7cf4b Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Hunt Xu mhuntxu@gmail.com Gerrit-Reviewer: oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.
Change subject: XMLRPCServer: support listening on ipv6 addresses ......................................................................
Patch Set 1: Fails
Build Failed
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/983/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/1018/ : ABORTED
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/129/ : SUCCESS
-- To view, visit http://gerrit.ovirt.org/11521 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ib89c349e800cb37134ef71281dd9754dd1d7cf4b Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Hunt Xu mhuntxu@gmail.com Gerrit-Reviewer: oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.
Change subject: clientIF: RPCServers by default listen on all addresses if not specified ......................................................................
Patch Set 2:
Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/254/ (1/3)
-- To view, visit http://gerrit.ovirt.org/11521 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ib89c349e800cb37134ef71281dd9754dd1d7cf4b Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Hunt Xu mhuntxu@gmail.com Gerrit-Reviewer: Hunt Xu mhuntxu@gmail.com Gerrit-Reviewer: oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.
Change subject: clientIF: RPCServers by default listen on all addresses if not specified ......................................................................
Patch Set 2:
Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/1108/ (2/3)
-- To view, visit http://gerrit.ovirt.org/11521 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ib89c349e800cb37134ef71281dd9754dd1d7cf4b Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Hunt Xu mhuntxu@gmail.com Gerrit-Reviewer: Hunt Xu mhuntxu@gmail.com Gerrit-Reviewer: oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.
Change subject: clientIF: RPCServers by default listen on all addresses if not specified ......................................................................
Patch Set 2:
Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/1143/ (3/3)
-- To view, visit http://gerrit.ovirt.org/11521 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ib89c349e800cb37134ef71281dd9754dd1d7cf4b Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Hunt Xu mhuntxu@gmail.com Gerrit-Reviewer: Hunt Xu mhuntxu@gmail.com Gerrit-Reviewer: oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.
Change subject: clientIF: RPCServers by default listen on all addresses if not specified ......................................................................
Patch Set 2:
Build Successful
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/1108/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/1143/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/254/ : SUCCESS
-- To view, visit http://gerrit.ovirt.org/11521 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ib89c349e800cb37134ef71281dd9754dd1d7cf4b Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Hunt Xu mhuntxu@gmail.com Gerrit-Reviewer: Hunt Xu mhuntxu@gmail.com Gerrit-Reviewer: oVirt Jenkins CI Server
Hunt Xu has abandoned this change.
Change subject: clientIF: RPCServers by default listen on all addresses if not specified ......................................................................
Patch Set 2: Abandoned
Merged into http://gerrit.ovirt.org/#/c/11520/ as we supply a default address to listen on.
vdsm-patches@lists.fedorahosted.org