Change in vdsm[master]: Check if block device without invoking storage subsystem

Saggi Mizrahi has uploaded a new change for review.

Change subject: Check if block device without invoking storage subsystem
......................................................................

Check if block device without invoking storage subsystem

Change-Id: Ia452c576b56f8d91fa1c6096237c2c150d746ac4
---
M vdsm/vm.py
1 file changed, 6 insertions(+), 2 deletions(-)

git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/78/678/1
--
To view, visit http://gerrit.ovirt.org/678
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia452c576b56f8d91fa1c6096237c2c150d746ac4
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi

Adam Litke has posted comments on this change.

Change subject: Check if block device without invoking storage subsystem
......................................................................

Patch Set 1: Looks good to me, but someone else must approve

--
To view, visit http://gerrit.ovirt.org/678
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia452c576b56f8d91fa1c6096237c2c150d746ac4
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi 
Gerrit-Reviewer: Adam Litke

Eduardo has posted comments on this change.

Change subject: Check if block device without invoking storage subsystem
......................................................................

Patch Set 1: Looks good to me, but someone else must approve

--
To view, visit http://gerrit.ovirt.org/678
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia452c576b56f8d91fa1c6096237c2c150d746ac4
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Eduardo

Ayal Baron has posted comments on this change.

Change subject: Check if block device without invoking storage subsystem
......................................................................

Patch Set 2: Looks good to me, but someone else must approve

--
To view, visit http://gerrit.ovirt.org/678
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia452c576b56f8d91fa1c6096237c2c150d746ac4
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ayal Baron 
Gerrit-Reviewer: Eduardo 
Gerrit-Reviewer: Saggi Mizrahi

[Federico Simoncelli]

Federico Simoncelli has posted comments on this change.

Change subject: Check if block device without invoking storage subsystem
......................................................................

Patch Set 3: (1 inline comment)

....................................................
File vdsm/vm.py
Line 254: def isBlockDevice(path):
I know it's against your principles (not overloading utils/misc), but wouldn't make sense to expose this function somewhere else?

--
To view, visit http://gerrit.ovirt.org/678
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia452c576b56f8d91fa1c6096237c2c150d746ac4
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ayal Baron 
Gerrit-Reviewer: Eduardo 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Saggi Mizrahi

[Igor Lvovsky]

Igor Lvovsky has posted comments on this change.

Change subject: Check if block device without invoking storage subsystem
......................................................................

Patch Set 3: I would prefer that you didn't submit this

(1 inline comment)

-1 only for visibility.

....................................................
File vdsm/vm.py
Line 254: def isBlockDevice(path):
I am agree with Federico, vm.py is not a good place for this function

--
To view, visit http://gerrit.ovirt.org/678
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia452c576b56f8d91fa1c6096237c2c150d746ac4
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ayal Baron 
Gerrit-Reviewer: Eduardo 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Igor Lvovsky 
Gerrit-Reviewer: Saggi Mizrahi

Saggi Mizrahi has posted comments on this change.

Change subject: Check if block device without invoking storage subsystem
......................................................................

Patch Set 3: (1 inline comment)

....................................................
File vdsm/vm.py
Line 254: def isBlockDevice(path):
It's here because I didn't want to put it in utility or under storage. The correct solution is to dismantle the reusable parts from the storage and putting them in their own packages.

--
To view, visit http://gerrit.ovirt.org/678
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia452c576b56f8d91fa1c6096237c2c150d746ac4
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ayal Baron 
Gerrit-Reviewer: Eduardo 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Igor Lvovsky 
Gerrit-Reviewer: Saggi Mizrahi

Ayal Baron has posted comments on this change.

Change subject: Check if block device without invoking storage subsystem
......................................................................

Patch Set 4: I would prefer that you didn't submit this

(1 inline comment)

....................................................
File vdsm/vm.py
Line 469:     def _initDriveList(self, drives):
No one is calling this function?

--
To view, visit http://gerrit.ovirt.org/678
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia452c576b56f8d91fa1c6096237c2c150d746ac4
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ayal Baron 
Gerrit-Reviewer: Eduardo 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Igor Lvovsky 
Gerrit-Reviewer: Saggi Mizrahi

[Igor Lvovsky]

Igor Lvovsky has posted comments on this change.

Change subject: Check if block device without invoking storage subsystem
......................................................................

Patch Set 4: I would prefer that you didn't submit this

(1 inline comment)

....................................................
File vdsm/vm.py
Line 469:     def _initDriveList(self, drives):
It not exists anymore

--
To view, visit http://gerrit.ovirt.org/678
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia452c576b56f8d91fa1c6096237c2c150d746ac4
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ayal Baron 
Gerrit-Reviewer: Eduardo 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Igor Lvovsky 
Gerrit-Reviewer: Saggi Mizrahi

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: Check if block device without invoking storage subsystem
......................................................................

Patch Set 5: I would prefer that you didn't submit this

(1 inline comment)

....................................................
File vdsm/vm.py
Line 343:         drv['blockDev'] = not self.cif.irs.getStorageDomainInfo(
didn't you want to use the new function here?

--
To view, visit http://gerrit.ovirt.org/678
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia452c576b56f8d91fa1c6096237c2c150d746ac4
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ayal Baron 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Eduardo 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Igor Lvovsky 
Gerrit-Reviewer: Saggi Mizrahi

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: Check if block device without invoking storage subsystem
......................................................................

Patch Set 6: Looks good to me, approved

--
To view, visit http://gerrit.ovirt.org/678
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia452c576b56f8d91fa1c6096237c2c150d746ac4
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ayal Baron 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Eduardo 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Igor Lvovsky 
Gerrit-Reviewer: Saggi Mizrahi

[Igor Lvovsky]

Igor Lvovsky has posted comments on this change.

Change subject: Check if block device without invoking storage subsystem
......................................................................

Patch Set 6: Do not submit

(2 inline comments)

The first part of this patch (block device investigation) is absolutely right, but the second part (preparePaths) is wrong (why it here at all?).

....................................................
File vdsm/vm.py
Line 565:     def preparePaths(self):
No, you can't do it. We have call of this function with drives parameter

Line 566:         for drive in self.conf.get('drives', []):
Why you need it?  It's wrong since my refactoring patch, you shouldn't 
use self.conf.get('drives') anymore.  Now we have 'devices' instead of drives.

--
To view, visit http://gerrit.ovirt.org/678
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia452c576b56f8d91fa1c6096237c2c150d746ac4
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ayal Baron 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Eduardo 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Igor Lvovsky 
Gerrit-Reviewer: Saggi Mizrahi

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: Check if block device without invoking storage subsystem
......................................................................

Patch Set 6: I would prefer that you didn't submit this

Igor, good catch, but no need for -2 - I bet this is only a bad rebase.

--
To view, visit http://gerrit.ovirt.org/678
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia452c576b56f8d91fa1c6096237c2c150d746ac4
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ayal Baron 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Eduardo 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Igor Lvovsky 
Gerrit-Reviewer: Saggi Mizrahi

[Igor Lvovsky]

Igor Lvovsky has posted comments on this change.

Change subject: Check if block device without invoking storage subsystem
......................................................................

Patch Set 6: I would prefer that you didn't submit this

Dan, I just put -2, because of your +2. I know that it's only bad rebase, but if you push it you would break the master

--
To view, visit http://gerrit.ovirt.org/678
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia452c576b56f8d91fa1c6096237c2c150d746ac4
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ayal Baron 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Eduardo 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Igor Lvovsky 
Gerrit-Reviewer: Saggi Mizrahi

Change in vdsm[master]: BZ#769502 Check if block device w/o invoking storage subsyst...

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: BZ#769502 Check if block device w/o invoking storage subsystem
......................................................................

Patch Set 8: Verified; Looks good to me, approved

--
To view, visit http://gerrit.ovirt.org/678
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia452c576b56f8d91fa1c6096237c2c150d746ac4
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ayal Baron 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Eduardo 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Igor Lvovsky 
Gerrit-Reviewer: Saggi Mizrahi

Change in vdsm[master]: BZ#769502 Check if block device w/o invoking storage subsyst...

[Dan Kenigsberg]

Dan Kenigsberg has submitted this change and it was merged.

Change subject: BZ#769502 Check if block device w/o invoking storage subsystem
......................................................................

BZ#769502 Check if block device w/o invoking storage subsystem

...and fix a bug about SHAREDFS being considered as block domain.

Change-Id: Ia452c576b56f8d91fa1c6096237c2c150d746ac4
---
M vdsm/utils.py
M vdsm/vm.py
2 files changed, 7 insertions(+), 2 deletions(-)

Approvals:
  Dan Kenigsberg: Verified; Looks good to me, approved

--
To view, visit http://gerrit.ovirt.org/678
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ia452c576b56f8d91fa1c6096237c2c150d746ac4
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ayal Baron 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Eduardo 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Igor Lvovsky 
Gerrit-Reviewer: Saggi Mizrahi