1:32 a.m.
From Yaniv Bronhaim <ybronhei(a)redhat.com>:
Yaniv Bronhaim has uploaded a new change for review.
Change subject: Using vm_name instead of uuid in vm metrics report
......................................................................
Using vm_name instead of uuid in vm metrics report
The name is reported by libvirt and more useful for metrics. The uuid has no
meaning for the user, its an engine's internal value.
Change-Id: I285cc74fbb5a3a5012c3a37a9a57f60f30050606
Signed-off-by: Yaniv Bronhaim <ybronhei(a)redhat.com>
---
M lib/vdsm/virt/vmstats.py
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/34/66234/1
diff --git a/lib/vdsm/virt/vmstats.py b/lib/vdsm/virt/vmstats.py
index f5dc15f..6ab3ac4 100644
--- a/lib/vdsm/virt/vmstats.py
+++ b/lib/vdsm/virt/vmstats.py
@@ -194,8 +194,8 @@
data = {}
try:
for vm_uuid in vms_stats:
- prefix = "vms." + vm_uuid
stat = vms_stats[vm_uuid]
+ prefix = "vms." + stat['vmName']
data[prefix + '.cpu.user'] = stat['cpuUser']
data[prefix + '.cpu.sys'] = stat['cpuSys']
data[prefix + '.cpu.usage'] = stat['cpuUsage']
--
To view, visit https://gerrit.ovirt.org/66234
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I285cc74fbb5a3a5012c3a37a9a57f60f30050606
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com>
3:43 a.m.
From Yaniv Bronhaim <ybronhei(a)redhat.com>:
Yaniv Bronhaim has posted comments on this change.
Change subject: Using vm_name instead of uuid in vm metrics report
......................................................................
Patch Set 3: Verified+1
--
To view, visit https://gerrit.ovirt.org/66234
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I285cc74fbb5a3a5012c3a37a9a57f60f30050606
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
3:52 a.m.
From Yaniv Bronhaim <ybronhei(a)redhat.com>:
Yaniv Bronhaim has posted comments on this change.
Change subject: Using vm_name instead of uuid in vm metrics report
......................................................................
Patch Set 4: Verified+1
--
To view, visit https://gerrit.ovirt.org/66234
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I285cc74fbb5a3a5012c3a37a9a57f60f30050606
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
8:20 a.m.
From Yaniv Bronhaim <ybronhei(a)redhat.com>:
Yaniv Bronhaim has posted comments on this change.
Change subject: Using vm_name instead of uuid in vm metrics report
......................................................................
Patch Set 4:
(1 comment)
https://gerrit.ovirt.org/#/c/66234/4//COMMIT_MSG
Commit Message:
Line 6:
Line 7: Using vm_name instead of uuid in vm metrics report
Line 8:
Line 9: The name is reported by libvirt and more useful for metrics. The uuid has no
Line 10: meaning for the user, its an engine's internal value.
Is it unique? if libvirt/engine doe not enforce unique names, we
cannot us
No. and we use it in reporting. That's the way it currently works
Line 11:
Line 12: Change-Id: I285cc74fbb5a3a5012c3a37a9a57f60f30050606
--
To view, visit https://gerrit.ovirt.org/66234
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I285cc74fbb5a3a5012c3a37a9a57f60f30050606
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes
6:14 a.m.
From Yaniv Bronhaim <ybronhei(a)redhat.com>:
Yaniv Bronhaim has posted comments on this change.
Change subject: Using vm_name instead of uuid in vm metrics report
......................................................................
Patch Set 4:
all those issues are known, for me and for all the people related to the metrics effort.
we do this intentionally with respect to those issues.. please consider this change as a
request although the name can be not unique and request restart of the vm to update in
libvirt side and review the code itself
--
To view, visit https://gerrit.ovirt.org/66234
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I285cc74fbb5a3a5012c3a37a9a57f60f30050606
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
10:02 a.m.
From Yaniv Bronhaim <ybronhei(a)redhat.com>:
Yaniv Bronhaim has posted comments on this change.
Change subject: Using vm_name instead of uuid in vm metrics report
......................................................................
Patch Set 4:
(1 comment)
https://gerrit.ovirt.org/#/c/66234/4/lib/vdsm/virt/vmstats.py
File lib/vdsm/virt/vmstats.py:
PS4, Line 199:
It might be more generic to get the start and end of the name with ..
in th
Done
--
To view, visit https://gerrit.ovirt.org/66234
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I285cc74fbb5a3a5012c3a37a9a57f60f30050606
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes
7:07 a.m.
From Yaniv Bronhaim <ybronhei(a)redhat.com>:
Yaniv Bronhaim has posted comments on this change.
Change subject: Using vm_name instead of uuid in vm metrics report
......................................................................
Patch Set 5:
(1 comment)
https://gerrit.ovirt.org/#/c/66234/5/lib/vdsm/virt/vmstats.py
File lib/vdsm/virt/vmstats.py:
Line 198: # cut vm name to 30 characters to avoid metric provider trimming
Line 199: prefix = "vms."
Line 200: if len(stat['vmName']) > 20:
Line 201: prefix = prefix + \
Line 202: stat['vmName'][10:] + '...' +
stat['vmName'][:10]
This truncation is wrong.
You're totally right but we
don't need this anyway. the limitation was fixed in statsd plugin.
Line 203: else:
Line 204: prefix = prefix + stat['vmName']
Line 205: data[prefix + '.cpu.user'] = stat['cpuUser']
Line 206: data[prefix + '.cpu.sys'] = stat['cpuSys']
--
To view, visit https://gerrit.ovirt.org/66234
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I285cc74fbb5a3a5012c3a37a9a57f60f30050606
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes
8:18 a.m.
From Yaniv Bronhaim <ybronhei(a)redhat.com>:
Yaniv Bronhaim has posted comments on this change.
Change subject: Using vm_name instead of uuid in vm metrics report
......................................................................
Patch Set 5:
(1 comment)
https://gerrit.ovirt.org/#/c/66234/5/lib/vdsm/virt/vmstats.py
File lib/vdsm/virt/vmstats.py:
Line 198: # cut vm name to 30 characters to avoid metric provider trimming
Line 199: prefix = "vms."
Line 200: if len(stat['vmName']) > 20:
Line 201: prefix = prefix + \
Line 202: stat['vmName'][10:] + '...' +
stat['vmName'][:10]
Are you sure this is not a limit of collectd? See Shirly comment.
statsd plugin in collectd. all good and we don't need to cut the name
Line 203: else:
Line 204: prefix = prefix + stat['vmName']
Line 205: data[prefix + '.cpu.user'] = stat['cpuUser']
Line 206: data[prefix + '.cpu.sys'] = stat['cpuSys']
--
To view, visit https://gerrit.ovirt.org/66234
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I285cc74fbb5a3a5012c3a37a9a57f60f30050606
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes
2:24 a.m.
From Yaniv Bronhaim <ybronhei(a)redhat.com>:
Yaniv Bronhaim has posted comments on this change.
Change subject: Using vm_name instead of uuid in vm metrics report
......................................................................
Patch Set 6: Verified+1
--
To view, visit https://gerrit.ovirt.org/66234
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I285cc74fbb5a3a5012c3a37a9a57f60f30050606
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
7:09 a.m.
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: Using vm_name instead of uuid in vm metrics report
......................................................................
Using vm_name instead of uuid in vm metrics report
The name is reported by libvirt and more useful for metrics. The uuid
has no meaning for the user, it is an engine's internal value.
We are aware that for vm name to update libvirtd must be restarted.
This is not harmful for the metrics presentation.
Change-Id: I285cc74fbb5a3a5012c3a37a9a57f60f30050606
Signed-off-by: Yaniv Bronhaim <ybronhei(a)redhat.com>
---
M lib/vdsm/virt/sampling.py
M lib/vdsm/virt/vmstats.py
2 files changed, 10 insertions(+), 8 deletions(-)
Approvals:
Piotr Kliczewski: Looks good to me, approved
Shirly Radco: Looks good to me, but someone else must approve
Yaniv Bronhaim: Verified
Jenkins CI: Passed CI tests
Irit Goihman: Looks good to me, but someone else must approve
Francesco Romani: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/66234
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I285cc74fbb5a3a5012c3a37a9a57f60f30050606
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
2754
days inactive
2770
days old
vdsm-patches@lists.fedorahosted.org
9 comments
1 participants
participants (1)
-
Code Review