Itzik Brown has uploaded a new change for review.
Change subject: Adding hooks support for NIC hotplug ......................................................................
Adding hooks support for NIC hotplug
Adding the ability to write hooks for events of NIC hotplug and hotunplug. Hooks are: before_nic_plug and after_nic_unplug
Change-Id: I253104ee9831a881e2fb06f0a658631662611d77 Signed-off-by: Itzik Brown itzikb@mellanox.com --- M vdsm.spec.in M vdsm/hooks.py M vdsm/libvirtvm.py M vdsm_hooks/Makefile.am 4 files changed, 15 insertions(+), 0 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/24/7224/1
diff --git a/vdsm.spec.in b/vdsm.spec.in index 23afd6b..0d5f82d 100644 --- a/vdsm.spec.in +++ b/vdsm.spec.in @@ -658,6 +658,8 @@ %dir %{_libexecdir}/%{vdsm_name}/hooks/after_vm_destroy %dir %{_libexecdir}/%{vdsm_name}/hooks/before_vm_set_ticket %dir %{_libexecdir}/%{vdsm_name}/hooks/after_vm_set_ticket +%dir %{_libexecdir}/%{vdsm_name}/hooks/before_nic_plug +%dir %{_libexecdir}/%{vdsm_name}/hooks/after_nic_unplug %dir %{_libexecdir}/%{vdsm_name}/hooks/before_vdsm_start %dir %{_libexecdir}/%{vdsm_name}/hooks/after_vdsm_stop %{_datadir}/%{vdsm_name}/addNetwork diff --git a/vdsm/hooks.py b/vdsm/hooks.py index 5b79cee..64263b3 100644 --- a/vdsm/hooks.py +++ b/vdsm/hooks.py @@ -174,6 +174,14 @@ raiseError=False, params=params)
+def before_nic_hotplug(domxml, vmconf={}): + return _runHooksDir(domxml, 'before_vm_hotplug', vmconf=vmconf) + + +def after_nic_unplug(domxml, vmconf={}): + return _runHooksDir(domxml, 'after_vm_unplug', vmconf=vmconf) + + def before_vdsm_start(): return _runHooksDir(None, 'before_vdsm_start', raiseError=False)
diff --git a/vdsm/libvirtvm.py b/vdsm/libvirtvm.py index 3b7cfc5..4ae54f7 100644 --- a/vdsm/libvirtvm.py +++ b/vdsm/libvirtvm.py @@ -1395,12 +1395,14 @@ nicParams = params.get('nic', {}) nic = NetworkInterfaceDevice(self.conf, self.log, **nicParams) nicXml = nic.getXML().toprettyxml(encoding='utf-8') + nicXml = hooks.before_nic_hotplug(nicXml, self.conf) self.log.debug("Hotplug NIC xml: %s" % (nicXml))
try: self._dom.attachDevice(nicXml) except libvirt.libvirtError, e: self.log.error("Hotplug failed", exc_info=True) + nicXml = hooks.after_nic_unplug(nicXml, self.conf) if e.get_error_code() == libvirt.VIR_ERR_NO_DOMAIN: return errCode['noVM'] return {'status' : {'code': errCode['hotplugNic']['status']['code'], @@ -1454,6 +1456,7 @@
try: self._dom.detachDevice(nicXml) + hooks.after_nic_unplug(nicXml, self.conf) except libvirt.libvirtError, e: self.log.error("Hotunplug failed", exc_info=True) if e.get_error_code() == libvirt.VIR_ERR_NO_DOMAIN: diff --git a/vdsm_hooks/Makefile.am b/vdsm_hooks/Makefile.am index e6a8280..36919d9 100644 --- a/vdsm_hooks/Makefile.am +++ b/vdsm_hooks/Makefile.am @@ -74,6 +74,8 @@ after_vm_destroy \ before_vm_set_ticket \ after_vm_set_ticket \ + before_nic_plug \ + after_nic_unplug \ before_vdsm_start \ after_vdsm_stop
-- To view, visit http://gerrit.ovirt.org/7224 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange Gerrit-Change-Id: I253104ee9831a881e2fb06f0a658631662611d77 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Itzik Brown itzikb@mellanox.com
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Adding hooks support for NIC hotplug ......................................................................
Patch Set 1:
Build Failed
http://jenkins.ovirt.info/job/patch_vdsm_unit_tests/463/ : ABORTED
-- To view, visit http://gerrit.ovirt.org/7224 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I253104ee9831a881e2fb06f0a658631662611d77 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Itzik Brown itzikb@mellanox.com Gerrit-Reviewer: oVirt Jenkins CI Server
Dan Kenigsberg has posted comments on this change.
Change subject: Adding hooks support for NIC hotplug ......................................................................
Patch Set 1: (4 inline comments)
Thanks, Izik, for this patch. I think it would be cool to add more hook locations to vdsm.
I have a couple of questions inside. Please update the man page in this commit, too.
.................................................... File vdsm/hooks.py Line 173: return _runHooksDir(domxml, 'after_vm_set_ticket', vmconf=vmconf, Line 174: raiseError=False, params=params) Line 175: Line 176: Line 177: def before_nic_hotplug(domxml, vmconf={}): it's not domxml, but nicxml, or something. Line 178: return _runHooksDir(domxml, 'before_vm_hotplug', vmconf=vmconf) Line 179: Line 180: Line 181: def after_nic_unplug(domxml, vmconf={}):
Line 178: return _runHooksDir(domxml, 'before_vm_hotplug', vmconf=vmconf) Line 179: Line 180: Line 181: def after_nic_unplug(domxml, vmconf={}): Line 182: return _runHooksDir(domxml, 'after_vm_unplug', vmconf=vmconf) I think you don't want this hook to raiseError. if the hook script fails, nothing is to be canceled. Line 183: Line 184: Line 185: def before_vdsm_start(): Line 186: return _runHooksDir(None, 'before_vdsm_start', raiseError=False)
.................................................... File vdsm/libvirtvm.py Line 1401: try: Line 1402: self._dom.attachDevice(nicXml) Line 1403: except libvirt.libvirtError, e: Line 1404: self.log.error("Hotplug failed", exc_info=True) Line 1405: nicXml = hooks.after_nic_unplug(nicXml, self.conf) we've never had a similar hook, placed in a fail condition. I suppose that it is here in order to release resources that where allocated in before_nic_hotplug.
I find the naming quite misleading - there was *no* unplug in this case. Maybe another name (after_nic_hotplug_fail??) would make it clearer, maybe something completely different. Line 1406: if e.get_error_code() == libvirt.VIR_ERR_NO_DOMAIN: Line 1407: return errCode['noVM'] Line 1408: return {'status' : {'code': errCode['hotplugNic']['status']['code'], Line 1409: 'message': e.message}}
Line 1455: self.saveState() Line 1456: Line 1457: try: Line 1458: self._dom.detachDevice(nicXml) Line 1459: hooks.after_nic_unplug(nicXml, self.conf) does this really need to sit in the try-block? Line 1460: except libvirt.libvirtError, e: Line 1461: self.log.error("Hotunplug failed", exc_info=True) Line 1462: if e.get_error_code() == libvirt.VIR_ERR_NO_DOMAIN: Line 1463: return errCode['noVM']
-- To view, visit http://gerrit.ovirt.org/7224 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I253104ee9831a881e2fb06f0a658631662611d77 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Itzik Brown itzikb@mellanox.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
Dan Kenigsberg has posted comments on this change.
Change subject: Adding hooks support for NIC hotplug ......................................................................
Patch Set 1: I would prefer that you didn't submit this
(1 inline comment)
oh, updating the unit test would be appreciated, too.
.................................................... File vdsm_hooks/Makefile.am Line 73: before_vm_destroy \ Line 74: after_vm_destroy \ Line 75: before_vm_set_ticket \ Line 76: after_vm_set_ticket \ Line 77: before_nic_plug \ you're not the first, but please use tabs here, like most of the hooks. Line 78: after_nic_unplug \ Line 79: before_vdsm_start \ Line 80: after_vdsm_stop Line 81:
-- To view, visit http://gerrit.ovirt.org/7224 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I253104ee9831a881e2fb06f0a658631662611d77 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Itzik Brown itzikb@mellanox.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
Igor Lvovsky has posted comments on this change.
Change subject: Adding hooks support for NIC hotplug ......................................................................
Patch Set 3: Looks good to me, but someone else must approve
Itzik, I would glad to see the hook itself if it possible
-- To view, visit http://gerrit.ovirt.org/7224 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I253104ee9831a881e2fb06f0a658631662611d77 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Itzik Brown itzikb@mellanox.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Itzik Brown itzikb@mellanox.com Gerrit-Reviewer: oVirt Jenkins CI Server
Itzik Brown has posted comments on this change.
Change subject: Adding hooks support for NIC hotplug ......................................................................
Patch Set 3: Verified
-- To view, visit http://gerrit.ovirt.org/7224 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I253104ee9831a881e2fb06f0a658631662611d77 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Itzik Brown itzikb@mellanox.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Itzik Brown itzikb@mellanox.com Gerrit-Reviewer: oVirt Jenkins CI Server
Dan Kenigsberg has posted comments on this change.
Change subject: Adding hooks support for NIC hotplug ......................................................................
Patch Set 3: I would prefer that you didn't submit this
(2 inline comments)
I'm sorry that it took me so long to review this patch, but I have two relatively minor concerns.
.................................................... File vdsm/libvirtvm.py Line 1514: return { Line 1515: 'status': {'code': errCode['hotunplugNic']['status']['code'], Line 1516: 'message': e.message}} Line 1517: Line 1518: hooks.after_nic_unplug(nicXml, self.conf) naming is a bit asymmetrical: why unplog is not "hot"? Line 1519: return {'status': doneCode, 'vmList': self.status()} Line 1520: Line 1521: def hotplugDisk(self, params): Line 1522: if self.isMigrating():
.................................................... File vdsm/vdsmd.8.in Line 57: .SS Hook environment Line 58: Each hook script (except before_vdsm_start and after_vdsm_stop) inherit the Line 59: environment of the VDSM process, with an additional variable Line 60: .B _hook_domxml Line 61: which holds the path of libvirt's this is not exact for the new hooks - the nic xml is passed here.
I find the naming a bit awkward. Maybe these 3 hooks should use _hook_nicxml. At the least, this peculiarity has to be documented. Line 62: .B domain xml Line 63: representation of the relevant virtual machine. Line 64: The uuid of the virtual machine may be deduced from that xml, but it is also Line 65: available as the environment variable
-- To view, visit http://gerrit.ovirt.org/7224 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I253104ee9831a881e2fb06f0a658631662611d77 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Itzik Brown itzikb@mellanox.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Itzik Brown itzikb@mellanox.com Gerrit-Reviewer: oVirt Jenkins CI Server
Mark Wu has posted comments on this change.
Change subject: Adding hooks support for NIC hotplug ......................................................................
Patch Set 3: I would prefer that you didn't submit this
(2 inline comments)
.................................................... Commit Message Line 8: Line 9: Adding the ability to write hooks for events Line 10: of NIC hotplug and hotunplug. Line 11: Hooks are: before_nic_hotplug, after_nic_unplug Line 12: and after_nic_hotplug_fail why not after_nic_hotplug, before_nic_hotunplug and after_nic_hotunplug_fail ? Am I missing some design discussions? Line 13: Line 14: Change-Id: I253104ee9831a881e2fb06f0a658631662611d77
.................................................... File vdsm/libvirtvm.py Line 1428: Line 1429: nicParams = params.get('nic', {}) Line 1430: nic = NetworkInterfaceDevice(self.conf, self.log, **nicParams) Line 1431: nicXml = nic.getXML().toprettyxml(encoding='utf-8') Line 1432: nicXml = hooks.before_nic_hotplug(nicXml, self.conf) the nicParams is not included in self.conf at this point, how about passing it the to hook script by the of param 'params' of _runHooksDir . Then the hook can have different behavior according to the configuration. Line 1433: self.log.debug("Hotplug NIC xml: %s" % (nicXml)) Line 1434: Line 1435: try: Line 1436: self._dom.attachDevice(nicXml)
-- To view, visit http://gerrit.ovirt.org/7224 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I253104ee9831a881e2fb06f0a658631662611d77 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Itzik Brown itzikb@mellanox.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Itzik Brown itzikb@mellanox.com Gerrit-Reviewer: Mark Wu wudxw@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server
Dan Kenigsberg has posted comments on this change.
Change subject: Adding hooks support for NIC hotplug ......................................................................
Patch Set 3: (1 inline comment)
.................................................... File vdsm/libvirtvm.py Line 1428: Line 1429: nicParams = params.get('nic', {}) Line 1430: nic = NetworkInterfaceDevice(self.conf, self.log, **nicParams) Line 1431: nicXml = nic.getXML().toprettyxml(encoding='utf-8') Line 1432: nicXml = hooks.before_nic_hotplug(nicXml, self.conf) this makes sense, but please do not replace self.conf with something else, as the hook script may well want to see vm-wide custom properties. Line 1433: self.log.debug("Hotplug NIC xml: %s" % (nicXml)) Line 1434: Line 1435: try: Line 1436: self._dom.attachDevice(nicXml)
-- To view, visit http://gerrit.ovirt.org/7224 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I253104ee9831a881e2fb06f0a658631662611d77 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Itzik Brown itzikb@mellanox.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Itzik Brown itzikb@mellanox.com Gerrit-Reviewer: Mark Wu wudxw@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server
Itzik Brown has posted comments on this change.
Change subject: Adding hooks support for NIC hotplug ......................................................................
Patch Set 3: No score
(2 inline comments)
.................................................... Commit Message Line 8: Line 9: Adding the ability to write hooks for events Line 10: of NIC hotplug and hotunplug. Line 11: Hooks are: before_nic_hotplug, after_nic_unplug Line 12: and after_nic_hotplug_fail I'll address it in my next patch Line 13: Line 14: Change-Id: I253104ee9831a881e2fb06f0a658631662611d77
.................................................... File vdsm/libvirtvm.py Line 1428: Line 1429: nicParams = params.get('nic', {}) Line 1430: nic = NetworkInterfaceDevice(self.conf, self.log, **nicParams) Line 1431: nicXml = nic.getXML().toprettyxml(encoding='utf-8') Line 1432: nicXml = hooks.before_nic_hotplug(nicXml, self.conf) I think that since there is no option in the engine to see or change these parameters.I'll send a message to the mailing list so we can design it together. Line 1433: self.log.debug("Hotplug NIC xml: %s" % (nicXml)) Line 1434: Line 1435: try: Line 1436: self._dom.attachDevice(nicXml)
-- To view, visit http://gerrit.ovirt.org/7224 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I253104ee9831a881e2fb06f0a658631662611d77 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Itzik Brown itzikb@mellanox.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Itzik Brown itzikb@mellanox.com Gerrit-Reviewer: Mark Wu wudxw@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Adding hooks support for NIC hotplug ......................................................................
Patch Set 4:
Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_manual_gerrit/49/ (2/2)
-- To view, visit http://gerrit.ovirt.org/7224 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I253104ee9831a881e2fb06f0a658631662611d77 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Itzik Brown itzikb@mellanox.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Itzik Brown itzikb@mellanox.com Gerrit-Reviewer: Mark Wu wudxw@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Adding hooks support for NIC hotplug ......................................................................
Patch Set 4:
Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/26/ (1/2)
-- To view, visit http://gerrit.ovirt.org/7224 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I253104ee9831a881e2fb06f0a658631662611d77 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Itzik Brown itzikb@mellanox.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Itzik Brown itzikb@mellanox.com Gerrit-Reviewer: Mark Wu wudxw@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Adding hooks support for NIC hotplug ......................................................................
Patch Set 4: I would prefer that you didn't submit this
Build Unstable
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/26/ : UNSTABLE
http://jenkins.ovirt.org/job/vdsm_unit_tests_manual_gerrit/49/ : SUCCESS
-- To view, visit http://gerrit.ovirt.org/7224 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I253104ee9831a881e2fb06f0a658631662611d77 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Itzik Brown itzikb@mellanox.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Itzik Brown itzikb@mellanox.com Gerrit-Reviewer: Mark Wu wudxw@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Adding hooks support for NIC hotplug ......................................................................
Patch Set 5:
Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_manual_gerrit/50/ (2/2)
-- To view, visit http://gerrit.ovirt.org/7224 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I253104ee9831a881e2fb06f0a658631662611d77 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Itzik Brown itzikb@mellanox.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Itzik Brown itzikb@mellanox.com Gerrit-Reviewer: Mark Wu wudxw@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Adding hooks support for NIC hotplug ......................................................................
Patch Set 5:
Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/27/ (1/2)
-- To view, visit http://gerrit.ovirt.org/7224 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I253104ee9831a881e2fb06f0a658631662611d77 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Itzik Brown itzikb@mellanox.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Itzik Brown itzikb@mellanox.com Gerrit-Reviewer: Mark Wu wudxw@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Adding hooks support for NIC hotplug ......................................................................
Patch Set 5:
Build Successful
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/27/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_unit_tests_manual_gerrit/50/ : SUCCESS
-- To view, visit http://gerrit.ovirt.org/7224 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I253104ee9831a881e2fb06f0a658631662611d77 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Itzik Brown itzikb@mellanox.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Itzik Brown itzikb@mellanox.com Gerrit-Reviewer: Mark Wu wudxw@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server
Itzik Brown has posted comments on this change.
Change subject: Adding hooks support for NIC hotplug ......................................................................
Patch Set 5: Verified; Looks good to me, but someone else must approve
Verification was done for the Hooks: before_nic_hotplug, after_nic_hotplug, before_nic_hotunplug,after_nic_hotunplug
after_nic_hotplug_fail and after_nic_hotunplug_fail weren't verified.
-- To view, visit http://gerrit.ovirt.org/7224 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I253104ee9831a881e2fb06f0a658631662611d77 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Itzik Brown itzikb@mellanox.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Itzik Brown itzikb@mellanox.com Gerrit-Reviewer: Mark Wu wudxw@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server
Dan Kenigsberg has posted comments on this change.
Change subject: Adding hooks support for NIC hotplug ......................................................................
Patch Set 5: Looks good to me, but someone else must approve
-- To view, visit http://gerrit.ovirt.org/7224 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I253104ee9831a881e2fb06f0a658631662611d77 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Itzik Brown itzikb@mellanox.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Itzik Brown itzikb@mellanox.com Gerrit-Reviewer: Mark Wu wudxw@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server
Igor Lvovsky has posted comments on this change.
Change subject: Adding hooks support for NIC hotplug ......................................................................
Patch Set 5: Looks good to me, but someone else must approve
I still would like to see the hooks examples
-- To view, visit http://gerrit.ovirt.org/7224 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I253104ee9831a881e2fb06f0a658631662611d77 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Itzik Brown itzikb@mellanox.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Itzik Brown itzikb@mellanox.com Gerrit-Reviewer: Mark Wu wudxw@linux.vnet.ibm.com Gerrit-Reviewer: Yeela Kaplan ykaplan@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
Dan Kenigsberg has posted comments on this change.
Change subject: Adding hooks support for NIC hotplug ......................................................................
Patch Set 5: Verified; Looks good to me, approved
Thanks, Itzik. If you want this downstream, please open a RHEL6 bug.
-- To view, visit http://gerrit.ovirt.org/7224 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I253104ee9831a881e2fb06f0a658631662611d77 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Itzik Brown itzikb@mellanox.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Itzik Brown itzikb@mellanox.com Gerrit-Reviewer: Mark Wu wudxw@linux.vnet.ibm.com Gerrit-Reviewer: Yeela Kaplan ykaplan@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
Dan Kenigsberg has submitted this change and it was merged.
Change subject: Adding hooks support for NIC hotplug ......................................................................
Adding hooks support for NIC hotplug
Adding the ability to write hooks for events of NIC hotplug and hotunplug. Hooks are: before_nic_hotplug, after_nic_hotplug, before_nic_hotunplug,after_nic_hotunplug, after_nic_hotplug_fail and after_nic_hotunplug_fail
Change-Id: I253104ee9831a881e2fb06f0a658631662611d77 Signed-off-by: Itzik Brown itzikb@mellanox.com --- M vdsm.spec.in M vdsm/hooks.py M vdsm/libvirtvm.py M vdsm/vdsmd.8.in M vdsm_hooks/Makefile.am 5 files changed, 52 insertions(+), 2 deletions(-)
Approvals: Dan Kenigsberg: Verified; Looks good to me, approved Igor Lvovsky: Looks good to me, but someone else must approve
-- To view, visit http://gerrit.ovirt.org/7224 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged Gerrit-Change-Id: I253104ee9831a881e2fb06f0a658631662611d77 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Itzik Brown itzikb@mellanox.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Itzik Brown itzikb@mellanox.com Gerrit-Reviewer: Mark Wu wudxw@linux.vnet.ibm.com Gerrit-Reviewer: Yeela Kaplan ykaplan@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
vdsm-patches@lists.fedorahosted.org