Change in vdsm[master]: Removing unused logErr parameter from execCmd

Yaniv Bronhaim has uploaded a new change for review.

Change subject: Removing unused logErr parameter from execCmd
......................................................................

Removing unused logErr parameter from execCmd

Change-Id: Ic07b3524246d8795df8accf35c9a9a82e42d8497
Signed-off-by: Yaniv Bronhaim 
---
M lib/vdsm/utils.py
M vdsm/storage/misc.py
2 files changed, 5 insertions(+), 5 deletions(-)

git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/50/28050/1

diff --git a/lib/vdsm/utils.py b/lib/vdsm/utils.py
index 600fc7d..092ef2f 100644
--- a/lib/vdsm/utils.py
+++ b/lib/vdsm/utils.py
@@ -644,7 +644,7 @@
         self._poller.close()

-def execCmd(command, sudo=False, cwd=None, data=None, raw=False, logErr=True,
+def execCmd(command, sudo=False, cwd=None, data=None, raw=False,
             printable=None, env=None, sync=True, nice=None, ioclass=None,
             ioclassdata=None, setsid=False, execCmdLogger=logging.root,
             deathSignal=0, childUmask=None):
diff --git a/vdsm/storage/misc.py b/vdsm/storage/misc.py
index 4eb56e7..6dd2679 100644
--- a/vdsm/storage/misc.py
+++ b/vdsm/storage/misc.py
@@ -506,9 +506,9 @@
         newName = os.path.join(directory, fd[key]['new'])
         if isOvirtNode() and persist and not cp:
             try:
-                execCmd([constants.EXT_UNPERSIST, oldName], logErr=False,
+                execCmd([constants.EXT_UNPERSIST, oldName],
                         sudo=True)
-                execCmd([constants.EXT_UNPERSIST, newName], logErr=False,
+                execCmd([constants.EXT_UNPERSIST, newName],
                         sudo=True)
             except:
                 pass
@@ -516,7 +516,7 @@
             if cp:
                 execCmd([constants.EXT_CP, oldName, newName], sudo=True)
                 if isOvirtNode() and persist and not os.path.exists(newName):
-                    execCmd([constants.EXT_PERSIST, newName], logErr=False,
+                    execCmd([constants.EXT_PERSIST, newName],
                             sudo=True)

else:
@@ -525,7 +525,7 @@
             pass
         if isOvirtNode() and persist and not cp:
             try:
-                execCmd([constants.EXT_PERSIST, newName], logErr=False,
+                execCmd([constants.EXT_PERSIST, newName],
                         sudo=True)
             except:
                 pass

Antoni Segura Puimedon has posted comments on this change.

Change subject: Removing unused logErr parameter from execCmd
......................................................................

Patch Set 1: Code-Review+1

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: Removing unused logErr parameter from execCmd
......................................................................

Patch Set 1:

Build Failed

http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9209/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9352/ : FAILURE

http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8421/ : SUCCESS

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: Removing unused logErr parameter from execCmd
......................................................................

Patch Set 1: Code-Review+2

more of rotateFiles should die.

Yaniv Bronhaim has posted comments on this change.

Change subject: Removing unused logErr parameter from execCmd
......................................................................

Patch Set 1: Verified+1

Yaniv Bronhaim has posted comments on this change.

Change subject: Removing unused logErr parameter from execCmd
......................................................................

Patch Set 1:

lets just wait for saggi's approval .

[Nir Soffer]

Nir Soffer has posted comments on this change.

Change subject: Removing unused logErr parameter from execCmd
......................................................................

Patch Set 1: Code-Review+1

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: Removing unused logErr parameter from execCmd
......................................................................

Patch Set 1:

I'm not sure why Saggi's approval is needed here, but if you want - we can wait.

[Nir Soffer]

Nir Soffer has posted comments on this change.

Change subject: Removing unused logErr parameter from execCmd
......................................................................

Patch Set 1:

I think we are wasting everyone time and the last thing Saggi want to do is approve removal of unused argument that he suggested to remove himself :-)

Saggi Mizrahi has posted comments on this change.

Change subject: Removing unused logErr parameter from execCmd
......................................................................

Patch Set 1: Code-Review+2

[Dan Kenigsberg]

Dan Kenigsberg has submitted this change and it was merged.

Change subject: Removing unused logErr parameter from execCmd
......................................................................

Removing unused logErr parameter from execCmd

Change-Id: Ic07b3524246d8795df8accf35c9a9a82e42d8497
Signed-off-by: Yaniv Bronhaim 
Reviewed-on: http://gerrit.ovirt.org/28050
Reviewed-by: Antoni Segura Puimedon 
Reviewed-by: Dan Kenigsberg 
Reviewed-by: Nir Soffer 
Reviewed-by: Saggi Mizrahi 
---
M lib/vdsm/utils.py
M vdsm/storage/misc.py
2 files changed, 5 insertions(+), 5 deletions(-)

Approvals:
  Nir Soffer: Looks good to me, but someone else must approve
  Yaniv Bronhaim: Verified
  Saggi Mizrahi: Looks good to me, approved
  Antoni Segura Puimedon: Looks good to me, but someone else must approve
  Dan Kenigsberg: Looks good to me, approved

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: Removing unused logErr parameter from execCmd
......................................................................

Patch Set 2:

Build Failed

http://jenkins.ovirt.org/job/vdsm_master_create-rpms_merged/1382/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_copr/6/ : FAILURE