9:22 a.m.
Douglas Schilling Landgraf has uploaded a new change for review.
Change subject: replace /rhev repository to /ovirt
......................................................................
replace /rhev repository to /ovirt
This patch will fix the below behaviour and will remove all /rhev
references from the code.
$ service vdsmd start
vdsm: libvirt already configured for vdsm [ OK ]
Starting iscsid:
Redirecting to /bin/systemctl start libvirtd.service
/bin/mkdir: cannot create directory `/rhev': Read-only file system
/bin/chown: cannot access `/rhev/data-center': No such file or directory
Starting up vdsm daemon:
vdsm start [ OK ]
Change-Id: I4fee83a4d31190e11c6d776d61ef2d111f97518d
---
M vdsm.spec.in
M vdsm/config.py
M vdsm/storage/fileSD.py
M vdsm/storage/fileVolume.py
M vdsm/storage/sp.py
M vdsm/vdsm-sosplugin.py.in
M vdsm/vdsm.rwtab
M vdsm/vdsmd.init.in
8 files changed, 9 insertions(+), 7 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/49/449/1
--
To view, visit http://gerrit.ovirt.org/449
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I4fee83a4d31190e11c6d776d61ef2d111f97518d
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com>
9:50 a.m.
Dan Kenigsberg has posted comments on this change.
Change subject: replace /rhev repository to /ovirt
......................................................................
Patch Set 1: I would prefer that you didn't submit this
(1 inline comment)
minor comment on top of the others'.
please verify that this change does not matter to rhev-m-3.0, and the VMs starts like
always, event with CDROMs attached.
....................................................
File vdsm.spec.in
Line 157: mkdir /ovirt
I'm not sure why we need to create the directory here. If we do, it should probably
done in %install and listed under %files.
--
To view, visit http://gerrit.ovirt.org/449
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4fee83a4d31190e11c6d776d61ef2d111f97518d
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
11:21 a.m.
Douglas Schilling Landgraf has posted comments on this change.
Change subject: replace /rhev repository to /ovirt
......................................................................
Patch Set 1:
From: http://www.pathname.com/fhs/pub/fhs-2.3.pdf
3.16. /srv : Data for services provided by this system
3.16.1. Purpose
/srv contains site-specific data which is served by this system.
Rationale
This main purpose of specifying this is so that users may find the location of the data
files for particular
service, and so that services which require a single tree for readonly data, writable data
and scripts (such as
cgi scripts) can be reasonably placed. Data that is only of interest to a specific user
should go in that users’
home directory.
The methodology used to name subdirectories of /srv is unspecified as there is currently no
consensus on
how this should be done. One method for structuring data under /srv is by protocol, eg.
ftp, rsync, www,
and cvs. On large systems it can be useful to structure /srv by administrative context,
such as
/srv/physics/www, /srv/compsci/cvs, etc. This setup will differ from host to host.
Therefore, no program
should rely on a specific subdirectory structure of /srv existing or data necessarily being
stored in /srv.
However /srv should always exist on FHS compliant systems and should be used as the
default location for
such data.
Distributions must take care not to remove locally placed files in these directories
without administrator
permission.
- Please let me know your findings
--
To view, visit http://gerrit.ovirt.org/449
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4fee83a4d31190e11c6d776d61ef2d111f97518d
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
5:27 a.m.
New subject: Change in vdsm[master]: replace /rhev repository to /var/lib/vdsm
Douglas Schilling Landgraf has abandoned this change.
Change subject: replace /rhev repository to /var/lib/vdsm
......................................................................
Patch Set 3: Abandoned
We are going with /rhev directory for now.
--
To view, visit http://gerrit.ovirt.org/449
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: abandon
Gerrit-Change-Id: I4fee83a4d31190e11c6d776d61ef2d111f97518d
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Alan Pevec <apevec(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
12:25 p.m.
New subject: Change in vdsm[master]: replace /rhev repository to /var/lib/vdsm
Douglas Schilling Landgraf has posted comments on this change.
Change subject: replace /rhev repository to /var/lib/vdsm
......................................................................
Patch Set 3: (2 inline comments)
....................................................
File vdsm/storage/fileSD.py
Line 46: return metafile.split('/')[5]
ignore my last comment about -1
....................................................
File vdsm/storage/fileVolume.py
Line 37: return volPath.split('/')[4]
ignore my last comment about -1
--
To view, visit http://gerrit.ovirt.org/449
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4fee83a4d31190e11c6d776d61ef2d111f97518d
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Alan Pevec <apevec(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
11:29 a.m.
New subject: Change in vdsm[master]: replace /rhev repository to /var/lib/vdsm
Douglas Schilling Landgraf has posted comments on this change.
Change subject: replace /rhev repository to /var/lib/vdsm
......................................................................
Patch Set 3: (3 inline comments)
....................................................
File vdsm/storage/fileSD.py
Line 46: return metafile.split('/')[5]
Good catch, thanks. However, I will use -1 instead of 7. If in the future we need to
change it again, it will automatically take the last entry (metadata).
....................................................
File vdsm/storage/fileVolume.py
Line 37: return volPath.split('/')[4]
Good catch, thanks. However, I will use -1 instead of 7. If in the future we need to
change it again, it will automatically take the last entry (metadata).
....................................................
File vdsm/vdsm-sosplugin.py.in
Line 67: self.collectExtOutput("/bin/su vdsm -s /bin/sh -c '/usr/bin/tree
/var/lib/vdsm/data-center/'")
Ok, I will prepare a new patch.
--
To view, visit http://gerrit.ovirt.org/449
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4fee83a4d31190e11c6d776d61ef2d111f97518d
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Alan Pevec <apevec(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
10:53 a.m.
New subject: Change in vdsm[master]: replace /rhev repository to /var/lib/vdsm
Igor Lvovsky has posted comments on this change.
Change subject: replace /rhev repository to /var/lib/vdsm
......................................................................
Patch Set 3: I would prefer that you didn't submit this
(2 inline comments)
....................................................
File vdsm/storage/fileSD.py
Line 46: return metafile.split('/')[5]
[5] is wrong, should be [7]
....................................................
File vdsm/storage/fileVolume.py
Line 37: return volPath.split('/')[4]
Now [4] is wrong, it should be [6]
--
To view, visit http://gerrit.ovirt.org/449
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4fee83a4d31190e11c6d776d61ef2d111f97518d
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Alan Pevec <apevec(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
6:19 a.m.
New subject: Change in vdsm[master]: replace /rhev repository to /var/lib/vdsm
Douglas Schilling Landgraf has posted comments on this change.
Change subject: replace /rhev repository to /var/lib/vdsm
......................................................................
Patch Set 3:
Hi Dan,
indeed, looks like a better place.
--
To view, visit http://gerrit.ovirt.org/449
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4fee83a4d31190e11c6d776d61ef2d111f97518d
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Alan Pevec <apevec(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
1:13 a.m.
New subject: Change in vdsm[master]: replace /rhev repository to /var/lib/vdsm
Dan Kenigsberg has posted comments on this change.
Change subject: replace /rhev repository to /var/lib/vdsm
......................................................................
Patch Set 3: I would prefer that you didn't submit this
(1 inline comment)
hmm, come to think of it, /var/run/vdsm may be better since nothing there is expected to
be relevant after reboot.
....................................................
File vdsm/vdsm-sosplugin.py.in
Line 67: self.collectExtOutput("/bin/su vdsm -s /bin/sh -c '/usr/bin/tree
/var/lib/vdsm/data-center/'")
better take this out to a CONSTANT (and do tree and ls for the very same directory)
--
To view, visit http://gerrit.ovirt.org/449
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4fee83a4d31190e11c6d776d61ef2d111f97518d
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Alan Pevec <apevec(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
5:38 p.m.
New subject: Change in vdsm[master]: replace /rhev repository to /var/lib/vdsm
Douglas Schilling Landgraf has posted comments on this change.
Change subject: replace /rhev repository to /var/lib/vdsm
......................................................................
Patch Set 3: Verified
I have tested the patch. Created Data and Iso Storage, installed a virtual machine and
it's running.
--
To view, visit http://gerrit.ovirt.org/449
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4fee83a4d31190e11c6d776d61ef2d111f97518d
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Alan Pevec <apevec(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
8:53 a.m.
Alan Pevec has posted comments on this change.
Change subject: replace /rhev repository to /ovirt
......................................................................
Patch Set 2:
/var/lib/vdsm is better location and should be included in RPM, also it should be made to
work with SELinux.
--
To view, visit http://gerrit.ovirt.org/449
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4fee83a4d31190e11c6d776d61ef2d111f97518d
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Alan Pevec <apevec(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
1:51 p.m.
Douglas Schilling Landgraf has posted comments on this change.
Change subject: replace /rhev repository to /ovirt
......................................................................
Patch Set 2:
The patch worked here, I have created a virtual machine and attached a ISO to install it.
I had to disable selinux to get /ovirt working.
--
To view, visit http://gerrit.ovirt.org/449
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4fee83a4d31190e11c6d776d61ef2d111f97518d
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
1:25 a.m.
Dan Kenigsberg has posted comments on this change.
Change subject: replace /rhev repository to /ovirt
......................................................................
Patch Set 2: I would prefer that you didn't submit this
(1 inline comment)
....................................................
File vdsm.spec.in
Line 293: mkdir /ovirt
I don't see my former comments referred to.
--
To view, visit http://gerrit.ovirt.org/449
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4fee83a4d31190e11c6d776d61ef2d111f97518d
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
12:57 a.m.
Douglas Schilling Landgraf has posted comments on this change.
Change subject: replace /rhev repository to /ovirt
......................................................................
Patch Set 1:
new version will be created, I used config.py not config.py.in
--
To view, visit http://gerrit.ovirt.org/449
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4fee83a4d31190e11c6d776d61ef2d111f97518d
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
10:19 a.m.
Douglas Schilling Landgraf has posted comments on this change.
Change subject: replace /rhev repository to /ovirt
......................................................................
Patch Set 1:
Good catch Saggi, I am going to open BZ for RHEL/Fedora guys. However, I would like to
confirm with you guys if we will use /ovirt or other path.
--
To view, visit http://gerrit.ovirt.org/449
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4fee83a4d31190e11c6d776d61ef2d111f97518d
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
9:48 a.m.
Federico Simoncelli has posted comments on this change.
Change subject: replace /rhev repository to /ovirt
......................................................................
Patch Set 1:
Since we have this great opportunity to move it, did we check in FHS if there's a
better place for this rather than the root?
--
To view, visit http://gerrit.ovirt.org/449
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4fee83a4d31190e11c6d776d61ef2d111f97518d
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
9:45 a.m.
Saggi Mizrahi has posted comments on this change.
Change subject: replace /rhev repository to /ovirt
......................................................................
Patch Set 1: I would prefer that you didn't submit this
Looks good but did you update the selinux policy? You will have to open a bug on selinux.
If it was done or in the process please post a link in the comments and I'll change my
score.
--
To view, visit http://gerrit.ovirt.org/449
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4fee83a4d31190e11c6d776d61ef2d111f97518d
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
9:28 a.m.
Douglas Schilling Landgraf has posted comments on this change.
Change subject: replace /rhev repository to /ovirt
......................................................................
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/449
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4fee83a4d31190e11c6d776d61ef2d111f97518d
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
4523
days inactive
4545
days old
vdsm-patches@lists.fedorahosted.org
17 comments
6 participants
participants (6)
-
apevec＠redhat.com -
Dan Kenigsberg -
Douglas Schilling Landgraf -
Federico Simoncelli -
Igor Lvovsky -
smizrahi＠redhat.com