Dan Kenigsberg has submitted this change and it was merged.
Change subject: Define some constants in API.py
......................................................................
Define some constants in API.py
The API bindings should be implemented in terms of the API bridge (API.py) and
not rely on vdsm internals. Currently the xmlrpc binding imports some internal
modules in order to provide some default values (ie. BLANK_UUID and volume
constants). Constants that are needed at the API level need to appear in
API.py.
This patch converts the obvious offenses. If this approach is acceptible I will
follow up with additional patches. In the future, APIs that take 'magic'
parameters must formally define the valid values in API.py.
Signed-off-by: Adam Litke <agl(a)us.ibm.com>
Change-Id: Iaef19f956ec1d6f83fd48e71a2f0a018505266be
---
M vdsm/API.py
M vdsm/BindingXMLRPC.py
2 files changed, 43 insertions(+), 15 deletions(-)
Approvals:
Mark Wu: Looks good to me, but someone else must approve
Dan Kenigsberg: Looks good to me, approved
Peter V. Saveliev: Verified; Looks good to me, but someone else must approve
--
To view, visit
http://gerrit.ovirt.org/2262
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iaef19f956ec1d6f83fd48e71a2f0a018505266be
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke <agl(a)us.ibm.com>
Gerrit-Reviewer: Adam Litke <agl(a)us.ibm.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Peter V. Saveliev <peet(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>