Change in vdsm[master]: pep8: whitelist everything

[Dan Kenigsberg]

Dan Kenigsberg has uploaded a new change for review.

Change subject: pep8: whitelist everything
......................................................................

pep8: whitelist everything

.. except for four auto-generated *.py files

Change-Id: I237e19d5cdd087d8fe0f337f41560b72b1c80a37
Signed-off-by: Dan Kenigsberg <danken(a)redhat.com&gt;
---
M Makefile.am
M lib/vdsm/tool/dummybr.py
2 files changed, 3 insertions(+), 23 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/92/25392/1

diff --git a/Makefile.am b/Makefile.am
index 9b1a3c9..3f4266c 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -53,27 +53,7 @@
 WITH_HOOKS = --define="with_hooks 1"
 endif
 
-# When fixing a file to conform with pep8 add it to the WL here so it will be
-# checkd from now on
-PEP8_WHITELIST = \
-	client \
-	lib/vdsm/*.py \
-	lib/vdsm/*.py.in \
-	tests \
-	vds_bootstrap \
-	vdsm-tool \
-	vdsm/*.py \
-	vdsm/*.py.in \
-	vdsm/netconf \
-	vdsm/sos/vdsm.py.in \
-	vdsm/storage \
-	vdsm/vdsm \
-	vdsm_api \
-	vdsm_hooks \
-	vdsm_reg \
-	$(NULL)
-
-PEP8_BLACKLIST = config.py,constants.py
+PEP8_BLACKLIST = config.py,constants.py,crossImportsTests.py,vdsm.py
 
 SKIP_PYFLAKES_ERR = "\./vdsm/storage/lvm\.py.*: list comprehension redefines \
 	'lv' from line .*"
@@ -84,8 +64,7 @@
 		grep -w -v $(SKIP_PYFLAKES_ERR) | \
 		while read LINE; do echo "$$LINE"; false; done
 	$(PEP8) --version
-	$(PEP8) --exclude="$(PEP8_BLACKLIST)" --filename '*.py,*.py.in' \
-		$(PEP8_WHITELIST)
+	$(PEP8) --exclude="$(PEP8_BLACKLIST)" --filename '*.py,*.py.in' .
 	@if test -f .gitignore; then \
 	  for i in `git ls-files \*.in`; do \
 	    if ! grep -q -x $${i%%.in} .gitignore; then \
diff --git a/lib/vdsm/tool/dummybr.py b/lib/vdsm/tool/dummybr.py
index be4a1da..d5825f2 100644
--- a/lib/vdsm/tool/dummybr.py
+++ b/lib/vdsm/tool/dummybr.py
@@ -40,6 +40,7 @@
             '''<network><name>%s</name><forward
mode='bridge'/><bridge '''
             '''name='%s'/></network>''' %
(bridgeName, bridgeName))
 
+
 @expose('dummybr')
 def main():
     """


-- 
To view, visit http://gerrit.ovirt.org/25392
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I237e19d5cdd087d8fe0f337f41560b72b1c80a37
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com&gt;

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: pep8: whitelist everything
......................................................................


Patch Set 1: Verified+1

-- 
To view, visit http://gerrit.ovirt.org/25392
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I237e19d5cdd087d8fe0f337f41560b72b1c80a37
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com&gt;
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-HasComments: No

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: pep8: whitelist everything
......................................................................


Patch Set 1: Code-Review+2

-- 
To view, visit http://gerrit.ovirt.org/25392
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I237e19d5cdd087d8fe0f337f41560b72b1c80a37
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com&gt;
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No

[Dan Kenigsberg]

Dan Kenigsberg has submitted this change and it was merged.

Change subject: pep8: whitelist everything
......................................................................


pep8: whitelist everything

.. except for four auto-generated *.py files

Change-Id: I237e19d5cdd087d8fe0f337f41560b72b1c80a37
Signed-off-by: Dan Kenigsberg <danken(a)redhat.com&gt;
Reviewed-on: http://gerrit.ovirt.org/25392
Reviewed-by: Yaniv Bronhaim <ybronhei(a)redhat.com&gt;
---
M Makefile.am
M lib/vdsm/tool/dummybr.py
2 files changed, 3 insertions(+), 23 deletions(-)

Approvals:
  Yaniv Bronhaim: Looks good to me, but someone else must approve
  Dan Kenigsberg: Verified; Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/25392
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I237e19d5cdd087d8fe0f337f41560b72b1c80a37
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com&gt;
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server

Yaniv Bronhaim has posted comments on this change.

Change subject: pep8: whitelist everything
......................................................................


Patch Set 1: Code-Review+1

-- 
To view, visit http://gerrit.ovirt.org/25392
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I237e19d5cdd087d8fe0f337f41560b72b1c80a37
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com&gt;
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: pep8: whitelist everything
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.ovirt.org/#/c/25392/1/Makefile.am
File Makefile.am:

Line 52: if HOOKS
Line 53: WITH_HOOKS = --define="with_hooks 1"
Line 54: endif
Line 55: 
Line 56: PEP8_BLACKLIST = config.py,constants.py,crossImportsTests.py,vdsm.py
>  is it all the template output files? because we have more 
All
the other auto-generated py-files do not break pep8 - and I'd like to keep that!

I could have PEP8_BLACKLIST become space-delimited, and use `sed` to replace them with
comas. I think it would not be more readable, but I'll try it in a follow-up patch.
Line 57: 
Line 58: SKIP_PYFLAKES_ERR = "\./vdsm/storage/lvm\.py.*: list comprehension redefines
\
Line 59: 	'lv' from line .*"
Line 60: 


-- 
To view, visit http://gerrit.ovirt.org/25392
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I237e19d5cdd087d8fe0f337f41560b72b1c80a37
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com&gt;
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: pep8: whitelist everything
......................................................................


Patch Set 1:

Build Successful 

http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7417/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6624/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/7526/ : SUCCESS

-- 
To view, visit http://gerrit.ovirt.org/25392
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I237e19d5cdd087d8fe0f337f41560b72b1c80a37
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com&gt;
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No

Yaniv Bronhaim has posted comments on this change.

Change subject: pep8: whitelist everything
......................................................................


Patch Set 1:

(1 comment)

verified means no pep8 complain after that change?

http://gerrit.ovirt.org/#/c/25392/1/Makefile.am
File Makefile.am:

Line 52: if HOOKS
Line 53: WITH_HOOKS = --define="with_hooks 1"
Line 54: endif
Line 55: 
Line 56: PEP8_BLACKLIST = config.py,constants.py,crossImportsTests.py,vdsm.py
is it all the template output files? because we have more
./vdsm_reg/deployUtil.py.in
./vdsm_reg/engine.py.in
./vdsm/dsaversion.py.in
./vdsm/gluster/hostname.py.in
./vdsm/mk_sysprep_floppy.in
./vdsm/dumpStorageTable.py.in
./vds_bootstrap/deployUtil.py.in
./lib/vdsm/tool/validate_ovirt_certs.py.in
./lib/vdsm/tool/load_needed_modules.py.in
./lib/vdsm/vdscli.py.in

what about those?
do we want to check all vdsm subfolders?

can you arrange this list as all lists in the file, one file in a line?
Line 57: 
Line 58: SKIP_PYFLAKES_ERR = "\./vdsm/storage/lvm\.py.*: list comprehension redefines
\
Line 59: 	'lv' from line .*"
Line 60: 


-- 
To view, visit http://gerrit.ovirt.org/25392
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I237e19d5cdd087d8fe0f337f41560b72b1c80a37
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com&gt;
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-HasComments: Yes