Change in vdsm[master]: Do not lock the image when preparing the VM path

[Federico Simoncelli]

Federico Simoncelli has uploaded a new change for review.

Change subject: Do not lock the image when preparing the VM path
......................................................................

Do not lock the image when preparing the VM path

Since the resource manager scope is local there is no need for a VM
to take an exclusive lock on the images: in fact the SPM running on
an other machine could still manipulate such images.

Change-Id: I4b5cb55a868cb9bf5a720610273af139ee858a1a
---
M vdsm/clientIF.py
M vdsm/storage/hsm.py
2 files changed, 14 insertions(+), 114 deletions(-)

git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/54/554/1
--
To view, visit http://gerrit.ovirt.org/554
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I4b5cb55a868cb9bf5a720610273af139ee858a1a
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli

[Igor Lvovsky]

Igor Lvovsky has posted comments on this change.

Change subject: Do not lock the image when preparing the VM path
......................................................................

Patch Set 1:

WOW Federico !!!   Let's talk about it, first :)

--
To view, visit http://gerrit.ovirt.org/554
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4b5cb55a868cb9bf5a720610273af139ee858a1a
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli 
Gerrit-Reviewer: Eduardo 
Gerrit-Reviewer: Igor Lvovsky

[Federico Simoncelli]

Federico Simoncelli has posted comments on this change.

Change subject: Do not lock the image when preparing the VM path
......................................................................

Patch Set 1:
> WOW Federico !!! Let's talk about it, first :)

I discussed the idea in principles with Eduardo. It goes without saying that Monday morning we'll go over it together and I prefer having some real code to discuss (and test) rather than keep it just theoretical.

--
To view, visit http://gerrit.ovirt.org/554
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4b5cb55a868cb9bf5a720610273af139ee858a1a
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli 
Gerrit-Reviewer: Eduardo 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Igor Lvovsky

[Igor Lvovsky]

Igor Lvovsky has posted comments on this change.

Change subject: Do not lock the image when preparing the VM path
......................................................................

Patch Set 1: I would prefer that you didn't submit this

Split it to 2 patches as we discussed

--
To view, visit http://gerrit.ovirt.org/554
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4b5cb55a868cb9bf5a720610273af139ee858a1a
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli 
Gerrit-Reviewer: Eduardo 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Igor Lvovsky

[Igor Lvovsky]

Igor Lvovsky has posted comments on this change.

Change subject: Do not lock the image when preparing the VM path
......................................................................

Patch Set 2: I would prefer that you didn't submit this

(1 inline comment)

....................................................
File vdsm/storage/hsm.py
Line 74: rmanager = rm.ResourceManager.getInstance()
Looks like this one not needed  anymore.

--
To view, visit http://gerrit.ovirt.org/554
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4b5cb55a868cb9bf5a720610273af139ee858a1a
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli 
Gerrit-Reviewer: Eduardo 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Igor Lvovsky

[Federico Simoncelli]

Federico Simoncelli has posted comments on this change.

Change subject: Do not lock the image when preparing the VM path
......................................................................

Patch Set 2: (1 inline comment)

....................................................
File vdsm/storage/hsm.py
Line 74: rmanager = rm.ResourceManager.getInstance()
It's used in _connectStoragePool.

--
To view, visit http://gerrit.ovirt.org/554
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4b5cb55a868cb9bf5a720610273af139ee858a1a
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli 
Gerrit-Reviewer: Eduardo 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Igor Lvovsky

[Igor Lvovsky]

Igor Lvovsky has posted comments on this change.

Change subject: Do not lock the image when preparing the VM path
......................................................................

Patch Set 2: Looks good to me, but someone else must approve

(1 inline comment)

....................................................
File vdsm/storage/hsm.py
Line 74: rmanager = rm.ResourceManager.getInstance()
Oops, sorry

--
To view, visit http://gerrit.ovirt.org/554
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4b5cb55a868cb9bf5a720610273af139ee858a1a
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli 
Gerrit-Reviewer: Eduardo 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Igor Lvovsky

Saggi Mizrahi has posted comments on this change.

Change subject: Do not lock the image when preparing the VM path
......................................................................

Patch Set 5: I would prefer that you didn't submit this

This seems a bit hackish, I would like to see this flow streamlined

--
To view, visit http://gerrit.ovirt.org/554
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4b5cb55a868cb9bf5a720610273af139ee858a1a
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli 
Gerrit-Reviewer: Eduardo 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Igor Lvovsky 
Gerrit-Reviewer: Saggi Mizrahi

[Igor Lvovsky]

Igor Lvovsky has posted comments on this change.

Change subject: Do not lock the image when preparing the VM path
......................................................................

Patch Set 8: Looks good to me, but someone else must approve

I gave you +1, but we should to remember that it's only intermediate solution, as we discussed in code review.
It should go to prepareImage/teardownImage flows.

--
To view, visit http://gerrit.ovirt.org/554
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4b5cb55a868cb9bf5a720610273af139ee858a1a
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli 
Gerrit-Reviewer: Eduardo 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Igor Lvovsky 
Gerrit-Reviewer: Saggi Mizrahi

[Igor Lvovsky]

Igor Lvovsky has posted comments on this change.

Change subject: Do not lock the image when preparing the VM path
......................................................................

Patch Set 11: Looks good to me, but someone else must approve

--
To view, visit http://gerrit.ovirt.org/554
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4b5cb55a868cb9bf5a720610273af139ee858a1a
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli 
Gerrit-Reviewer: Eduardo 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Igor Lvovsky 
Gerrit-Reviewer: Saggi Mizrahi

[Igor Lvovsky]

Igor Lvovsky has posted comments on this change.

Change subject: Do not lock the image when preparing the VM path
......................................................................

Patch Set 12: Looks good to me, but someone else must approve

--
To view, visit http://gerrit.ovirt.org/554
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4b5cb55a868cb9bf5a720610273af139ee858a1a
Gerrit-PatchSet: 12
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli 
Gerrit-Reviewer: Eduardo 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Igor Lvovsky 
Gerrit-Reviewer: Saggi Mizrahi

[Federico Simoncelli]

Federico Simoncelli has posted comments on this change.

Change subject: Do not lock the image when preparing the VM path
......................................................................

Patch Set 12: Verified

--
To view, visit http://gerrit.ovirt.org/554
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4b5cb55a868cb9bf5a720610273af139ee858a1a
Gerrit-PatchSet: 12
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli 
Gerrit-Reviewer: Eduardo 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Igor Lvovsky 
Gerrit-Reviewer: Saggi Mizrahi

[Igor Lvovsky]

Igor Lvovsky has posted comments on this change.

Change subject: Do not lock the image when preparing the VM path
......................................................................

Patch Set 13: Looks good to me, but someone else must approve

--
To view, visit http://gerrit.ovirt.org/554
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4b5cb55a868cb9bf5a720610273af139ee858a1a
Gerrit-PatchSet: 13
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli 
Gerrit-Reviewer: Eduardo 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Igor Lvovsky 
Gerrit-Reviewer: Saggi Mizrahi

[Igor Lvovsky]

Igor Lvovsky has posted comments on this change.

Change subject: Do not lock the image when preparing the VM path
......................................................................

Patch Set 14: Looks good to me, but someone else must approve

--
To view, visit http://gerrit.ovirt.org/554
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4b5cb55a868cb9bf5a720610273af139ee858a1a
Gerrit-PatchSet: 14
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli 
Gerrit-Reviewer: Eduardo 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Igor Lvovsky 
Gerrit-Reviewer: Saggi Mizrahi

[Igor Lvovsky]

Igor Lvovsky has posted comments on this change.

Change subject: Do not lock the image when preparing the VM path
......................................................................

Patch Set 15: Looks good to me, but someone else must approve

--
To view, visit http://gerrit.ovirt.org/554
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4b5cb55a868cb9bf5a720610273af139ee858a1a
Gerrit-PatchSet: 15
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli 
Gerrit-Reviewer: Eduardo 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Igor Lvovsky 
Gerrit-Reviewer: Saggi Mizrahi

[Igor Lvovsky]

Igor Lvovsky has posted comments on this change.

Change subject: Do not lock the image when preparing the VM path
......................................................................

Patch Set 16: Looks good to me, but someone else must approve

--
To view, visit http://gerrit.ovirt.org/554
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4b5cb55a868cb9bf5a720610273af139ee858a1a
Gerrit-PatchSet: 16
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli 
Gerrit-Reviewer: Eduardo 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Igor Lvovsky 
Gerrit-Reviewer: Saggi Mizrahi

Saggi Mizrahi has posted comments on this change.

Change subject: Do not lock the image when preparing the VM path
......................................................................

Patch Set 16: Looks good to me, but someone else must approve

--
To view, visit http://gerrit.ovirt.org/554
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4b5cb55a868cb9bf5a720610273af139ee858a1a
Gerrit-PatchSet: 16
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli 
Gerrit-Reviewer: Eduardo 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Igor Lvovsky 
Gerrit-Reviewer: Saggi Mizrahi

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: Do not lock the image when preparing the VM path
......................................................................

Patch Set 16: Looks good to me, but someone else must approve

(1 inline comment)

....................................................
File vdsm/storage/hsm.py
Line 2390:         This method is obsolete and is kept only for testing purposes;
.. warning::
   Obsolete ....

could be nicer

--
To view, visit http://gerrit.ovirt.org/554
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4b5cb55a868cb9bf5a720610273af139ee858a1a
Gerrit-PatchSet: 16
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Eduardo 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Igor Lvovsky 
Gerrit-Reviewer: Saggi Mizrahi

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: Do not lock the image when preparing the VM path
......................................................................

Patch Set 17: Verified; Looks good to me, approved

--
To view, visit http://gerrit.ovirt.org/554
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4b5cb55a868cb9bf5a720610273af139ee858a1a
Gerrit-PatchSet: 17
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Eduardo 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Igor Lvovsky 
Gerrit-Reviewer: Saggi Mizrahi

[Dan Kenigsberg]

Dan Kenigsberg has submitted this change and it was merged.

Change subject: Do not lock the image when preparing the VM path
......................................................................

Do not lock the image when preparing the VM path

Since the resource manager scope is local there is no need for a VM
to take an exclusive lock on the images: in fact the SPM running on
an other machine could still manipulate such images.
Using the resource manager in general on HSM is wrong because it is
mapped on actions that are valid only on the SPM such as: modifing
the lvm permissions and the modification time in the metadata.

In this patch:
* add an activate/deactivate image method to StorageDomain
* implement the activate/deactivate image for BlockStorageDomain
* add the prepareImage/teardownImage methods in HSM

Change-Id: I4b5cb55a868cb9bf5a720610273af139ee858a1a
---
M vdsm/clientIF.py
M vdsm/storage/blockSD.py
M vdsm/storage/hsm.py
M vdsm/storage/image.py
M vdsm/storage/sd.py
5 files changed, 109 insertions(+), 11 deletions(-)

Approvals:
  Dan Kenigsberg: Verified; Looks good to me, approved

--
To view, visit http://gerrit.ovirt.org/554
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I4b5cb55a868cb9bf5a720610273af139ee858a1a
Gerrit-PatchSet: 17
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Eduardo 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Igor Lvovsky 
Gerrit-Reviewer: Saggi Mizrahi