From Yaniv Bronhaim <ybronhei(a)redhat.com>:
Yaniv Bronhaim has posted comments on this change.
Change subject: RPC: Small refactor of ClientRpcTransportAdapter
......................................................................
Patch Set 24:
(1 comment)
https://gerrit.ovirt.org/#/c/78655/24/lib/yajsonrpc/stompreactor.py
File lib/yajsonrpc/stompreactor.py:
Line 595: :param handler: Callback to handle incoming messages
Line 596: :type handler: function (ClientRpcTransportAdapter, string) -> ()
Line 597: """
Line 598: self._message_handler = handler
Line 599:
if you change this area again in
https://gerrit.ovirt.org/#/c/78656/30/lib/yajsonrpc/stompreactor.py - just don't touch
here at all - try to make this patch small as possible
Line 600: def send(self, data, destination=None):
Line 601: if not destination:
Line 602: destination = self._request_queue
Line 603:
--
To view, visit
https://gerrit.ovirt.org/78655
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I19cad2983a94303cdcb07a4a5aacb074851d6b6c
Gerrit-PatchSet: 24
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Andrej Krejcir <akrejcir(a)redhat.com>
Gerrit-Reviewer: Andrej Krejcir <akrejcir(a)redhat.com>
Gerrit-Reviewer: Denis Chaplygin <dchaplyg(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenny Tokar <jtokar(a)redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Phillip Bailey <phbailey(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com>
Gerrit-Reviewer: Yanir Quinn <yquinn(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes