Yaniv Bronhaim has uploaded a new change for review.
Change subject: Adding requires to python-argparse ......................................................................
Adding requires to python-argparse
Change-Id: Icf5ae4df4935969a1de87cfc66544da7a3ef3ca5 Signed-off-by: Yaniv Bronhaim ybronhei@redhat.com --- M vdsm.spec.in 1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/09/18809/1
diff --git a/vdsm.spec.in b/vdsm.spec.in index 1b9a5fe..c3c4b9c 100644 --- a/vdsm.spec.in +++ b/vdsm.spec.in @@ -96,6 +96,7 @@ Requires: iproute Requires: python-netaddr Requires: python-inotify +Requires: python-argparse Requires: python-ethtool >= 0.6-3 Requires: rpm-python Requires: nfs-utils
Alon Bar-Lev has posted comments on this change.
Change subject: Adding requires to python-argparse ......................................................................
Patch Set 1: Code-Review+1
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Adding requires to python-argparse ......................................................................
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4255/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3360/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4176/ : SUCCESS
Yaniv Bronhaim has posted comments on this change.
Change subject: Adding requires to python-argparse ......................................................................
Patch Set 1: Verified+1
Dan Kenigsberg has posted comments on this change.
Change subject: Adding requires to python-argparse ......................................................................
Patch Set 1: Code-Review+2
We should have thought more before taking the argparse dependency, as it is missing from base EL6. But now that we have it, we should at least declare that we do.
Dan Kenigsberg has submitted this change and it was merged.
Change subject: Adding requires to python-argparse ......................................................................
Adding requires to python-argparse
Change-Id: Icf5ae4df4935969a1de87cfc66544da7a3ef3ca5 Signed-off-by: Yaniv Bronhaim ybronhei@redhat.com Reviewed-on: http://gerrit.ovirt.org/18809 Reviewed-by: Alon Bar-Lev alonbl@redhat.com Reviewed-by: Dan Kenigsberg danken@redhat.com --- M vdsm.spec.in 1 file changed, 1 insertion(+), 0 deletions(-)
Approvals: Alon Bar-Lev: Looks good to me, but someone else must approve Yaniv Bronhaim: Verified Dan Kenigsberg: Looks good to me, approved
vdsm-patches@lists.fedorahosted.org