Change in vdsm[master]: Move IOUSER from misc.py to constants.py

[Xu He Jie]

Xu He Jie has uploaded a new change for review.

Change subject: Move IOUSER from misc.py to constants.py
......................................................................

Move IOUSER from misc.py to constants.py

Move IOUSER from misc.py to constants.py and add it to configure.ac.
make it configurable.

Change-Id: Id5d20317ac5a38d8ddd74b26272cd870aa4702b9
---
M configure.ac
M vdsm/constants.py.in
M vdsm/storage/misc.py
M vdsm/storage/safelease.py
4 files changed, 3 insertions(+), 2 deletions(-)

git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/62/3362/1
--
To view, visit http://gerrit.ovirt.org/3362
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Id5d20317ac5a38d8ddd74b26272cd870aa4702b9
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Xu He Jie

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: Move IOUSER from misc.py to constants.py
......................................................................

Patch Set 1: Looks good to me, but someone else must approve

but I would like to hear Saggi's opinion - he wants to make modules less-dependent of constants.

--
To view, visit http://gerrit.ovirt.org/3362
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id5d20317ac5a38d8ddd74b26272cd870aa4702b9
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Xu He Jie 
Gerrit-Reviewer: Dan Kenigsberg

Saggi Mizrahi has posted comments on this change.

Change subject: Move IOUSER from misc.py to constants.py
......................................................................

Patch Set 2: I would prefer that you didn't submit this

Please make it that instead of directly getting the io user from constants it is passed at the class ctor. Ideally only hsm should access the constants but I am willing to compromise for just moving it upwards to the domain level for now.

--
To view, visit http://gerrit.ovirt.org/3362
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id5d20317ac5a38d8ddd74b26272cd870aa4702b9
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Xu He Jie 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Saggi Mizrahi 
Gerrit-Reviewer: Xu He Jie

[Xu He Jie]

Xu He Jie has posted comments on this change.

Change subject: Move IOUSER from misc.py to constants.py
......................................................................

Patch Set 2:

Hi, Saggi, thanks for your review! If it move to domain level(move to sd.py?), so it will add new *.in file. I feel a lot of *.in is not very good. Is right? If you have another better plan for constants. I would prefer that I didn't submit this. I can abandon this.

--
To view, visit http://gerrit.ovirt.org/3362
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id5d20317ac5a38d8ddd74b26272cd870aa4702b9
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Xu He Jie 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Saggi Mizrahi 
Gerrit-Reviewer: Xu He Jie

[Xu He Jie]

Xu He Jie has abandoned this change.

Change subject: Move IOUSER from misc.py to constants.py
......................................................................

Patch Set 2: Abandoned

--
To view, visit http://gerrit.ovirt.org/3362
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: Id5d20317ac5a38d8ddd74b26272cd870aa4702b9
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Xu He Jie 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Saggi Mizrahi 
Gerrit-Reviewer: Xu He Jie 
Gerrit-Reviewer: oVirt Jenkins CI Server