3:34 a.m.
mooli tayer has uploaded a new change for review.
Change subject: vdsm-tool: use geteuid() instead of getuid() for root check.
......................................................................
vdsm-tool: use geteuid() instead of getuid() for root check.
Change-Id: I0a54af5737cf47e3f5e8ab62339bddd978ceddb9
Signed-off-by: Mooli Tayer <mtayer(a)redhat.com>
---
M lib/vdsm/tool/configurator.py
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/17/31317/1
diff --git a/lib/vdsm/tool/configurator.py b/lib/vdsm/tool/configurator.py
index 90e8616..2dbd48e 100644
--- a/lib/vdsm/tool/configurator.py
+++ b/lib/vdsm/tool/configurator.py
@@ -676,7 +676,7 @@
def requiresRoot(func):
@functools.wraps(func)
def wrapper(*args, **kwargs):
- if os.getuid() != 0:
+ if os.geteuid() != 0:
raise NotRootError()
func(*args, **kwargs)
return wrapper
--
To view, visit http://gerrit.ovirt.org/31317
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I0a54af5737cf47e3f5e8ab62339bddd978ceddb9
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: mooli tayer <mtayer(a)redhat.com>
3:49 a.m.
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsm-tool: use geteuid() instead of getuid() for root check.
......................................................................
Patch Set 5:
Build Successful
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/11225/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/12167/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/12014/ : SUCCESS
--
To view, visit http://gerrit.ovirt.org/31317
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0a54af5737cf47e3f5e8ab62339bddd978ceddb9
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: mooli tayer <mtayer(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Dima Kuznetsov <dkuznets(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: mooli tayer <mtayer(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
9:55 a.m.
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsm-tool: use geteuid() instead of getuid() for root check.
......................................................................
Patch Set 6:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_verify-error-codes_merged/5769/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_master_create-rpms_merged_test_debug/134/ : FAILURE
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/3928/ : FAILURE
http://jenkins.ovirt.org/job/vdsm_master_create-rpms_merged/1793/ : FAILURE
--
To view, visit http://gerrit.ovirt.org/31317
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0a54af5737cf47e3f5e8ab62339bddd978ceddb9
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: mooli tayer <mtayer(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Dima Kuznetsov <dkuznets(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: mooli tayer <mtayer(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
9:48 a.m.
Dan Kenigsberg has submitted this change and it was merged.
Change subject: vdsm-tool: use geteuid() instead of getuid() for root check.
......................................................................
vdsm-tool: use geteuid() instead of getuid() for root check.
This is expected to have no consequence. checking for effective user id
is more accurate for permissions check.
Change-Id: I0a54af5737cf47e3f5e8ab62339bddd978ceddb9
Signed-off-by: Mooli Tayer <mtayer(a)redhat.com>
Reviewed-on: http://gerrit.ovirt.org/31317
Reviewed-by: Dima Kuznetsov <dkuznets(a)redhat.com>
Reviewed-by: Nir Soffer <nsoffer(a)redhat.com>
Reviewed-by: Yaniv Bronhaim <ybronhei(a)redhat.com>
Reviewed-by: Dan Kenigsberg <danken(a)redhat.com>
---
M lib/vdsm/tool/__init__.py
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Nir Soffer: Looks good to me, but someone else must approve
Yaniv Bronhaim: Looks good to me, but someone else must approve
mooli tayer: Verified
Dima Kuznetsov: Looks good to me, but someone else must approve
Dan Kenigsberg: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/31317
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I0a54af5737cf47e3f5e8ab62339bddd978ceddb9
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: mooli tayer <mtayer(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Dima Kuznetsov <dkuznets(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: mooli tayer <mtayer(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
9:48 a.m.
Dan Kenigsberg has posted comments on this change.
Change subject: vdsm-tool: use geteuid() instead of getuid() for root check.
......................................................................
Patch Set 5: Code-Review+2
Raising score.
--
To view, visit http://gerrit.ovirt.org/31317
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0a54af5737cf47e3f5e8ab62339bddd978ceddb9
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: mooli tayer <mtayer(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Dima Kuznetsov <dkuznets(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: mooli tayer <mtayer(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
8:36 a.m.
Yaniv Bronhaim has posted comments on this change.
Change subject: vdsm-tool: use geteuid() instead of getuid() for root check.
......................................................................
Patch Set 5: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/31317
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0a54af5737cf47e3f5e8ab62339bddd978ceddb9
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: mooli tayer <mtayer(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Dima Kuznetsov <dkuznets(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: mooli tayer <mtayer(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
4:42 a.m.
mooli tayer has posted comments on this change.
Change subject: vdsm-tool: use geteuid() instead of getuid() for root check.
......................................................................
Patch Set 5: Verified+1
verified on el6.5
--
To view, visit http://gerrit.ovirt.org/31317
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0a54af5737cf47e3f5e8ab62339bddd978ceddb9
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: mooli tayer <mtayer(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Dima Kuznetsov <dkuznets(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: mooli tayer <mtayer(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
1:50 p.m.
Nir Soffer has posted comments on this change.
Change subject: vdsm-tool: use geteuid() instead of getuid() for root check.
......................................................................
Patch Set 4: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/31317
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0a54af5737cf47e3f5e8ab62339bddd978ceddb9
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: mooli tayer <mtayer(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Dima Kuznetsov <dkuznets(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: mooli tayer <mtayer(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
9:27 a.m.
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsm-tool: use geteuid() instead of getuid() for root check.
......................................................................
Patch Set 4:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/11100/ : FAILURE
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/12042/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/11889/ : SUCCESS
--
To view, visit http://gerrit.ovirt.org/31317
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0a54af5737cf47e3f5e8ab62339bddd978ceddb9
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: mooli tayer <mtayer(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Dima Kuznetsov <dkuznets(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: mooli tayer <mtayer(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
7:28 a.m.
Dima Kuznetsov has posted comments on this change.
Change subject: vdsm-tool: use geteuid() instead of getuid() for root check.
......................................................................
Patch Set 4: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/31317
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0a54af5737cf47e3f5e8ab62339bddd978ceddb9
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: mooli tayer <mtayer(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Dima Kuznetsov <dkuznets(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: mooli tayer <mtayer(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
10:16 a.m.
Yaniv Bronhaim has posted comments on this change.
Change subject: vdsm-tool: use geteuid() instead of getuid() for root check.
......................................................................
Patch Set 3: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/31317
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0a54af5737cf47e3f5e8ab62339bddd978ceddb9
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: mooli tayer <mtayer(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Dima Kuznetsov <dkuznets(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: mooli tayer <mtayer(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
8:30 a.m.
mooli tayer has posted comments on this change.
Change subject: vdsm-tool: use geteuid() instead of getuid() for root check.
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.ovirt.org/#/c/31317/1//COMMIT_MSG
Commit Message:
Line 3: AuthorDate: 2014-08-11 11:30:33 +0300
Line 4: Commit: Mooli Tayer <mtayer(a)redhat.com>
Line 5: CommitDate: 2014-08-11 11:30:33 +0300
Line 6:
Line 7: vdsm-tool: use geteuid() instead of getuid() for root check.
Can you explain why is this more correct, and in which case the
former way
No sudo works fine(do 'sudo id').
I expect this to have no consequence.
It is done because getuid() is more correct when checking permissions.
AFAIK It has consequence when a process has uid bit set on it and other corner cases.
Again, I expect this to have no effect but it is more appropriate for permission
checking.
Line 8:
Line 9: Change-Id: I0a54af5737cf47e3f5e8ab62339bddd978ceddb9
--
To view, visit http://gerrit.ovirt.org/31317
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0a54af5737cf47e3f5e8ab62339bddd978ceddb9
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: mooli tayer <mtayer(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Dima Kuznetsov <dkuznets(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: mooli tayer <mtayer(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
7:18 a.m.
Nir Soffer has posted comments on this change.
Change subject: vdsm-tool: use geteuid() instead of getuid() for root check.
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.ovirt.org/#/c/31317/1//COMMIT_MSG
Commit Message:
Line 3: AuthorDate: 2014-08-11 11:30:33 +0300
Line 4: Commit: Mooli Tayer <mtayer(a)redhat.com>
Line 5: CommitDate: 2014-08-11 11:30:33 +0300
Line 6:
Line 7: vdsm-tool: use geteuid() instead of getuid() for root check.
Can you explain why is this more correct, and in which case the former way was broken
(sudo I guess)?
Line 8:
Line 9: Change-Id: I0a54af5737cf47e3f5e8ab62339bddd978ceddb9
--
To view, visit http://gerrit.ovirt.org/31317
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0a54af5737cf47e3f5e8ab62339bddd978ceddb9
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: mooli tayer <mtayer(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Dima Kuznetsov <dkuznets(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: mooli tayer <mtayer(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
7:09 a.m.
mooli tayer has posted comments on this change.
Change subject: vdsm-tool: use geteuid() instead of getuid() for root check.
......................................................................
Patch Set 1: Verified+1
--
To view, visit http://gerrit.ovirt.org/31317
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0a54af5737cf47e3f5e8ab62339bddd978ceddb9
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: mooli tayer <mtayer(a)redhat.com>
Gerrit-Reviewer: Dima Kuznetsov <dkuznets(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: mooli tayer <mtayer(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
3:54 a.m.
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsm-tool: use geteuid() instead of getuid() for root check.
......................................................................
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/10796/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/11738/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/11581/ : SUCCESS
--
To view, visit http://gerrit.ovirt.org/31317
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0a54af5737cf47e3f5e8ab62339bddd978ceddb9
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: mooli tayer <mtayer(a)redhat.com>
Gerrit-Reviewer: Dima Kuznetsov <dkuznets(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
3:48 a.m.
Dima Kuznetsov has posted comments on this change.
Change subject: vdsm-tool: use geteuid() instead of getuid() for root check.
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/31317
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0a54af5737cf47e3f5e8ab62339bddd978ceddb9
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: mooli tayer <mtayer(a)redhat.com>
Gerrit-Reviewer: Dima Kuznetsov <dkuznets(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-HasComments: No
6:30 a.m.
mooli tayer has posted comments on this change.
Change subject: vdsm-tool: use geteuid() instead of getuid() for root check.
......................................................................
Patch Set 3:
I adopted this from comment 5 on
http://gerrit.ovirt.org/#/c/31293/2.
I explained when this can happen in comment 7 of this patch.
The kernal uses effective user ids to check permissions for processes
and so should we. that is why "checking for effective user id
is more accurate for permissions check."
--
To view, visit http://gerrit.ovirt.org/31317
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0a54af5737cf47e3f5e8ab62339bddd978ceddb9
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: mooli tayer <mtayer(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Dima Kuznetsov <dkuznets(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: mooli tayer <mtayer(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
2:12 a.m.
Yaniv Bronhaim has posted comments on this change.
Change subject: vdsm-tool: use geteuid() instead of getuid() for root check.
......................................................................
Patch Set 3: -Code-Review
any reference to when getuid can get you wrong? .. removing my score. for +1 I prefer to
see why the last form was wrong, and what's more accurate means
--
To view, visit http://gerrit.ovirt.org/31317
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0a54af5737cf47e3f5e8ab62339bddd978ceddb9
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: mooli tayer <mtayer(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Dima Kuznetsov <dkuznets(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: mooli tayer <mtayer(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
2:47 a.m.
Nir Soffer has posted comments on this change.
Change subject: vdsm-tool: use geteuid() instead of getuid() for root check.
......................................................................
Patch Set 3: Code-Review+1
I would like to see more verbose commit message explaining when the old check could fail,
but lets go on.
--
To view, visit http://gerrit.ovirt.org/31317
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0a54af5737cf47e3f5e8ab62339bddd978ceddb9
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: mooli tayer <mtayer(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Dima Kuznetsov <dkuznets(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: mooli tayer <mtayer(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
1:03 a.m.
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsm-tool: use geteuid() instead of getuid() for root check.
......................................................................
Patch Set 3:
Build Successful
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/10882/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/11824/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/11667/ : SUCCESS
--
To view, visit http://gerrit.ovirt.org/31317
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0a54af5737cf47e3f5e8ab62339bddd978ceddb9
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: mooli tayer <mtayer(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Dima Kuznetsov <dkuznets(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: mooli tayer <mtayer(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
12:55 a.m.
mooli tayer has posted comments on this change.
Change subject: vdsm-tool: use geteuid() instead of getuid() for root check.
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.ovirt.org/#/c/31317/2//COMMIT_MSG
Commit Message:
Line 5: CommitDate: 2014-08-12 06:42:48 -0400
Line 6:
Line 7: vdsm-tool: use geteuid() instead of getuid() for root check.
Line 8:
Line 9: This is expected to have to consequence. checking for effective user id
to -> no ?
yes, thanks
Line 10: is more accurate for permissions check.
Line 11:
Line 12: Change-Id: I0a54af5737cf47e3f5e8ab62339bddd978ceddb9
--
To view, visit http://gerrit.ovirt.org/31317
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0a54af5737cf47e3f5e8ab62339bddd978ceddb9
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: mooli tayer <mtayer(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Dima Kuznetsov <dkuznets(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: mooli tayer <mtayer(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
1:21 p.m.
Nir Soffer has posted comments on this change.
Change subject: vdsm-tool: use geteuid() instead of getuid() for root check.
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.ovirt.org/#/c/31317/2//COMMIT_MSG
Commit Message:
Line 5: CommitDate: 2014-08-12 06:42:48 -0400
Line 6:
Line 7: vdsm-tool: use geteuid() instead of getuid() for root check.
Line 8:
Line 9: This is expected to have to consequence. checking for effective user id
to -> no ?
Line 10: is more accurate for permissions check.
Line 11:
Line 12: Change-Id: I0a54af5737cf47e3f5e8ab62339bddd978ceddb9
--
To view, visit http://gerrit.ovirt.org/31317
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0a54af5737cf47e3f5e8ab62339bddd978ceddb9
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: mooli tayer <mtayer(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Dima Kuznetsov <dkuznets(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: mooli tayer <mtayer(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
5:52 a.m.
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsm-tool: use geteuid() instead of getuid() for root check.
......................................................................
Patch Set 2:
Build Successful
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/10850/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/11792/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/11635/ : SUCCESS
--
To view, visit http://gerrit.ovirt.org/31317
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0a54af5737cf47e3f5e8ab62339bddd978ceddb9
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: mooli tayer <mtayer(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Dima Kuznetsov <dkuznets(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: mooli tayer <mtayer(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
4:05 a.m.
Yaniv Bronhaim has posted comments on this change.
Change subject: vdsm-tool: use geteuid() instead of getuid() for root check.
......................................................................
Patch Set 1: Code-Review-1
please explain all of this in the commit message.
--
To view, visit http://gerrit.ovirt.org/31317
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0a54af5737cf47e3f5e8ab62339bddd978ceddb9
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: mooli tayer <mtayer(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Dima Kuznetsov <dkuznets(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: mooli tayer <mtayer(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
3532
days inactive
3553
days old
vdsm-patches@lists.fedorahosted.org
23 comments
6 participants
participants (6)
-
Dan Kenigsberg -
dkuznets＠redhat.com -
Jenkins CI RO -
mtayer＠redhat.com -
Nir Soffer -
ybronhei＠redhat.com