Change in vdsm[master]: netinfo: Displays active slave for the bond in getVdsCaps

Genadi Chereshnya has uploaded a new change for review.

Change subject: netinfo: Displays active slave for the bond in getVdsCaps
......................................................................

netinfo: Displays active slave for the bond in getVdsCaps

Adding active slave field for the bond in the getVdsCaps
Displays an active slave if exists or displays '' when there is no active slave

Change-Id: Ib6c40755c361523a28cbd68af110e3b20cb9ae25
Signed-off-by: Genadi Chereshnya <gcheresh(a)redhat.com&gt;
---
M lib/vdsm/netinfo.py
1 file changed, 10 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/15/32915/1

diff --git a/lib/vdsm/netinfo.py b/lib/vdsm/netinfo.py
index 6864871..58f6b74 100644
--- a/lib/vdsm/netinfo.py
+++ b/lib/vdsm/netinfo.py
@@ -66,6 +66,7 @@
 NET_PATH = '/sys/class/net'
 BONDING_MASTERS = '/sys/class/net/bonding_masters'
 BONDING_SLAVES = '/sys/class/net/%s/bonding/slaves'
+BONDING_ACTIVE_SLAVE = '/sys/class/net/%s/bonding/active_slave'
 BONDING_OPT = '/sys/class/net/%s/bonding/%s'
 BRIDGING_OPT = '/sys/class/net/%s/bridge/%s'
 _BONDING_FAILOVER_MODES = frozenset(('1', '3'))
@@ -167,6 +168,14 @@
 
 def slaves(bonding):
     return open(BONDING_SLAVES % bonding).readline().split()
+
+
+def active_slave(bonding):
+    """
+    :param bonding:
+    :return: active slave when one exists or '' otherwise
+    """
+    return open(BONDING_ACTIVE_SLAVE % bonding).readline().rstrip()
 
 
 def bondOpts(bond, keys=None):
@@ -575,6 +584,7 @@
 
 def _bondinfo(link):
     return {'hwaddr': link.address, 'slaves': slaves(link.name),
+            'active_slave': active_slave(link.name),
             'opts': _getBondingOptions(link.name)}
 
 


-- 
To view, visit http://gerrit.ovirt.org/32915
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib6c40755c361523a28cbd68af110e3b20cb9ae25
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Genadi Chereshnya <gcheresh(a)redhat.com&gt;

Change in vdsm[master]: netinfo: Displays active slave for the bond in getVdsCaps vd...

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: netinfo: Displays active slave for the bond in getVdsCaps vdsmapi-schema:
Adding Active slave support networkTests: Test to check if active slave exists
......................................................................


Patch Set 9:

Build Failed 

http://jenkins.ovirt.org/job/vdsm_master-libfapi_create-rpms-el6-x86_64_m... :
SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc21-x86_64_merged/237/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_master-libfapi_create-rpms-fc20-x86_64_... :
SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_verify-error-codes_merged/6084/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_create-rpms_merged_test_debug/454/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_master-libfapi_create-rpms-el7-x86_64_m... :
SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc20-x86_64_merged/252/ : FAILURE

http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/4246/ : FAILURE

http://jenkins.ovirt.org/job/vdsm_master_create-rpms-el6-x86_64_merged/259/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_create-rpms-el7-x86_64_merged/261/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_master-libfapi_create-rpms-fc21-x86_64_... :
FAILURE

-- 
To view, visit http://gerrit.ovirt.org/32915
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib6c40755c361523a28cbd68af110e3b20cb9ae25
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Genadi Chereshnya <gcheresh(a)redhat.com&gt;
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Genadi Chereshnya <gcheresh(a)redhat.com&gt;
Gerrit-Reviewer: Ido Barkan <ibarkan(a)redhat.com&gt;
Gerrit-Reviewer: Meni Yakove <myakove(a)redhat.com&gt;
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com&gt;
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No

Change in vdsm[master]: netinfo: Displays active slave for the bond in getVdsCaps vd...

Antoni Segura Puimedon has posted comments on this change.

Change subject: netinfo: Displays active slave for the bond in getVdsCaps vdsmapi-schema:
Adding Active slave support networkTests: Test to check if active slave exists
......................................................................


Patch Set 6: Code-Review-1

(1 comment)

Sorry I forgot about this little detail.

http://gerrit.ovirt.org/#/c/32915/6/tests/functional/networkTests.py
File tests/functional/networkTests.py:

Line 2356:             create_bond_with_mode(nics, 1)
Line 2357:             self.assert_active_slave_exists(BONDING_NAME, nics)
Line 2358:             create_bond_with_mode(nics, 4)
Line 2359:             self.assert_active_slave_doesnt_exist(BONDING_NAME)
Line 2360
You should be destroying the bond after this:
    status, msg = self.vdsm_net.setupNetworks({}, {BONDING_NAME: {'remove':
True}}, NOCHK)
    self.assertEqual(status, SUCCESS, msg)


-- 
To view, visit http://gerrit.ovirt.org/32915
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib6c40755c361523a28cbd68af110e3b20cb9ae25
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Genadi Chereshnya <gcheresh(a)redhat.com&gt;
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Genadi Chereshnya <gcheresh(a)redhat.com&gt;
Gerrit-Reviewer: Ido Barkan <ibarkan(a)redhat.com&gt;
Gerrit-Reviewer: Meni Yakove <myakove(a)redhat.com&gt;
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes

Change in vdsm[master]: netinfo: Displays active slave for the bond in getVdsCaps vd...

Ido Barkan has posted comments on this change.

Change subject: netinfo: Displays active slave for the bond in getVdsCaps vdsmapi-schema:
Adding Active slave support networkTests: Test to check if active slave exists
......................................................................


Patch Set 5: Code-Review-1

(1 comment)

http://gerrit.ovirt.org/#/c/32915/5/tests/functional/networkTests.py
File tests/functional/networkTests.py:

Line 162: class Alarm(Exception):
Line 163:     pass
Line 164: 
Line 165: 
Line 166: class SetupNetworkError(Exception):
you should have removed this Exception and _create_bon__with_mode bur probably forgotten.
Line 167:     """
Line 168:     Exception for _create_bond__with_mode
Line 169:     """
Line 170:     pass


-- 
To view, visit http://gerrit.ovirt.org/32915
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib6c40755c361523a28cbd68af110e3b20cb9ae25
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Genadi Chereshnya <gcheresh(a)redhat.com&gt;
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Genadi Chereshnya <gcheresh(a)redhat.com&gt;
Gerrit-Reviewer: Ido Barkan <ibarkan(a)redhat.com&gt;
Gerrit-Reviewer: Meni Yakove <myakove(a)redhat.com&gt;
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes

Change in vdsm[master]: netinfo: Displays active slave for the bond in getVdsCaps vd...

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: netinfo: Displays active slave for the bond in getVdsCaps vdsmapi-schema:
Adding Active slave support networkTests: Test to check if active slave exists
......................................................................


Patch Set 7:

Build Failed 

http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/13516/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/13354/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/12564/ : FAILURE

http://jenkins.ovirt.org/job/vdsm_master_network_functional_tests_gerrit/... : There was
an infra issue, please contact infra(a)ovirt.org

http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created_staging/130/ : FAILURE

-- 
To view, visit http://gerrit.ovirt.org/32915
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib6c40755c361523a28cbd68af110e3b20cb9ae25
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Genadi Chereshnya <gcheresh(a)redhat.com&gt;
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Genadi Chereshnya <gcheresh(a)redhat.com&gt;
Gerrit-Reviewer: Ido Barkan <ibarkan(a)redhat.com&gt;
Gerrit-Reviewer: Meni Yakove <myakove(a)redhat.com&gt;
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No

Change in vdsm[master]: netinfo: Displays active slave for the bond in getVdsCaps ne...

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: netinfo: Displays active slave for the bond in getVdsCaps networkTests:
test to check if active slave exists
......................................................................


Patch Set 2: Code-Review-1 Verified-1

Build Failed 

http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/13348/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/13188/ : UNSTABLE

http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/12398/ : FAILURE

http://jenkins.ovirt.org/job/vdsm_master_network_functional_tests_gerrit/... : There was
an infra issue, please contact infra(a)ovirt.org

-- 
To view, visit http://gerrit.ovirt.org/32915
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib6c40755c361523a28cbd68af110e3b20cb9ae25
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Genadi Chereshnya <gcheresh(a)redhat.com&gt;
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Genadi Chereshnya <gcheresh(a)redhat.com&gt;
Gerrit-Reviewer: Ido Barkan <ibarkan(a)redhat.com&gt;
Gerrit-Reviewer: Meni Yakove <myakove(a)redhat.com&gt;
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No

Change in vdsm[master]: netinfo: Displays active slave for the bond in getVdsCaps vd...

Antoni Segura Puimedon has posted comments on this change.

Change subject: netinfo: Displays active slave for the bond in getVdsCaps vdsmapi-schema:
Adding Active slave support networkTests: Test to check if active slave exists
......................................................................


Patch Set 3: Code-Review+1

-- 
To view, visit http://gerrit.ovirt.org/32915
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib6c40755c361523a28cbd68af110e3b20cb9ae25
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Genadi Chereshnya <gcheresh(a)redhat.com&gt;
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Genadi Chereshnya <gcheresh(a)redhat.com&gt;
Gerrit-Reviewer: Ido Barkan <ibarkan(a)redhat.com&gt;
Gerrit-Reviewer: Meni Yakove <myakove(a)redhat.com&gt;
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No

Change in vdsm[master]: netinfo: Displays active slave for the bond in getVdsCaps vd...

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: netinfo: Displays active slave for the bond in getVdsCaps vdsmapi-schema:
Adding Active slave support networkTests: Test to check if active slave exists
......................................................................


Patch Set 3:

Build Failed 

http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/13369/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/13208/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/12418/ : FAILURE

http://jenkins.ovirt.org/job/vdsm_master_network_functional_tests_gerrit/... : There was
an infra issue, please contact infra(a)ovirt.org

-- 
To view, visit http://gerrit.ovirt.org/32915
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib6c40755c361523a28cbd68af110e3b20cb9ae25
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Genadi Chereshnya <gcheresh(a)redhat.com&gt;
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Genadi Chereshnya <gcheresh(a)redhat.com&gt;
Gerrit-Reviewer: Ido Barkan <ibarkan(a)redhat.com&gt;
Gerrit-Reviewer: Meni Yakove <myakove(a)redhat.com&gt;
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: netinfo: Displays active slave for the bond in getVdsCaps
......................................................................


Patch Set 1:

Please find a functional test that creates a bond. Make it create the bond (or another
bond) in a mode that has an "active" nic. Then check that "active" is
indeed reported back.

-- 
To view, visit http://gerrit.ovirt.org/32915
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib6c40755c361523a28cbd68af110e3b20cb9ae25
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Genadi Chereshnya <gcheresh(a)redhat.com&gt;
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Genadi Chereshnya <gcheresh(a)redhat.com&gt;
Gerrit-Reviewer: Meni Yakove <myakove(a)redhat.com&gt;
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No

Change in vdsm[master]: netinfo: Displays active slave for the bond in getVdsCaps vd...

Ido Barkan has posted comments on this change.

Change subject: netinfo: Displays active slave for the bond in getVdsCaps vdsmapi-schema:
Adding Active slave support networkTests: Test to check if active slave exists
......................................................................


Patch Set 3:

(1 comment)

http://gerrit.ovirt.org/#/c/32915/3/tests/functional/networkTests.py
File tests/functional/networkTests.py:

Line 374: 
Line 375:     def assertActiveSlaveDoesntExist(self, bondName):
Line 376:         netinfo = self.vdsm_net.netinfo
Line 377:         self.assertIn(bondName, netinfo.bondings)
Line 378:         self.assertEqual(netinfo.bondings[bondName]['active_slave'],
'')
You are repeating yourself here. I suggest factor out al least the first parts of those
two functions
Line 379: 
Line 380:     @cleanupNet
Line 381:     @permutations([[True], [False]])
Line 382:     @RequireDummyMod


-- 
To view, visit http://gerrit.ovirt.org/32915
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib6c40755c361523a28cbd68af110e3b20cb9ae25
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Genadi Chereshnya <gcheresh(a)redhat.com&gt;
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Genadi Chereshnya <gcheresh(a)redhat.com&gt;
Gerrit-Reviewer: Ido Barkan <ibarkan(a)redhat.com&gt;
Gerrit-Reviewer: Meni Yakove <myakove(a)redhat.com&gt;
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes

Change in vdsm[master]: netinfo: Displays active slave for the bond in getVdsCaps vd...

Genadi Chereshnya has posted comments on this change.

Change subject: netinfo: Displays active slave for the bond in getVdsCaps vdsmapi-schema:
Adding Active slave support networkTests: Test to check if active slave exists
......................................................................


Patch Set 4: Verified+1

-- 
To view, visit http://gerrit.ovirt.org/32915
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib6c40755c361523a28cbd68af110e3b20cb9ae25
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Genadi Chereshnya <gcheresh(a)redhat.com&gt;
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Genadi Chereshnya <gcheresh(a)redhat.com&gt;
Gerrit-Reviewer: Ido Barkan <ibarkan(a)redhat.com&gt;
Gerrit-Reviewer: Meni Yakove <myakove(a)redhat.com&gt;
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No

Change in vdsm[master]: netinfo: Displays active slave for the bond in getVdsCaps vd...

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: netinfo: Displays active slave for the bond in getVdsCaps vdsmapi-schema:
Adding Active slave support networkTests: Test to check if active slave exists
......................................................................


Patch Set 4:

Build Failed 

http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/13448/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/13287/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/12497/ : FAILURE

http://jenkins.ovirt.org/job/vdsm_master_network_functional_tests_gerrit/... : There was
an infra issue, please contact infra(a)ovirt.org

http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created_staging/60/ : FAILURE

-- 
To view, visit http://gerrit.ovirt.org/32915
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib6c40755c361523a28cbd68af110e3b20cb9ae25
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Genadi Chereshnya <gcheresh(a)redhat.com&gt;
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Genadi Chereshnya <gcheresh(a)redhat.com&gt;
Gerrit-Reviewer: Ido Barkan <ibarkan(a)redhat.com&gt;
Gerrit-Reviewer: Meni Yakove <myakove(a)redhat.com&gt;
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No

Change in vdsm[master]: netinfo: Displays active slave for the bond in getVdsCaps vd...

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: netinfo: Displays active slave for the bond in getVdsCaps vdsmapi-schema:
Adding Active slave support networkTests: Test to check if active slave exists
......................................................................


Patch Set 5:

Build Failed 

http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/13495/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/13333/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/12543/ : FAILURE

http://jenkins.ovirt.org/job/vdsm_master_network_functional_tests_gerrit/... : There was
an infra issue, please contact infra(a)ovirt.org

http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created_staging/109/ : FAILURE

-- 
To view, visit http://gerrit.ovirt.org/32915
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib6c40755c361523a28cbd68af110e3b20cb9ae25
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Genadi Chereshnya <gcheresh(a)redhat.com&gt;
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Genadi Chereshnya <gcheresh(a)redhat.com&gt;
Gerrit-Reviewer: Ido Barkan <ibarkan(a)redhat.com&gt;
Gerrit-Reviewer: Meni Yakove <myakove(a)redhat.com&gt;
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No

Change in vdsm[master]: netinfo: Displays active slave for the bond in getVdsCaps vd...

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: netinfo: Displays active slave for the bond in getVdsCaps vdsmapi-schema:
Adding Active slave support networkTests: Test to check if active slave exists
......................................................................


Patch Set 6:

Build Failed 

http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/13496/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/13334/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/12544/ : FAILURE

http://jenkins.ovirt.org/job/vdsm_master_network_functional_tests_gerrit/... : There was
an infra issue, please contact infra(a)ovirt.org

http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created_staging/110/ : FAILURE

-- 
To view, visit http://gerrit.ovirt.org/32915
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib6c40755c361523a28cbd68af110e3b20cb9ae25
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Genadi Chereshnya <gcheresh(a)redhat.com&gt;
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Genadi Chereshnya <gcheresh(a)redhat.com&gt;
Gerrit-Reviewer: Ido Barkan <ibarkan(a)redhat.com&gt;
Gerrit-Reviewer: Meni Yakove <myakove(a)redhat.com&gt;
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No

Change in vdsm[master]: netinfo: Displays active slave for the bond in getVdsCaps vd...

Meni Yakove has posted comments on this change.

Change subject: netinfo: Displays active slave for the bond in getVdsCaps vdsmapi-schema:
Adding Active slave support networkTests: Test to check if active slave exists
......................................................................


Patch Set 6:

Antoni, what does @cleanupNet do?

-- 
To view, visit http://gerrit.ovirt.org/32915
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib6c40755c361523a28cbd68af110e3b20cb9ae25
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Genadi Chereshnya <gcheresh(a)redhat.com&gt;
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Genadi Chereshnya <gcheresh(a)redhat.com&gt;
Gerrit-Reviewer: Ido Barkan <ibarkan(a)redhat.com&gt;
Gerrit-Reviewer: Meni Yakove <myakove(a)redhat.com&gt;
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No

Change in vdsm[master]: netinfo: Displays active slave for the bond in getVdsCaps vd...

Genadi Chereshnya has posted comments on this change.

Change subject: netinfo: Displays active slave for the bond in getVdsCaps vdsmapi-schema:
Adding Active slave support networkTests: Test to check if active slave exists
......................................................................


Patch Set 7: Verified+1

-- 
To view, visit http://gerrit.ovirt.org/32915
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib6c40755c361523a28cbd68af110e3b20cb9ae25
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Genadi Chereshnya <gcheresh(a)redhat.com&gt;
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Genadi Chereshnya <gcheresh(a)redhat.com&gt;
Gerrit-Reviewer: Ido Barkan <ibarkan(a)redhat.com&gt;
Gerrit-Reviewer: Meni Yakove <myakove(a)redhat.com&gt;
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No

Change in vdsm[master]: netinfo: Displays active slave for the bond in getVdsCaps vd...

Ido Barkan has posted comments on this change.

Change subject: netinfo: Displays active slave for the bond in getVdsCaps vdsmapi-schema:
Adding Active slave support networkTests: Test to check if active slave exists
......................................................................


Patch Set 7: Code-Review+1

-- 
To view, visit http://gerrit.ovirt.org/32915
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib6c40755c361523a28cbd68af110e3b20cb9ae25
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Genadi Chereshnya <gcheresh(a)redhat.com&gt;
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Genadi Chereshnya <gcheresh(a)redhat.com&gt;
Gerrit-Reviewer: Ido Barkan <ibarkan(a)redhat.com&gt;
Gerrit-Reviewer: Meni Yakove <myakove(a)redhat.com&gt;
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No

Change in vdsm[master]: netinfo: Displays active slave for the bond in getVdsCaps vd...

Genadi Chereshnya has posted comments on this change.

Change subject: netinfo: Displays active slave for the bond in getVdsCaps vdsmapi-schema:
Adding Active slave support networkTests: Test to check if active slave exists
......................................................................


Patch Set 7:

(2 comments)

http://gerrit.ovirt.org/#/c/32915/7/vdsm/rpc/vdsmapi-schema.json
File vdsm/rpc/vdsmapi-schema.json:

Line 769: # Information about a ethernet bond device
Line 770: #
Line 771: # @slaves:      A list of devices that are enslaved to the bond device
Line 772: #
Line 773: # @active_slave: Active slave of the bond if exists, '' otherwise
>  Please align beginning of argument descriptions in line. 
Done
Line 774: #
Line 775: # @bootproto4:  The protocol used to set up the network. Reported values are
Line 776: #               "dhcp" if a DHCPv4 client was used, 'none' if
set up manually.
Line 777: #               (Added in version 4.16.0.)


Line 798: # Since: 4.10.0
Line 799: ##
Line 800: {'type': 'NetInfoBond',
Line 801:  'data': {'slaves': ['str'], 'active_slave':
'str','bootproto4': 'str',
Line 802:           'addr': 'str', 'netmask': 'str',
'ipv4addrs': ['str'],
>  Please align data arguments in line. 
Done
Line 803:           'ipv6addrs': ['str'], 'hwaddr': 'str',
'cfg': 'StringMap',
Line 804:            'mtu': 'uint', 'opts': 'StringMap'}}
Line 805: 
Line 806: ##


-- 
To view, visit http://gerrit.ovirt.org/32915
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib6c40755c361523a28cbd68af110e3b20cb9ae25
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Genadi Chereshnya <gcheresh(a)redhat.com&gt;
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Genadi Chereshnya <gcheresh(a)redhat.com&gt;
Gerrit-Reviewer: Ido Barkan <ibarkan(a)redhat.com&gt;
Gerrit-Reviewer: Meni Yakove <myakove(a)redhat.com&gt;
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com&gt;
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes

Change in vdsm[master]: netinfo: Displays active slave for the bond in getVdsCaps vd...

Genadi Chereshnya has posted comments on this change.

Change subject: netinfo: Displays active slave for the bond in getVdsCaps vdsmapi-schema:
Adding Active slave support networkTests: Test to check if active slave exists
......................................................................


Patch Set 8: Verified+1

-- 
To view, visit http://gerrit.ovirt.org/32915
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib6c40755c361523a28cbd68af110e3b20cb9ae25
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Genadi Chereshnya <gcheresh(a)redhat.com&gt;
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Genadi Chereshnya <gcheresh(a)redhat.com&gt;
Gerrit-Reviewer: Ido Barkan <ibarkan(a)redhat.com&gt;
Gerrit-Reviewer: Meni Yakove <myakove(a)redhat.com&gt;
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com&gt;
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No

Change in vdsm[master]: netinfo: Displays active slave for the bond in getVdsCaps vd...

[Dan Kenigsberg]

Dan Kenigsberg has submitted this change and it was merged.

Change subject: netinfo: Displays active slave for the bond in getVdsCaps vdsmapi-schema:
Adding Active slave support networkTests: Test to check if active slave exists
......................................................................


netinfo: Displays active slave for the bond in getVdsCaps
vdsmapi-schema: Adding Active slave support
networkTests: Test to check if active slave exists

Adding active slave field for the bond in the getVdsCaps
Adding active slave in vdsmapi-schema.json
Displays an active slave if exists or displays '' when there is no active slave

Change-Id: Ib6c40755c361523a28cbd68af110e3b20cb9ae25
Signed-off-by: Genadi Chereshnya <gcheresh(a)redhat.com&gt;
Reviewed-on: http://gerrit.ovirt.org/32915
Reviewed-by: Piotr Kliczewski <piotr.kliczewski(a)gmail.com&gt;
Reviewed-by: Dan Kenigsberg <danken(a)redhat.com&gt;
---
M lib/vdsm/netinfo.py
M tests/functional/networkTests.py
M vdsm/rpc/vdsmapi-schema.json
3 files changed, 45 insertions(+), 4 deletions(-)

Approvals:
  Piotr Kliczewski: Looks good to me, but someone else must approve
  Genadi Chereshnya: Verified
  Dan Kenigsberg: Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/32915
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ib6c40755c361523a28cbd68af110e3b20cb9ae25
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Genadi Chereshnya <gcheresh(a)redhat.com&gt;
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Genadi Chereshnya <gcheresh(a)redhat.com&gt;
Gerrit-Reviewer: Ido Barkan <ibarkan(a)redhat.com&gt;
Gerrit-Reviewer: Meni Yakove <myakove(a)redhat.com&gt;
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com&gt;
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server

Change in vdsm[master]: netinfo: Displays active slave for the bond in getVdsCaps vd...

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: netinfo: Displays active slave for the bond in getVdsCaps vdsmapi-schema:
Adding Active slave support networkTests: Test to check if active slave exists
......................................................................


Patch Set 8:

Build Failed 

http://jenkins.ovirt.org/job/vdsm_master_network_functional_tests_gerrit/... : There was
an infra issue, please contact infra(a)ovirt.org

http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/13730/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/12941/ : FAILURE

http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/13893/ : FAILURE

-- 
To view, visit http://gerrit.ovirt.org/32915
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib6c40755c361523a28cbd68af110e3b20cb9ae25
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Genadi Chereshnya <gcheresh(a)redhat.com&gt;
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Genadi Chereshnya <gcheresh(a)redhat.com&gt;
Gerrit-Reviewer: Ido Barkan <ibarkan(a)redhat.com&gt;
Gerrit-Reviewer: Meni Yakove <myakove(a)redhat.com&gt;
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com&gt;
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No

Genadi Chereshnya has posted comments on this change.

Change subject: netinfo: Displays active slave for the bond in getVdsCaps
......................................................................


Patch Set 1:

What existing function should I tweak?

-- 
To view, visit http://gerrit.ovirt.org/32915
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib6c40755c361523a28cbd68af110e3b20cb9ae25
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Genadi Chereshnya <gcheresh(a)redhat.com&gt;
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Genadi Chereshnya <gcheresh(a)redhat.com&gt;
Gerrit-Reviewer: Meni Yakove <myakove(a)redhat.com&gt;
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: netinfo: Displays active slave for the bond in getVdsCaps
......................................................................


Patch Set 1: Code-Review-1

vdsm/rpc/vdsmapi-schema.json should be updated with the new optional information.

Also, please tweak an existing functional test to check that active_slave is reported.

-- 
To view, visit http://gerrit.ovirt.org/32915
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib6c40755c361523a28cbd68af110e3b20cb9ae25
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Genadi Chereshnya <gcheresh(a)redhat.com&gt;
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Genadi Chereshnya <gcheresh(a)redhat.com&gt;
Gerrit-Reviewer: Meni Yakove <myakove(a)redhat.com&gt;
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No

Antoni Segura Puimedon has posted comments on this change.

Change subject: netinfo: Displays active slave for the bond in getVdsCaps
......................................................................


Patch Set 1: Code-Review+1

-- 
To view, visit http://gerrit.ovirt.org/32915
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib6c40755c361523a28cbd68af110e3b20cb9ae25
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Genadi Chereshnya <gcheresh(a)redhat.com&gt;
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Genadi Chereshnya <gcheresh(a)redhat.com&gt;
Gerrit-Reviewer: Meni Yakove <myakove(a)redhat.com&gt;
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No

Genadi Chereshnya has posted comments on this change.

Change subject: netinfo: Displays active slave for the bond in getVdsCaps
......................................................................


Patch Set 1: Verified+1

-- 
To view, visit http://gerrit.ovirt.org/32915
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib6c40755c361523a28cbd68af110e3b20cb9ae25
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Genadi Chereshnya <gcheresh(a)redhat.com&gt;
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Genadi Chereshnya <gcheresh(a)redhat.com&gt;
Gerrit-Reviewer: Meni Yakove <myakove(a)redhat.com&gt;
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No

Meni Yakove has posted comments on this change.

Change subject: netinfo: Displays active slave for the bond in getVdsCaps
......................................................................


Patch Set 1: Code-Review+1

-- 
To view, visit http://gerrit.ovirt.org/32915
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib6c40755c361523a28cbd68af110e3b20cb9ae25
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Genadi Chereshnya <gcheresh(a)redhat.com&gt;
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Meni Yakove <myakove(a)redhat.com&gt;
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: netinfo: Displays active slave for the bond in getVdsCaps
......................................................................


Patch Set 1:

Build Failed 

http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/11520/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/12464/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_network_functional_tests_gerrit/... : There was
an infra issue, please contact infra(a)ovirt.org

http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/12309/ : SUCCESS

-- 
To view, visit http://gerrit.ovirt.org/32915
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib6c40755c361523a28cbd68af110e3b20cb9ae25
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Genadi Chereshnya <gcheresh(a)redhat.com&gt;
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Meni Yakove <myakove(a)redhat.com&gt;
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No

Change in vdsm[master]: netinfo: Displays active slave for the bond in getVdsCaps vd...

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: netinfo: Displays active slave for the bond in getVdsCaps vdsmapi-schema:
Adding Active slave support networkTests: Test to check if active slave exists
......................................................................


Patch Set 8: Code-Review+2

-- 
To view, visit http://gerrit.ovirt.org/32915
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib6c40755c361523a28cbd68af110e3b20cb9ae25
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Genadi Chereshnya <gcheresh(a)redhat.com&gt;
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Genadi Chereshnya <gcheresh(a)redhat.com&gt;
Gerrit-Reviewer: Ido Barkan <ibarkan(a)redhat.com&gt;
Gerrit-Reviewer: Meni Yakove <myakove(a)redhat.com&gt;
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com&gt;
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No