Change in vdsm[master]: check-merged: collect lago logs

[Code Review]

From Dan Kenigsberg <danken(a)redhat.com&gt;:

Dan Kenigsberg has uploaded a new change for review.

Change subject: check-merged: collect lago logs
......................................................................

check-merged: collect lago logs

Change-Id: I69673a9c4684ebeefdb37ccbeb2abed039efe76c
Signed-off-by: Dan Kenigsberg <danken(a)redhat.com&gt;
---
M automation/check-merged.sh
1 file changed, 3 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/38/69138/1

diff --git a/automation/check-merged.sh b/automation/check-merged.sh
index 2e4df95..facb478 100755
--- a/automation/check-merged.sh
+++ b/automation/check-merged.sh
@@ -120,11 +120,10 @@
 
 lago cleanup
 
+
 cat "$EXPORTS/functional_tests_stdout.$distro.log"
 
-[[ -e "logs" ]] \
-&& {
-    tar cvzf "$EXPORTS/lago-logs.tar.gz" logs
-}
+mkdir "$EXPORTS"/lago-logs
+cp "$PREFIX"/*.log "$EXPORTS"/lago-logs
 
 exit $failed


-- 
To view, visit https://gerrit.ovirt.org/69138
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I69673a9c4684ebeefdb37ccbeb2abed039efe76c
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com&gt;

[Code Review]

From Yaniv Bronhaim <ybronhei(a)redhat.com&gt;:

Yaniv Bronhaim has posted comments on this change.

Change subject: check-merged: collect lago logs
......................................................................


Patch Set 2:

Barak - you told me about better way to collect all logs.. tell us what's the best
approach in our case

-- 
To view, visit https://gerrit.ovirt.org/69138
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I69673a9c4684ebeefdb37ccbeb2abed039efe76c
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com&gt;
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com&gt;
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org&gt;
Gerrit-HasComments: No

[Code Review]

From Dan Kenigsberg <danken(a)redhat.com&gt;:

Dan Kenigsberg has posted comments on this change.

Change subject: check-merged: collect lago logs
......................................................................


Patch Set 2: Verified-1

cp: cannot stat
���/home/jenkins/workspace/vdsm_master_check-merged-el7-x86_64/vdsm/automation/vdsm_functional/*.log���:
No such file or directory

Barak, do you know if the logs are expected to be found in $PREFIX or somewhere else?

-- 
To view, visit https://gerrit.ovirt.org/69138
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I69673a9c4684ebeefdb37ccbeb2abed039efe76c
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com&gt;
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org&gt;
Gerrit-HasComments: No

[Code Review]

From Dan Kenigsberg <danken(a)redhat.com&gt;:

Dan Kenigsberg has posted comments on this change.

Change subject: check-merged: collect lago logs
......................................................................


Patch Set 2:

Could there be a successful lago run with no logs?

-- 
To view, visit https://gerrit.ovirt.org/69138
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I69673a9c4684ebeefdb37ccbeb2abed039efe76c
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com&gt;
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org&gt;
Gerrit-HasComments: No

[Code Review]

From Dan Kenigsberg <danken(a)redhat.com&gt;:

Dan Kenigsberg has posted comments on this change.

Change subject: check-merged: collect lago logs
......................................................................


Patch Set 3: Verified-1

This patch is not really useful before https://ovirt-jira.atlassian.net/browse/OVIRT-988
is fixed, as the copied logs are not copied in the case they matter most.

-- 
To view, visit https://gerrit.ovirt.org/69138
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I69673a9c4684ebeefdb37ccbeb2abed039efe76c
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com&gt;
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org&gt;
Gerrit-HasComments: No

[Code Review]

From Yaniv Bronhaim <ybronhei(a)redhat.com&gt;:

Yaniv Bronhaim has posted comments on this change.

Change subject: check-merged: collect lago logs
......................................................................


Patch Set 4: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/69138
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I69673a9c4684ebeefdb37ccbeb2abed039efe76c
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com&gt;
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org&gt;
Gerrit-HasComments: No

[Code Review]

From Dan Kenigsberg <danken(a)redhat.com&gt;:

Dan Kenigsberg has posted comments on this change.

Change subject: check-merged: collect lago logs
......................................................................


Patch Set 5: Verified+1

http://jenkins.ovirt.org/job/vdsm_master_check-merged-el7-x86_64/904/arti...

-- 
To view, visit https://gerrit.ovirt.org/69138
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I69673a9c4684ebeefdb37ccbeb2abed039efe76c
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com&gt;
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org&gt;
Gerrit-HasComments: No

[Code Review]

From Dan Kenigsberg <danken(a)redhat.com&gt;:

Dan Kenigsberg has submitted this change and it was merged.

Change subject: check-merged: collect lago logs
......................................................................


check-merged: collect lago logs

Change-Id: I69673a9c4684ebeefdb37ccbeb2abed039efe76c
Signed-off-by: Dan Kenigsberg <danken(a)redhat.com&gt;
---
M automation/check-merged.sh
1 file changed, 2 insertions(+), 4 deletions(-)

Approvals:
  Piotr Kliczewski: Looks good to me, approved
  Jenkins CI: Passed CI tests
  Irit Goihman: Looks good to me, but someone else must approve
  Dan Kenigsberg: Verified



-- 
To view, visit https://gerrit.ovirt.org/69138
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I69673a9c4684ebeefdb37ccbeb2abed039efe76c
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com&gt;
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com&gt;
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com&gt;
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org&gt;