Federico Simoncelli has posted comments on this change.
Change subject: [WIP] Move the VDSM common code to the python site lib
Patch Set 1:
wow. I was considering to have a proper vdsm python package since
I considered moving all (but few executable scripts) - and feared the
head ache. I never thought of moving only several of the modules.
Moving them all is easier (you don't have to modify the imports), the
problem is that not all the modules we have are designed to be used as
standalone libraries. I really hope to move other modules in the new
package soon but only when they're designed properly.
However, do we really need vdsm-python as a separate rpm?
Yes, as explained in the commit message it's solving one problem in the
standard way: shipping the common files in a separate package.
I find the name a bit funny as everything else is python, too.
Everything else is in python but it's not designed to be a library,
it's an application and we don't care about its language since we're
interacting with it just through its executables and not through any
To view, visit http://gerrit.ovirt.org/286
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>