Nir Soffer has uploaded a new change for review.
Change subject: sp: Fix positinal args calling convention ......................................................................
sp: Fix positinal args calling convention
StorageDomain.setDescription and Volume.setLegality accept one positional argument. Using kwarg calling style is pointless.
Change-Id: I2d73df3daa59efb512bfdc9f6e400bacb3c08c49 Signed-off-by: Nir Soffer nsoffer@redhat.com --- M vdsm/storage/sp.py 1 file changed, 3 insertions(+), 3 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/48/65048/1
diff --git a/vdsm/storage/sp.py b/vdsm/storage/sp.py index 78562c9..3297588 100644 --- a/vdsm/storage/sp.py +++ b/vdsm/storage/sp.py @@ -1942,14 +1942,14 @@ img_ns = sd.getNamespace(sc.IMAGE_NAMESPACE, sdUUID) with rm.acquireResource(img_ns, imgUUID, rm.EXCLUSIVE): vol = sdCache.produce(sdUUID).produceVolume(imgUUID, volUUID) - vol.setDescription(descr=description) + vol.setDescription(description)
def setVolumeLegality(self, sdUUID, imgUUID, volUUID, legality): self.validatePoolSD(sdUUID) img_ns = sd.getNamespace(sc.IMAGE_NAMESPACE, sdUUID) with rm.acquireResource(img_ns, imgUUID, rm.EXCLUSIVE): vol = sdCache.produce(sdUUID).produceVolume(imgUUID, volUUID) - vol.setLegality(legality=legality) + vol.setLegality(legality)
def getVmsList(self, sdUUID): self.validatePoolSD(sdUUID) @@ -1972,7 +1972,7 @@
def setSDDescription(self, sd, description): self.validatePoolSD(sd.sdUUID) - sd.setDescription(descr=description) + sd.setDescription(description)
def getAllTasksStatuses(self): return self.taskMng.getAllTasksStatuses("spm")
gerrit-hooks has posted comments on this change.
Change subject: sp: Fix positinal args calling convention ......................................................................
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0'])
Nir Soffer has posted comments on this change.
Change subject: sp: Fix positinal args calling convention ......................................................................
Patch Set 1: Continuous-Integration+1
Network tests on python 3
gerrit-hooks has posted comments on this change.
Change subject: sp: Fix positinal args calling convention ......................................................................
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0'])
gerrit-hooks has posted comments on this change.
Change subject: sp: Fix positinal args calling convention ......................................................................
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0'])
gerrit-hooks has posted comments on this change.
Change subject: sp: Fix positional args calling convention ......................................................................
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0'])
gerrit-hooks has posted comments on this change.
Change subject: sp: Fix positional args calling convention ......................................................................
Patch Set 5:
* Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0'])
gerrit-hooks has posted comments on this change.
Change subject: sp: Fix positional args calling convention ......................................................................
Patch Set 6:
* Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0'])
gerrit-hooks has posted comments on this change.
Change subject: sp: Fix positional args calling convention ......................................................................
Patch Set 7:
* Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0'])
Nir Soffer has posted comments on this change.
Change subject: sp: Fix positional args calling convention ......................................................................
Patch Set 7: Verified+1
Nir Soffer has posted comments on this change.
Change subject: sp: Fix positional args calling convention ......................................................................
Patch Set 7: Continuous-Integration+1
Test failures not relevant.
gerrit-hooks has posted comments on this change.
Change subject: sp: Fix positional args calling convention ......................................................................
Patch Set 8:
* Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0'])
Freddy Rolland has posted comments on this change.
Change subject: sp: Fix positional args calling convention ......................................................................
Patch Set 8: Code-Review+1
gerrit-hooks has posted comments on this change.
Change subject: sp: Fix positional args calling convention ......................................................................
Patch Set 9:
* Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0'])
Adam Litke has posted comments on this change.
Change subject: sp: Fix positional args calling convention ......................................................................
Patch Set 9: Code-Review+2
Nir Soffer has submitted this change and it was merged.
Change subject: sp: Fix positional args calling convention ......................................................................
sp: Fix positional args calling convention
StorageDomain.setDescription and Volume.setLegality accept one positional argument. Using kwarg calling style is pointless.
Change-Id: I2d73df3daa59efb512bfdc9f6e400bacb3c08c49 Signed-off-by: Nir Soffer nsoffer@redhat.com Reviewed-on: https://gerrit.ovirt.org/65048 Reviewed-by: Freddy Rolland frolland@redhat.com Continuous-Integration: Jenkins CI Reviewed-by: Adam Litke alitke@redhat.com --- M vdsm/storage/sp.py 1 file changed, 3 insertions(+), 3 deletions(-)
Approvals: Adam Litke: Looks good to me, approved Nir Soffer: Verified Jenkins CI: Passed CI tests Freddy Rolland: Looks good to me, but someone else must approve
gerrit-hooks has posted comments on this change.
Change subject: sp: Fix positional args calling convention ......................................................................
Patch Set 10:
* Update tracker: IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found.
vdsm-patches@lists.fedorahosted.org