Change in vdsm[master]: vmchannel: performance enhancment. changing thread name

Eldad Marciano has uploaded a new change for review.

Change subject: vmchannel: performance enhancment. changing thread name
......................................................................

vmchannel: performance enhancment.
changing thread name

Change-Id: I8489ec3a65ed9025eb91dfc2f408450b02fd7e0c
Signed-off-by: emarcian <emarcian(a)redhat.com&gt;
---
M vdsm/virt/vmchannels.py
1 file changed, 2 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/42/36342/1

diff --git a/vdsm/virt/vmchannels.py b/vdsm/virt/vmchannels.py
index c143162..e0b305e 100644
--- a/vdsm/virt/vmchannels.py
+++ b/vdsm/virt/vmchannels.py
@@ -167,8 +167,8 @@
         events = NoIntrPoll(self._epoll.poll, 1)
         if events:
             for (fileno, event) in events:
-                _wait_for_events = threading.Thread(name='handle_events-%s' %
fileno, target=self._handle_event, args=(fileno, event))
-                _wait_for_events.start()
+                _handle_event = threading.Thread(name='handle_events-%s' %
fileno, target=self._handle_event, args=(fileno, event))
+                _handle_event.start()
         else:
             self._update_channels()
             if (self._timeout is not None) and (self._timeout > 0):


-- 
To view, visit http://gerrit.ovirt.org/36342
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I8489ec3a65ed9025eb91dfc2f408450b02fd7e0c
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eldad Marciano <emarcian(a)redhat.com&gt;

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: vmchannel: performance enhancment. changing thread name
......................................................................


Patch Set 1: Code-Review-1 Verified-1

Build Failed 

http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/13659/ : FAILURE

http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/14616/ : FAILURE

http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/14448/ : UNSTABLE

http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/2094/ : There was an
infra issue, please contact infra(a)ovirt.org

-- 
To view, visit http://gerrit.ovirt.org/36342
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8489ec3a65ed9025eb91dfc2f408450b02fd7e0c
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eldad Marciano <emarcian(a)redhat.com&gt;
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com&gt;
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com&gt;
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No

[Nir Soffer]

Nir Soffer has posted comments on this change.

Change subject: vmchannel: performance enhancment. changing thread name
......................................................................


Patch Set 1:

(2 comments)

http://gerrit.ovirt.org/#/c/36342/1//COMMIT_MSG
Commit Message:

Line 4: Commit:     emarcian <emarcian(a)redhat.com&gt;
Line 5: CommitDate: 2014-12-22 15:36:29 +0200
Line 6: 
Line 7: vmchannel: performance enhancment.
Line 8: changing thread name
Can you explain in the commit message how this improve performance and why we need to
improve it?
Line 9: 
Line 10: Change-Id: I8489ec3a65ed9025eb91dfc2f408450b02fd7e0c


http://gerrit.ovirt.org/#/c/36342/1/vdsm/virt/vmchannels.py
File vdsm/virt/vmchannels.py:

Line 167:         events = NoIntrPoll(self._epoll.poll, 1)
Line 168:         if events:
Line 169:             for (fileno, event) in events:
Line 170:                 _handle_event = threading.Thread(name='handle_events-%s'
% fileno, target=self._handle_event, args=(fileno, event))
Line 171:                 _handle_event.start()
This change is not clear - what are you trying to do?
Line 172:         else:
Line 173:             self._update_channels()
Line 174:             if (self._timeout is not None) and (self._timeout > 0):
Line 175:                 self._handle_timeouts()


-- 
To view, visit http://gerrit.ovirt.org/36342
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8489ec3a65ed9025eb91dfc2f408450b02fd7e0c
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eldad Marciano <emarcian(a)redhat.com&gt;
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com&gt;
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com&gt;
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com&gt;
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes

Francesco Romani has posted comments on this change.

Change subject: vmchannel: performance enhancment. changing thread name
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

http://gerrit.ovirt.org/#/c/36342/1//COMMIT_MSG
Commit Message:

Line 4: Commit:     emarcian <emarcian(a)redhat.com&gt;
Line 5: CommitDate: 2014-12-22 15:36:29 +0200
Line 6: 
Line 7: vmchannel: performance enhancment.
Line 8: changing thread name
>  Can you explain in the commit message how this improve performance
> and why  
I think this patch needs to be abandoned, as it seems a refinemento of an
already abandoned patch addressing

https://bugzilla.redhat.com/show_bug.cgi?id=1174172

I don't think this patch goes in the right direction.

For more context, please see:
https://bugzilla.redhat.com/show_bug.cgi?id=1174172#c26
https://bugzilla.redhat.com/show_bug.cgi?id=1174172#c29
https://bugzilla.redhat.com/show_bug.cgi?id=1174172#c30
Line 9: 
Line 10: Change-Id: I8489ec3a65ed9025eb91dfc2f408450b02fd7e0c


-- 
To view, visit http://gerrit.ovirt.org/36342
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8489ec3a65ed9025eb91dfc2f408450b02fd7e0c
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eldad Marciano <emarcian(a)redhat.com&gt;
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com&gt;
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com&gt;
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com&gt;
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes

[Jenkins CI RO]

Jenkins CI RO has abandoned this change.

Change subject: vmchannel: performance enhancment. changing thread name
......................................................................


Abandoned

Abandoned due to no activity - please restore if still relevant

-- 
To view, visit https://gerrit.ovirt.org/36342
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: I8489ec3a65ed9025eb91dfc2f408450b02fd7e0c
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eldad Marciano <emarcian(a)redhat.com&gt;
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com&gt;
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenkins CI RO
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com&gt;
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com&gt;
Gerrit-Reviewer: automation(a)ovirt.org

[Jenkins CI RO]

Jenkins CI RO has posted comments on this change.

Change subject: vmchannel: performance enhancment. changing thread name
......................................................................


Patch Set 1:

Abandoned due to no activity - please restore if still relevant

-- 
To view, visit https://gerrit.ovirt.org/36342
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8489ec3a65ed9025eb91dfc2f408450b02fd7e0c
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eldad Marciano <emarcian(a)redhat.com&gt;
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com&gt;
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenkins CI RO
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com&gt;
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com&gt;
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-HasComments: No

automation(a)ovirt.org has posted comments on this change.

Change subject: vmchannel: performance enhancment. changing thread name
......................................................................


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found

-- 
To view, visit https://gerrit.ovirt.org/36342
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8489ec3a65ed9025eb91dfc2f408450b02fd7e0c
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eldad Marciano <emarcian(a)redhat.com&gt;
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com&gt;
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenkins CI RO
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com&gt;
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com&gt;
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-HasComments: No