Change in vdsm[master]: BZ#832199: selinux - move selinux from init to spec

[Douglas Schilling Landgraf]

Douglas Schilling Landgraf has uploaded a new change for review.

Change subject: BZ#832199: selinux - move selinux from init to spec
......................................................................

BZ#832199: selinux - move selinux from init to spec

To reduce the time during the init, transferring all the selinux
set to spec instead use it during the vdsm init.

Change-Id: Id515ddb96cbfb4f3a936336b3f7e261658df662a
Signed-off-by: Douglas Schilling Landgraf <dougsland(a)redhat.com&gt;
---
M vdsm.spec.in
M vdsm/vdsmd.init.in
2 files changed, 15 insertions(+), 9 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/00/5600/1
--
To view, visit http://gerrit.ovirt.org/5600
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Id515ddb96cbfb4f3a936336b3f7e261658df662a
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com&gt;

Change in vdsm[master]: BZ#832199: move selinux from init to spec

[Dan Kenigsberg]

Dan Kenigsberg has submitted this change and it was merged.

Change subject: BZ#832199: move selinux from init to spec
......................................................................


BZ#832199: move selinux from init to spec

To reduce the time during the init, transferring all the selinux
set to spec instead use it during the vdsm init.

Change-Id: Id515ddb96cbfb4f3a936336b3f7e261658df662a
Signed-off-by: Douglas Schilling Landgraf <dougsland(a)redhat.com&gt;
---
M vdsm.spec.in
M vdsm/vdsmd.init.in
2 files changed, 21 insertions(+), 9 deletions(-)

Approvals:
  Douglas Schilling Landgraf: Verified
  Dan Kenigsberg: Looks good to me, approved


--
To view, visit http://gerrit.ovirt.org/5600
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Id515ddb96cbfb4f3a936336b3f7e261658df662a
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com&gt;
Gerrit-Reviewer: Adam Litke <agl(a)us.ibm.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com&gt;
Gerrit-Reviewer: Mark Wu <wudxw(a)linux.vnet.ibm.com&gt;
Gerrit-Reviewer: Michael Burns <mburns(a)redhat.com&gt;

Change in vdsm[master]: BZ#832199: move selinux from init to spec

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: BZ#832199: move selinux from init to spec
......................................................................


Patch Set 7: Looks good to me, approved

--
To view, visit http://gerrit.ovirt.org/5600
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id515ddb96cbfb4f3a936336b3f7e261658df662a
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com&gt;
Gerrit-Reviewer: Adam Litke <agl(a)us.ibm.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com&gt;
Gerrit-Reviewer: Mark Wu <wudxw(a)linux.vnet.ibm.com&gt;
Gerrit-Reviewer: Michael Burns <mburns(a)redhat.com&gt;

Change in vdsm[master]: BZ#832199: move selinux from init to spec

[Douglas Schilling Landgraf]

Douglas Schilling Landgraf has posted comments on this change.

Change subject: BZ#832199: move selinux from init to spec
......................................................................


Patch Set 7: Verified

--
To view, visit http://gerrit.ovirt.org/5600
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id515ddb96cbfb4f3a936336b3f7e261658df662a
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com&gt;
Gerrit-Reviewer: Adam Litke <agl(a)us.ibm.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com&gt;
Gerrit-Reviewer: Mark Wu <wudxw(a)linux.vnet.ibm.com&gt;
Gerrit-Reviewer: Michael Burns <mburns(a)redhat.com&gt;

Change in vdsm[master]: BZ#832199: move selinux from init to spec

[Douglas Schilling Landgraf]

Douglas Schilling Landgraf has posted comments on this change.

Change subject: BZ#832199: move selinux from init to spec
......................................................................


Patch Set 5: (1 inline comment)

....................................................
File vdsm.spec.in
Line 397:     fi
If the default behaviour of the boolean is 'on' and for some reason the admin set
the runtime rule to off we must guarantee it should be on. Next patch will fix it.

--
To view, visit http://gerrit.ovirt.org/5600
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id515ddb96cbfb4f3a936336b3f7e261658df662a
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com&gt;
Gerrit-Reviewer: Adam Litke <agl(a)us.ibm.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com&gt;
Gerrit-Reviewer: Mark Wu <wudxw(a)linux.vnet.ibm.com&gt;
Gerrit-Reviewer: Michael Burns <mburns(a)redhat.com&gt;

Change in vdsm[master]: BZ#832199: move selinux from init to spec

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: BZ#832199: move selinux from init to spec
......................................................................


Patch Set 5: (1 inline comment)

....................................................
File vdsm.spec.in
Line 397:     fi
sorry, I do not understand what is the fail condition you are warning against.

If Douglas understands, cool, I'll see the fix and understand myself.

--
To view, visit http://gerrit.ovirt.org/5600
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id515ddb96cbfb4f3a936336b3f7e261658df662a
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com&gt;
Gerrit-Reviewer: Adam Litke <agl(a)us.ibm.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com&gt;
Gerrit-Reviewer: Mark Wu <wudxw(a)linux.vnet.ibm.com&gt;
Gerrit-Reviewer: Michael Burns <mburns(a)redhat.com&gt;

Change in vdsm[master]: BZ#832199: move selinux from init to spec

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: BZ#832199: move selinux from init to spec
......................................................................


Patch Set 4: (1 inline comment)

....................................................
File vdsm.spec.in
Line 385: virtNFS=$(/usr/sbin/semanage boolean -l | grep virt_use_nfs | cut -d ','
-f 2)
I am mostly worried about the need to run semanage TWO more time.
and of course about the annoying complexity incurred by this patch.

--
To view, visit http://gerrit.ovirt.org/5600
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id515ddb96cbfb4f3a936336b3f7e261658df662a
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com&gt;
Gerrit-Reviewer: Adam Litke <agl(a)us.ibm.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com&gt;
Gerrit-Reviewer: Mark Wu <wudxw(a)linux.vnet.ibm.com&gt;
Gerrit-Reviewer: Michael Burns <mburns(a)redhat.com&gt;

Change in vdsm[master]: BZ#832199: move selinux from init to spec

Mark Wu has posted comments on this change.

Change subject: BZ#832199: move selinux from init to spec
......................................................................


Patch Set 5: I would prefer that you didn't submit this

(1 inline comment)

....................................................
File vdsm.spec.in
Line 397:     fi
I suggest moving 'setsebool' outside of the if statement in line 389
because they're enabled in policy, but disabled on runtime.  Vdsm would fail to run vm

 after installation. It could happen in a very small chance.

--
To view, visit http://gerrit.ovirt.org/5600
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id515ddb96cbfb4f3a936336b3f7e261658df662a
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com&gt;
Gerrit-Reviewer: Adam Litke <agl(a)us.ibm.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com&gt;
Gerrit-Reviewer: Mark Wu <wudxw(a)linux.vnet.ibm.com&gt;
Gerrit-Reviewer: Michael Burns <mburns(a)redhat.com&gt;

Change in vdsm[master]: BZ#832199: move selinux from init to spec

[Douglas Schilling Landgraf]

Douglas Schilling Landgraf has posted comments on this change.

Change subject: BZ#832199: move selinux from init to spec
......................................................................


Patch Set 5: Verified

--
To view, visit http://gerrit.ovirt.org/5600
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id515ddb96cbfb4f3a936336b3f7e261658df662a
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com&gt;
Gerrit-Reviewer: Adam Litke <agl(a)us.ibm.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com&gt;
Gerrit-Reviewer: Mark Wu <wudxw(a)linux.vnet.ibm.com&gt;
Gerrit-Reviewer: Michael Burns <mburns(a)redhat.com&gt;

Change in vdsm[master]: BZ#832199: move selinux from init to spec

[Douglas Schilling Landgraf]

Douglas Schilling Landgraf has posted comments on this change.

Change subject: BZ#832199: move selinux from init to spec
......................................................................


Patch Set 4: (2 inline comments)

....................................................
File vdsm.spec.in
Line 385: virtNFS=$(/usr/sbin/semanage boolean -l | grep virt_use_nfs | cut -d ','
-f 2)
I don't see any slower installation because of that. I used "grep | cut"
because I would like to avoid grep string based on spaces like you showed above. Please
let me know your opinion, then I can prepare a new version of the patch.

Line 444:     virtNFS=$(/usr/sbin/semanage boolean -l | grep virt_use_nfs | cut -d
',' -f 2)
Ok, next patch will resolve that.

--
To view, visit http://gerrit.ovirt.org/5600
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id515ddb96cbfb4f3a936336b3f7e261658df662a
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com&gt;
Gerrit-Reviewer: Adam Litke <agl(a)us.ibm.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com&gt;
Gerrit-Reviewer: Mark Wu <wudxw(a)linux.vnet.ibm.com&gt;
Gerrit-Reviewer: Michael Burns <mburns(a)redhat.com&gt;

Change in vdsm[master]: BZ#832199: move selinux from init to spec

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: BZ#832199: move selinux from init to spec
......................................................................


Patch Set 4: I would prefer that you didn't submit this

(2 inline comments)

very nice idea, but the complexity seems horrific to me. would you consider my comments?

....................................................
File vdsm.spec.in
Line 385: virtNFS=$(/usr/sbin/semanage boolean -l | grep virt_use_nfs | cut -d ','
-f 2)
are you sure this hack is not even slower?

I'd be fine with running

 if /usr/sbin/semanage boolean -l | /usr/bin/grep -q 'virt_use_nfs                  
(off'

which would be quicker, and almost-as-good as a heuristic.

Line 444:     virtNFS=$(/usr/sbin/semanage boolean -l | grep virt_use_nfs | cut -d
',' -f 2)
I do not see why we need the tests here. no one has complained about slowliness in the
last removal of vdsm.

please avoid this complexity if possible.

--
To view, visit http://gerrit.ovirt.org/5600
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id515ddb96cbfb4f3a936336b3f7e261658df662a
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com&gt;
Gerrit-Reviewer: Adam Litke <agl(a)us.ibm.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com&gt;
Gerrit-Reviewer: Mark Wu <wudxw(a)linux.vnet.ibm.com&gt;
Gerrit-Reviewer: Michael Burns <mburns(a)redhat.com&gt;

Change in vdsm[master]: BZ#832199: move selinux from init to spec

[Douglas Schilling Landgraf]

Douglas Schilling Landgraf has posted comments on this change.

Change subject: BZ#832199: move selinux from init to spec
......................................................................


Patch Set 4: Verified

--
To view, visit http://gerrit.ovirt.org/5600
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id515ddb96cbfb4f3a936336b3f7e261658df662a
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com&gt;
Gerrit-Reviewer: Adam Litke <agl(a)us.ibm.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com&gt;
Gerrit-Reviewer: Mark Wu <wudxw(a)linux.vnet.ibm.com&gt;
Gerrit-Reviewer: Michael Burns <mburns(a)redhat.com&gt;

Change in vdsm[master]: BZ#832199: move selinux from init to spec

[Douglas Schilling Landgraf]

Douglas Schilling Landgraf has posted comments on this change.

Change subject: BZ#832199: move selinux from init to spec
......................................................................


Patch Set 3: I would prefer that you didn't submit this

I am preparing a new version

--
To view, visit http://gerrit.ovirt.org/5600
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id515ddb96cbfb4f3a936336b3f7e261658df662a
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com&gt;
Gerrit-Reviewer: Adam Litke <agl(a)us.ibm.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com&gt;
Gerrit-Reviewer: Mark Wu <wudxw(a)linux.vnet.ibm.com&gt;
Gerrit-Reviewer: Michael Burns <mburns(a)redhat.com&gt;

Change in vdsm[master]: BZ#832199: move selinux from init to spec

[Douglas Schilling Landgraf]

Douglas Schilling Landgraf has posted comments on this change.

Change subject: BZ#832199: move selinux from init to spec
......................................................................


Patch Set 3:

I will wait the ACK/merge here to update the branch ovirt 3.1 (Patch:
http://gerrit.ovirt.org/#/c/5614/ )

--
To view, visit http://gerrit.ovirt.org/5600
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id515ddb96cbfb4f3a936336b3f7e261658df662a
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com&gt;
Gerrit-Reviewer: Adam Litke <agl(a)us.ibm.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com&gt;
Gerrit-Reviewer: Mark Wu <wudxw(a)linux.vnet.ibm.com&gt;
Gerrit-Reviewer: Michael Burns <mburns(a)redhat.com&gt;

Change in vdsm[master]: BZ#832199: move selinux from init to spec

[Douglas Schilling Landgraf]

Douglas Schilling Landgraf has posted comments on this change.

Change subject: BZ#832199: move selinux from init to spec
......................................................................


Patch Set 3: Verified

--
To view, visit http://gerrit.ovirt.org/5600
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id515ddb96cbfb4f3a936336b3f7e261658df662a
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com&gt;
Gerrit-Reviewer: Adam Litke <agl(a)us.ibm.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com&gt;
Gerrit-Reviewer: Mark Wu <wudxw(a)linux.vnet.ibm.com&gt;
Gerrit-Reviewer: Michael Burns <mburns(a)redhat.com&gt;

Mark Wu has posted comments on this change.

Change subject: BZ#832199: selinux - move selinux from init to spec
......................................................................


Patch Set 2:

I suggest using "semanage boolean -l" to check if the booleans are already set
in policy and only set them on unset before. That could make developer feel better.

--
To view, visit http://gerrit.ovirt.org/5600
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id515ddb96cbfb4f3a936336b3f7e261658df662a
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com&gt;
Gerrit-Reviewer: Adam Litke <agl(a)us.ibm.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com&gt;
Gerrit-Reviewer: Mark Wu <wudxw(a)linux.vnet.ibm.com&gt;
Gerrit-Reviewer: Michael Burns <mburns(a)redhat.com&gt;

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: BZ#832199: selinux - move selinux from init to spec
......................................................................


Patch Set 2: I would prefer that you didn't submit this

I have to take my words back.

I wanted to verify this patch, and noticed that semanage is unbearably slow. If I take it,
all the developers (including me) would like to kill me. Could you limit semanage to cases
where is needed (policy is not yet set)?

--
To view, visit http://gerrit.ovirt.org/5600
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id515ddb96cbfb4f3a936336b3f7e261658df662a
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com&gt;
Gerrit-Reviewer: Adam Litke <agl(a)us.ibm.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com&gt;
Gerrit-Reviewer: Michael Burns <mburns(a)redhat.com&gt;

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: BZ#832199: selinux - move selinux from init to spec
......................................................................


Patch Set 2: Looks good to me, approved

--
To view, visit http://gerrit.ovirt.org/5600
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id515ddb96cbfb4f3a936336b3f7e261658df662a
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com&gt;
Gerrit-Reviewer: Adam Litke <agl(a)us.ibm.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com&gt;
Gerrit-Reviewer: Michael Burns <mburns(a)redhat.com&gt;

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: BZ#832199: selinux - move selinux from init to spec
......................................................................


Patch Set 1: Looks good to me, approved

(1 inline comment)

Since we have Mike's ack, I'm good with this.

....................................................
File vdsm.spec.in
Line 426: virt_use_sanlock=0
"oops" since this was forgotten when "virt_use_sanlock" was recently
added. your patch is fine.

--
To view, visit http://gerrit.ovirt.org/5600
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id515ddb96cbfb4f3a936336b3f7e261658df662a
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com&gt;
Gerrit-Reviewer: Adam Litke <agl(a)us.ibm.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com&gt;
Gerrit-Reviewer: Michael Burns <mburns(a)redhat.com&gt;

Adam Litke has posted comments on this change.

Change subject: BZ#832199: selinux - move selinux from init to spec
......................................................................


Patch Set 1: (1 inline comment)

Looks fine once you fix the indentation error that Dan pointed out.

....................................................
File vdsm.spec.in
Line 426: virt_use_sanlock=0
I don't get it either.  Looks ok to me.

--
To view, visit http://gerrit.ovirt.org/5600
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id515ddb96cbfb4f3a936336b3f7e261658df662a
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com&gt;
Gerrit-Reviewer: Adam Litke <agl(a)us.ibm.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com&gt;
Gerrit-Reviewer: Michael Burns <mburns(a)redhat.com&gt;

[Douglas Schilling Landgraf]

Douglas Schilling Landgraf has posted comments on this change.

Change subject: BZ#832199: selinux - move selinux from init to spec
......................................................................


Patch Set 1: (2 inline comments)

....................................................
File vdsm.spec.in
Line 379:     /usr/sbin/semanage boolean -m -S targeted -F /dev/stdin  << _EOF
agreed.

Line 426: virt_use_sanlock=0
oops? Sorry, I didn't get that. :-(

--
To view, visit http://gerrit.ovirt.org/5600
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id515ddb96cbfb4f3a936336b3f7e261658df662a
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com&gt;
Gerrit-Reviewer: Adam Litke <agl(a)us.ibm.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com&gt;
Gerrit-Reviewer: Michael Burns <mburns(a)redhat.com&gt;

Michael Burns has posted comments on this change.

Change subject: BZ#832199: selinux - move selinux from init to spec
......................................................................


Patch Set 1:

I don't see a reason that this change would cause problems in this case.  The only
possible issue I see is that this might cause problems with some packaging guidelines,
though I don't see it in Fedora's guidelines.

--
To view, visit http://gerrit.ovirt.org/5600
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id515ddb96cbfb4f3a936336b3f7e261658df662a
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com&gt;
Gerrit-Reviewer: Adam Litke <agl(a)us.ibm.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Michael Burns <mburns(a)redhat.com&gt;

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: BZ#832199: selinux - move selinux from init to spec
......................................................................


Patch Set 1: (2 inline comments)

....................................................
File vdsm.spec.in
Line 379:     /usr/sbin/semanage boolean -m -S targeted -F /dev/stdin  << _EOF
needless indentation

Line 426: virt_use_sanlock=0
oops

--
To view, visit http://gerrit.ovirt.org/5600
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id515ddb96cbfb4f3a936336b3f7e261658df662a
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com&gt;
Gerrit-Reviewer: Adam Litke <agl(a)us.ibm.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Michael Burns <mburns(a)redhat.com&gt;

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: BZ#832199: selinux - move selinux from init to spec
......................................................................


Patch Set 1:

few years ago, vdsm was asked not to touch host configuration before it is explicitly
started (see for example https://bugzilla.redhat.com/show_bug.cgi?id=627661 ).

things may have changed since, and this solves an annoying issue for us, but I would have
to ask Mike Burns about the implications on ovirt-node

--
To view, visit http://gerrit.ovirt.org/5600
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id515ddb96cbfb4f3a936336b3f7e261658df662a
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com&gt;
Gerrit-Reviewer: Adam Litke <agl(a)us.ibm.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Michael Burns <mburns(a)redhat.com&gt;