Change in vdsm[ovirt-3.4]: vm iface stats: fix arithmetic

[Dan Kenigsberg]

Dan Kenigsberg has uploaded a new change for review.

Change subject: vm iface stats: fix arithmetic
......................................................................

vm iface stats: fix arithmetic

My commit 672ff43 has a serious arithmetic flaw: the modulu must be
taken on the sample difference!

Bug-Url: https://bugzilla.redhat.com/1062166
Change-Id: Ie356d5f96c73b65925b38f6149d5eb36f43023ad
Signed-off-by: Dan Kenigsberg 
Reviewed-on: http://gerrit.ovirt.org/25960
Reviewed-by: Antoni Segura Puimedon 
Tested-by: Martin Pavlik 
(cherry picked from commit d0c9357bbf6b6c61dc633edba6691a53b592e895)
---
M vdsm/vm.py
1 file changed, 4 insertions(+), 4 deletions(-)

git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/88/26088/1

diff --git a/vdsm/vm.py b/vdsm/vm.py
index 0db8466..832bca8 100644
--- a/vdsm/vm.py
+++ b/vdsm/vm.py
@@ -609,12 +609,12 @@
                 ifStats['txDropped'] = str(eInfo[nic.name][7])

ifRxBytes = (100.0 *
-                             (eInfo[nic.name][0] - sInfo[nic.name][0]) %
-                             2 ** 32 /
+                             ((eInfo[nic.name][0] - sInfo[nic.name][0]) %
+                              2 ** 32) /
                              sampleInterval / ifSpeed / self.MBPS_TO_BPS)
                 ifTxBytes = (100.0 *
-                             (eInfo[nic.name][4] - sInfo[nic.name][4]) %
-                             2 ** 32 /
+                             ((eInfo[nic.name][4] - sInfo[nic.name][4]) %
+                              2 ** 32) /
                              sampleInterval / ifSpeed / self.MBPS_TO_BPS)

ifStats['rxRate'] = '%.1f' % ifRxBytes

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: vm iface stats: fix arithmetic
......................................................................

Patch Set 1: Verified+1

vdsClient -s 0 getAllVmStats|grep netw

reports network statistics

Antoni Segura Puimedon has posted comments on this change.

Change subject: vm iface stats: fix arithmetic
......................................................................

Patch Set 1: Code-Review+1

Yaniv Bronhaim has posted comments on this change.

Change subject: vm iface stats: fix arithmetic
......................................................................

Patch Set 1: Code-Review+2

Yaniv Bronhaim has submitted this change and it was merged.

Change subject: vm iface stats: fix arithmetic
......................................................................

vm iface stats: fix arithmetic

My commit 672ff43 has a serious arithmetic flaw: the modulu must be
taken on the sample difference!

Bug-Url: https://bugzilla.redhat.com/1062166
Change-Id: Ie356d5f96c73b65925b38f6149d5eb36f43023ad
Signed-off-by: Dan Kenigsberg 
Reviewed-on: http://gerrit.ovirt.org/25960
Reviewed-by: Antoni Segura Puimedon 
Tested-by: Martin Pavlik 
(cherry picked from commit d0c9357bbf6b6c61dc633edba6691a53b592e895)
Reviewed-on: http://gerrit.ovirt.org/26088
Reviewed-by: Yaniv Bronhaim 
---
M vdsm/vm.py
1 file changed, 4 insertions(+), 4 deletions(-)

Approvals:
  Yaniv Bronhaim: Looks good to me, approved
  Antoni Segura Puimedon: Looks good to me, but someone else must approve
  Dan Kenigsberg: Verified