Change in vdsm[master]: check-merged: adding virtTests

[Code Review]

From Yaniv Bronhaim :

Yaniv Bronhaim has uploaded a new change for review.

Change subject: check-merged: adding virtTests
......................................................................

check-merged: adding virtTests

Change-Id: Ibdd67ff59beb20a13c187087e9cfa148ba705eb6
Signed-off-by: Yaniv Bronhaim 
---
M automation/check-merged.sh
1 file changed, 19 insertions(+), 1 deletion(-)

git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/37/70837/1

diff --git a/automation/check-merged.sh b/automation/check-merged.sh
index e6933b9..c913610 100755
--- a/automation/check-merged.sh
+++ b/automation/check-merged.sh
@@ -65,6 +65,20 @@
     return $res
 }

+function run_virt_tests {
+    local res=0
+    lago shell "$VM_NAME" -c \
+        " \
+            cd /usr/share/vdsm/tests
+            ./run_tests.sh \
+                --with-xunit \
+                --xunit-file=/tmp/nosetests-${DISTRO}.xml \
+                -s \
+                functional/virtTests.py \
+        " || res=$?
+    return $res
+}
+
 function run_network_tests {
     local res=0
     lago shell "$VM_NAME" -c \
@@ -113,9 +127,13 @@

function run_all_tests {
     run_infra_tests | tee "$EXPORTS/functional_tests_stdout.$DISTRO.log"
-    failed="${PIPESTATUS[0]}"
+    local failed="${PIPESTATUS[0]}"

run_network_tests | tee -a "$EXPORTS/functional_tests_stdout.$DISTRO.log"
+    local res="${PIPESTATUS[0]}"
+    [ "$res" -ne 0 ] && failed="$res"
+
+    run_virt_tests | tee -a "$EXPORTS/functional_tests_stdout.$DISTRO.log"
     res="${PIPESTATUS[0]}"
     [ "$res" -ne 0 ] && failed="$res"
 }

[Code Review]

From Yaniv Bronhaim :

Yaniv Bronhaim has posted comments on this change.

Change subject: check-merged: adding virtTests
......................................................................

Patch Set 2:

http://jenkins.ovirt.org/job/vdsm_master_check-merged-el7-x86_64/

[Code Review]

From Yaniv Bronhaim :

Yaniv Bronhaim has posted comments on this change.

Change subject: check-merged: adding virtTests
......................................................................

Patch Set 2:

Please virt guys, try to fix or remove this dead code

OK (SKIP=2)
functional.virtTests.VirtTest
    testComplexVm                                               FAIL
    testHeadlessVm                                              FAIL
    testSimpleVm                                                FAIL
    testVmDefinitionGraphics('spice')                           FAIL
    testVmDefinitionGraphics('vnc')                             FAIL
    testVmDefinitionMultipleGraphics('spice', 'vnc')            FAIL
    testVmDefinitionMultipleGraphics('vnc', 'spice')            FAIL
    testVmWithCdrom('self')                                     FAIL
    testVmWithCdrom('specParams')                               FAIL
    testVmWithCdrom('vmPayload')                                FAIL
    testVmWithDevice('hotplugDisk')                             FAIL
    testVmWithDevice('hotplugNic')                              FAIL
    testVmWithDevice('smartcard')                               FAIL
    testVmWithDevice('virtioNic')                               FAIL
    testVmWithDevice('virtioRng')                               FAIL
    testVmWithSla                                               FAIL

[Code Review]

From Yaniv Bronhaim :

Yaniv Bronhaim has posted comments on this change.

Change subject: check-merged: adding virtTests
......................................................................

Patch Set 2:

Hi Martin, Thanks for replying - you can have all the output in http://jenkins.ovirt.org/job/vdsm_master_check-merged-el7-x86_64/ - and its easy to trigger it if needed

[Code Review]

From Yaniv Bronhaim :

Yaniv Bronhaim has posted comments on this change.

Change subject: check-merged: adding virtTests
......................................................................

Patch Set 2:

this is a bug that those functional just caught if what you say is true  - if virtlogd is not up, it means that vdsmd should be depend on that, if libvirt does not require that. weird that libvirtd doesn't take care of it.. you can check in your tests for service status - those are vdsm functional tests, the environment can be modified as you like to perform your tests

[Code Review]

From Yaniv Bronhaim :

Yaniv Bronhaim has posted comments on this change.

Change subject: check-merged: adding virtTests
......................................................................

Patch Set 2:

so this should be added exactly where this patch touches, in check-merged.sh or in automation/delpoy.sh ..

[Code Review]

From Yaniv Bronhaim :

Yaniv Bronhaim has abandoned this change.

Change subject: check-merged: adding virtTests
......................................................................

Abandoned