Martin Polednik has uploaded a new change for review.
Change subject: caps: return kernelArgs ......................................................................
caps: return kernelArgs
989a73f5 accidentaly removed kernelArgs from caps with a bad rebase. We still want to report it.
Change-Id: I5520a6d19a784024804df1e4c29532a89e02a31a Signed-off-by: Martin Polednik mpolednik@redhat.com --- M vdsm/caps.py 1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/98/65798/1
diff --git a/vdsm/caps.py b/vdsm/caps.py index b919c1b..1fe20f3 100644 --- a/vdsm/caps.py +++ b/vdsm/caps.py @@ -169,6 +169,7 @@ caps['uuid'] = host.uuid() caps['packages2'] = osinfo.package_versions() caps['realtimeKernel'] = osinfo.runtime_kernel_flags().realtime + caps['kernelArgs'] = osinfo.kernel_args() caps['nestedVirtualization'] = osinfo.nested_virtualization().enabled caps['emulatedMachines'] = machinetype.emulated_machines( cpuarch.effective())
gerrit-hooks has posted comments on this change.
Change subject: caps: return kernelArgs ......................................................................
Patch Set 1:
* Update Tracker::IGNORE, no bug url/s found * Check Bug-Url::IGNORE, no bug url/s found * Check Public Bug::WARN, no public bug url found * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0'])
Francesco Romani has posted comments on this change.
Change subject: caps: return kernelArgs ......................................................................
Patch Set 1: Code-Review+2
this means we should improve our automated tests to catch those errors.
Martin Polednik has posted comments on this change.
Change subject: caps: return kernelArgs ......................................................................
Patch Set 1: Verified+1
I fully agree... we definitely need some "complex caps test"...
Dan Kenigsberg has submitted this change and it was merged.
Change subject: caps: return kernelArgs ......................................................................
caps: return kernelArgs
989a73f5 accidentaly removed kernelArgs from caps with a bad rebase. We still want to report it.
Change-Id: I5520a6d19a784024804df1e4c29532a89e02a31a Signed-off-by: Martin Polednik mpolednik@redhat.com Reviewed-on: https://gerrit.ovirt.org/65798 Reviewed-by: Francesco Romani fromani@redhat.com Continuous-Integration: Jenkins CI --- M vdsm/caps.py 1 file changed, 1 insertion(+), 0 deletions(-)
Approvals: Jenkins CI: Passed CI tests Francesco Romani: Looks good to me, approved Martin Polednik: Verified
gerrit-hooks has posted comments on this change.
Change subject: caps: return kernelArgs ......................................................................
Patch Set 2:
* update_tracker: OK * Set MODIFIED::IGNORE, no Bug-Url found.
vdsm-patches@lists.fedorahosted.org