Douglas Schilling Landgraf has uploaded a new change for review.
Change subject: vdsm.spec: increase policycoreutils version for RHEL ......................................................................
vdsm.spec: increase policycoreutils version for RHEL
Due bz#893065 if selinux is disable vdsm package can not be installed on RHEL systems.
Change-Id: Ib2b40781e4e6bba28ac5ebcf54ff089bad09e36d Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=903309 Signed-off-by: Douglas Schilling Landgraf dougsland@redhat.com --- M vdsm.spec.in 1 file changed, 4 insertions(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/41/11341/1
diff --git a/vdsm.spec.in b/vdsm.spec.in index 632d315..aef89ba 100644 --- a/vdsm.spec.in +++ b/vdsm.spec.in @@ -93,6 +93,7 @@ Requires: libvirt Requires: lvm2 Requires: python +Requires: policycoreutils-python Requires: qemu-kvm Requires: qemu-kvm-img Requires: sanlock, sanlock-python @@ -110,6 +111,8 @@ Requires: sanlock >= 2.3-4, sanlock-python Requires: initscripts >= 9.03.31-2.el6_3.1 Requires: mom >= 0.3.0 +Requires: policycoreutils >= 2.0.83-19.30 +Requires: policycoreutils-python >= 2.0.83-19.30 Requires: selinux-policy-targeted >= 3.7.19-155 Requires: lvm2 >= 2.02.95-10.el6_3.2 Requires: logrotate < 3.8.0 @@ -126,6 +129,7 @@ Requires: kernel >= 3.6 Requires: mom >= 0.3.0 Requires: sanlock >= 2.4-2, sanlock-python +Requires: policycoreutils-python Requires: sed >= 4.2.1-10 Requires: selinux-policy-targeted >= 3.10.0-149 Requires: lvm2 >= 2.02.95 @@ -144,7 +148,6 @@ Requires: sos Requires: tree Requires: dosfstools -Requires: policycoreutils-python Requires: genisoimage Requires: libselinux-python Requires: %{name}-python = %{version}-%{release}
-- To view, visit http://gerrit.ovirt.org/11341 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange Gerrit-Change-Id: Ib2b40781e4e6bba28ac5ebcf54ff089bad09e36d Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf dougsland@redhat.com
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsm.spec: increase policycoreutils version for RHEL ......................................................................
Patch Set 1:
Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/915/ (3/3)
-- To view, visit http://gerrit.ovirt.org/11341 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ib2b40781e4e6bba28ac5ebcf54ff089bad09e36d Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsm.spec: increase policycoreutils version for RHEL ......................................................................
Patch Set 1:
Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/23/ (1/3)
-- To view, visit http://gerrit.ovirt.org/11341 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ib2b40781e4e6bba28ac5ebcf54ff089bad09e36d Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsm.spec: increase policycoreutils version for RHEL ......................................................................
Patch Set 1:
Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/880/ (2/3)
-- To view, visit http://gerrit.ovirt.org/11341 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ib2b40781e4e6bba28ac5ebcf54ff089bad09e36d Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
Douglas Schilling Landgraf has posted comments on this change.
Change subject: vdsm.spec: increase policycoreutils version for RHEL ......................................................................
Patch Set 1: Verified
-- To view, visit http://gerrit.ovirt.org/11341 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ib2b40781e4e6bba28ac5ebcf54ff089bad09e36d Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Mark Wu wudxw@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsm.spec: increase policycoreutils version for RHEL ......................................................................
Patch Set 1: Fails
Build Failed
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/880/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/915/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/23/ : FAILURE
-- To view, visit http://gerrit.ovirt.org/11341 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ib2b40781e4e6bba28ac5ebcf54ff089bad09e36d Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Mark Wu wudxw@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server
Mark Wu has posted comments on this change.
Change subject: vdsm.spec: increase policycoreutils version for RHEL ......................................................................
Patch Set 1: I would prefer that you didn't submit this
(2 inline comments)
.................................................... File vdsm.spec.in Line 110: Requires: kernel >= 2.6.32-279.9.1 Line 111: Requires: sanlock >= 2.3-4, sanlock-python Line 112: Requires: initscripts >= 9.03.31-2.el6_3.1 Line 113: Requires: mom >= 0.3.0 Line 114: Requires: policycoreutils >= 2.0.83-19.30 it's required by policycoreutils-python, so we don't need explicitly require it by ourselves. Line 115: Requires: policycoreutils-python >= 2.0.83-19.30 Line 116: Requires: selinux-policy-targeted >= 3.7.19-155 Line 117: Requires: lvm2 >= 2.02.95-10.el6_3.2 Line 118: Requires: logrotate < 3.8.0
Line 128: Requires: e2fsprogs >= 1.41.14 Line 129: Requires: kernel >= 3.6 Line 130: Requires: mom >= 0.3.0 Line 131: Requires: sanlock >= 2.4-2, sanlock-python Line 132: Requires: policycoreutils-python after checking the repo metadata, I found it should be installed by default, but not mandatory. Do we need require it? Line 133: Requires: sed >= 4.2.1-10 Line 134: Requires: selinux-policy-targeted >= 3.10.0-149 Line 135: Requires: lvm2 >= 2.02.95 Line 136: %endif
-- To view, visit http://gerrit.ovirt.org/11341 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ib2b40781e4e6bba28ac5ebcf54ff089bad09e36d Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Mark Wu wudxw@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server
Zhou Zheng Sheng has posted comments on this change.
Change subject: vdsm.spec: increase policycoreutils version for RHEL ......................................................................
Patch Set 1: (2 inline comments)
.................................................... File vdsm.spec.in Line 110: Requires: kernel >= 2.6.32-279.9.1 Line 111: Requires: sanlock >= 2.3-4, sanlock-python Line 112: Requires: initscripts >= 9.03.31-2.el6_3.1 Line 113: Requires: mom >= 0.3.0 Line 114: Requires: policycoreutils >= 2.0.83-19.30 ./vdsm/vdsmd.init.in and ./vdsm/vdsm-gencerts.sh invoke /sbin/restorecon which is in policycoreutils . So it's OK we require policycoreutils.
When A is required by B, and if we are depend on both A and B, we should require both of them in the spec file. Otherwise, when someone update the code and it does not require B any more and removes the requirement of B in the spec, after that we lose the implicit requirement of A in the spec, but the code continues to use the modules in A. Relying on implicit dependency in the spec while explicit dependency existing in the code is error prone. Line 115: Requires: policycoreutils-python >= 2.0.83-19.30 Line 116: Requires: selinux-policy-targeted >= 3.7.19-155 Line 117: Requires: lvm2 >= 2.02.95-10.el6_3.2 Line 118: Requires: logrotate < 3.8.0
Line 128: Requires: e2fsprogs >= 1.41.14 Line 129: Requires: kernel >= 3.6 Line 130: Requires: mom >= 0.3.0 Line 131: Requires: sanlock >= 2.4-2, sanlock-python Line 132: Requires: policycoreutils-python What if the user just happened to remove policycoreutils-python ?
Some packages are installed by default in Fedora and RHEL, but if we are porting VDSM to another non-RH-based distro, or to a custom distro, or someone decide to make a very small distro just enough to run VDSM, the requirements in the spec will be very helpful. Line 133: Requires: sed >= 4.2.1-10 Line 134: Requires: selinux-policy-targeted >= 3.10.0-149 Line 135: Requires: lvm2 >= 2.02.95 Line 136: %endif
-- To view, visit http://gerrit.ovirt.org/11341 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ib2b40781e4e6bba28ac5ebcf54ff089bad09e36d Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Mark Wu wudxw@linux.vnet.ibm.com Gerrit-Reviewer: Zhou Zheng Sheng zhshzhou@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server
Douglas Schilling Landgraf has posted comments on this change.
Change subject: vdsm.spec: increase policycoreutils version for RHEL ......................................................................
Patch Set 1: (2 inline comments)
.................................................... File vdsm.spec.in Line 110: Requires: kernel >= 2.6.32-279.9.1 Line 111: Requires: sanlock >= 2.3-4, sanlock-python Line 112: Requires: initscripts >= 9.03.31-2.el6_3.1 Line 113: Requires: mom >= 0.3.0 Line 114: Requires: policycoreutils >= 2.0.83-19.30 agreed with Zhou. Line 115: Requires: policycoreutils-python >= 2.0.83-19.30 Line 116: Requires: selinux-policy-targeted >= 3.7.19-155 Line 117: Requires: lvm2 >= 2.02.95-10.el6_3.2 Line 118: Requires: logrotate < 3.8.0
Line 128: Requires: e2fsprogs >= 1.41.14 Line 129: Requires: kernel >= 3.6 Line 130: Requires: mom >= 0.3.0 Line 131: Requires: sanlock >= 2.4-2, sanlock-python Line 132: Requires: policycoreutils-python agreed with Zhou. Line 133: Requires: sed >= 4.2.1-10 Line 134: Requires: selinux-policy-targeted >= 3.10.0-149 Line 135: Requires: lvm2 >= 2.02.95 Line 136: %endif
-- To view, visit http://gerrit.ovirt.org/11341 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ib2b40781e4e6bba28ac5ebcf54ff089bad09e36d Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Mark Wu wudxw@linux.vnet.ibm.com Gerrit-Reviewer: Zhou Zheng Sheng zhshzhou@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server
Mark Wu has posted comments on this change.
Change subject: vdsm.spec: increase policycoreutils version for RHEL ......................................................................
Patch Set 1: Looks good to me, but someone else must approve
(1 inline comment)
.................................................... File vdsm.spec.in Line 110: Requires: kernel >= 2.6.32-279.9.1 Line 111: Requires: sanlock >= 2.3-4, sanlock-python Line 112: Requires: initscripts >= 9.03.31-2.el6_3.1 Line 113: Requires: mom >= 0.3.0 Line 114: Requires: policycoreutils >= 2.0.83-19.30 policycoreutils is mandatory, which means it must be included in the possible minimal installation. But as you said in line132, it could be removed later. Now I am convinced by you. Line 115: Requires: policycoreutils-python >= 2.0.83-19.30 Line 116: Requires: selinux-policy-targeted >= 3.7.19-155 Line 117: Requires: lvm2 >= 2.02.95-10.el6_3.2 Line 118: Requires: logrotate < 3.8.0
-- To view, visit http://gerrit.ovirt.org/11341 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ib2b40781e4e6bba28ac5ebcf54ff089bad09e36d Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Mark Wu wudxw@linux.vnet.ibm.com Gerrit-Reviewer: Zhou Zheng Sheng zhshzhou@linux.vnet.ibm.com
Dan Kenigsberg has posted comments on this change.
Change subject: vdsm.spec: increase policycoreutils version for RHEL ......................................................................
Patch Set 1: I would prefer that you didn't submit this
This patch may introduce problems until el6.4 is released. Marking with -1 until then.
-- To view, visit http://gerrit.ovirt.org/11341 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ib2b40781e4e6bba28ac5ebcf54ff089bad09e36d Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Mark Wu wudxw@linux.vnet.ibm.com Gerrit-Reviewer: Zhou Zheng Sheng zhshzhou@linux.vnet.ibm.com
Douglas Schilling Landgraf has posted comments on this change.
Change subject: vdsm.spec: increase policycoreutils version for RHEL ......................................................................
Patch Set 1:
time to take?
-- To view, visit http://gerrit.ovirt.org/11341 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ib2b40781e4e6bba28ac5ebcf54ff089bad09e36d Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Mark Wu wudxw@linux.vnet.ibm.com Gerrit-Reviewer: Zhou Zheng Sheng zhshzhou@linux.vnet.ibm.com
Dan Kenigsberg has posted comments on this change.
Change subject: vdsm.spec: increase policycoreutils version for RHEL ......................................................................
Patch Set 1: Looks good to me, approved
-- To view, visit http://gerrit.ovirt.org/11341 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ib2b40781e4e6bba28ac5ebcf54ff089bad09e36d Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Mark Wu wudxw@linux.vnet.ibm.com Gerrit-Reviewer: Zhou Zheng Sheng zhshzhou@linux.vnet.ibm.com
Dan Kenigsberg has submitted this change and it was merged.
Change subject: vdsm.spec: increase policycoreutils version for RHEL ......................................................................
vdsm.spec: increase policycoreutils version for RHEL
Due bz#893065 if selinux is disable vdsm package can not be installed on RHEL systems.
Change-Id: Ib2b40781e4e6bba28ac5ebcf54ff089bad09e36d Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=903309 Signed-off-by: Douglas Schilling Landgraf dougsland@redhat.com --- M vdsm.spec.in 1 file changed, 4 insertions(+), 1 deletion(-)
Approvals: Douglas Schilling Landgraf: Verified Mark Wu: Looks good to me, but someone else must approve Dan Kenigsberg: Looks good to me, approved
-- To view, visit http://gerrit.ovirt.org/11341 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged Gerrit-Change-Id: Ib2b40781e4e6bba28ac5ebcf54ff089bad09e36d Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Mark Wu wudxw@linux.vnet.ibm.com Gerrit-Reviewer: Zhou Zheng Sheng zhshzhou@linux.vnet.ibm.com
vdsm-patches@lists.fedorahosted.org