[NEW PATCH] BZ#738355 guestIF: log exception before initialization of 'line' (via gerrit-bot)

[Dan Kenigsberg]

New patch submitted by Dan Kenigsberg ([e-mail])

You can review this change at: http://gerrit.usersys.redhat.com/936

commit 95774a75e95fedbf80a5a9f35c496ad7da060b1e
Author: David Naori 
Date:   Wed Sep 14 21:26:43 2011 +0300

BZ#738355 guestIF: log exception before initialization of 'line'

Change-Id: I986c252afbd7e968dc3b42cbecd1a4180d875917

diff --git a/vdsm/guestIF.py b/vdsm/guestIF.py
index bd501b4..18930ac 100644
--- a/vdsm/guestIF.py
+++ b/vdsm/guestIF.py
@@ -253,6 +253,7 @@ class GuestAgent (threading.Thread):
             self._forward('refresh')
             self._buffer = ''
             while not self._stopped:
+                line = None
                 try:
                     line = self._readLine()
                     # line is always None after stop() is called and the

Change in vdsm[master]: BZ#738355 guestIF: log exception before initialization of 'l...

Gal Hammer has posted comments on this change.

Change subject: BZ#738355 guestIF: log exception before initialization of 'line'
......................................................................

Patch Set 1: Looks good to me, but someone else must approve

--
To view, visit http://gerrit.usersys.redhat.com/936
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I986c252afbd7e968dc3b42cbecd1a4180d875917
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg 
Gerrit-Reviewer: David Naori 
Gerrit-Reviewer: Gal Hammer

Change in vdsm[master]: BZ#738355 BZ#736422 guestIF: log exception before initializa...

Gal Hammer has posted comments on this change.

Change subject: BZ#738355 BZ#736422 guestIF: log exception before initialization of 'line'
......................................................................

Patch Set 2: Looks good to me, but someone else must approve

--
To view, visit http://gerrit.usersys.redhat.com/936
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I986c252afbd7e968dc3b42cbecd1a4180d875917
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: David Naori 
Gerrit-Reviewer: Gal Hammer

Change in vdsm[master]: BZ#738355 BZ#736422 guestIF: log exception before initializa...

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: BZ#738355 BZ#736422 guestIF: log exception before initialization of 'line'
......................................................................

Patch Set 2: Looks good to me, approved

--
To view, visit http://gerrit.usersys.redhat.com/936
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I986c252afbd7e968dc3b42cbecd1a4180d875917
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: David Naori 
Gerrit-Reviewer: Gal Hammer

Change in vdsm[master]: BZ#738355 BZ#736422 guestIF: log exception before initializa...

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: BZ#738355 BZ#736422 guestIF: log exception before initialization of 'line'
......................................................................

Patch Set 2: Verified

verified by David

--
To view, visit http://gerrit.usersys.redhat.com/936
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I986c252afbd7e968dc3b42cbecd1a4180d875917
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: David Naori 
Gerrit-Reviewer: Gal Hammer

Change in vdsm[master]: BZ#738355 BZ#736422 guestIF: log exception before initializa...

[Dan Kenigsberg]

Dan Kenigsberg has submitted this change and it was merged.

Change subject: BZ#738355 BZ#736422 guestIF: log exception before initialization of 'line'
......................................................................

BZ#738355 BZ#736422 guestIF: log exception before initialization of 'line'

Change-Id: I986c252afbd7e968dc3b42cbecd1a4180d875917
---
M vdsm/guestIF.py
1 file changed, 1 insertion(+), 0 deletions(-)

Approvals:
  Dan Kenigsberg: Verified; Looks good to me, approved
  Gal Hammer: Looks good to me, but someone else must approve

--
To view, visit http://gerrit.usersys.redhat.com/936
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I986c252afbd7e968dc3b42cbecd1a4180d875917
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: David Naori 
Gerrit-Reviewer: Gal Hammer