[NEW PATCH] Remove check for incoming migration in _highWrite (via gerrit-bot)

[Federico Simoncelli]

New patch submitted by Federico Simoncelli ([e-mail])

You can review this change at: http://gerrit.usersys.redhat.com/706

commit e6a428e85ab03c1e7126eef65872c70e16020f07
Author: Federico Simoncelli 
Date:   Wed Jul 13 16:25:04 2011 +0000

Remove check for incoming migration in _highWrite

Change-Id: I1c27d429b1c610a5a2d6d1c5b342e0564673c315

diff --git a/vdsm/libvirtvm.py b/vdsm/libvirtvm.py
index 40567a5..bf27692 100644
--- a/vdsm/libvirtvm.py
+++ b/vdsm/libvirtvm.py
@@ -52,9 +52,6 @@ class VmStatsThread(utils.AdvancedStatsThread):
                             self.sampleCpu, self.sampleDisk, self.sampleNet)

def _highWrite(self):
-        if self._vm._incomingMigrationPending():
-            return
-
         for vmDrive in self._vm._drives:
             if vmDrive.blockDev and vmDrive.format == 'cow':
                 capacity, alloc, physical = \

Change in vdsm[master]: Remove check for incoming migration in _highWrite

[Federico Simoncelli]

Federico Simoncelli has posted comments on this change.

Change subject: Remove check for incoming migration in _highWrite
......................................................................

Patch Set 1: (3 inline comments)

....................................................
File vdsm/libvirtvm.py
Line 54:     def _highWrite(self):
Removing this check should be safe because we start the VmStatsThread when the migration is finished. See below.

Line 915:             self.log.debug(domxml)
If this is the migration destination we are exiting here and we don't execute _domDependentInit (the VmStatsThread starter).

Line 999:             hooks.after_vm_migrate_destination(self._dom.XMLDesc(0), self.conf)
The _domDependentInit (the VmStatsThread starter) is executed now when the migration is completed.

--
To view, visit http://gerrit.usersys.redhat.com/706
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1c27d429b1c610a5a2d6d1c5b342e0564673c315
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli

Change in vdsm[master]: Remove check for incoming migration in _highWrite

[Igor Lvovsky]

Igor Lvovsky has posted comments on this change.

Change subject: Remove check for incoming migration in _highWrite
......................................................................

Patch Set 1: Looks good to me, but someone else must approve

--
To view, visit http://gerrit.usersys.redhat.com/706
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1c27d429b1c610a5a2d6d1c5b342e0564673c315
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Igor Lvovsky

Change in vdsm[master]: Remove check for incoming migration in _highWrite

Saggi Mizrahi has posted comments on this change.

Change subject: Remove check for incoming migration in _highWrite
......................................................................

Patch Set 1: Looks good to me, but someone else must approve

Please have someone from preinteg ack this

--
To view, visit http://gerrit.usersys.redhat.com/706
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1c27d429b1c610a5a2d6d1c5b342e0564673c315
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Igor Lvovsky 
Gerrit-Reviewer: Saggi Mizrahi

Change in vdsm[master]: Remove check for incoming migration in _highWrite

[Igor Lvovsky]

Igor Lvovsky has posted comments on this change.

Change subject: Remove check for incoming migration in _highWrite
......................................................................

Patch Set 2: I would prefer that you didn't submit this

(1 inline comment)

....................................................
Commit Message
Line 7: Remove check for incoming migration in _highWrite
Can you please add a little explanationin the comment  why we don't need it any more?
Something like "We not start VM's stats thread untill the migration is finished"

--
To view, visit http://gerrit.usersys.redhat.com/706
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1c27d429b1c610a5a2d6d1c5b342e0564673c315
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Igor Lvovsky 
Gerrit-Reviewer: Saggi Mizrahi

Change in vdsm[master]: Remove check for incoming migration in _highWrite

[Igor Lvovsky]

Igor Lvovsky has posted comments on this change.

Change subject: Remove check for incoming migration in _highWrite
......................................................................

Patch Set 3: Looks good to me, but someone else must approve

--
To view, visit http://gerrit.usersys.redhat.com/706
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1c27d429b1c610a5a2d6d1c5b342e0564673c315
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Igor Lvovsky 
Gerrit-Reviewer: Saggi Mizrahi

Change in vdsm[master]: Remove check for incoming migration in _highWrite

[David Naori]

David Naori has posted comments on this change.

Change subject: Remove check for incoming migration in _highWrite
......................................................................

Patch Set 3: Verified

--
To view, visit http://gerrit.usersys.redhat.com/706
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1c27d429b1c610a5a2d6d1c5b342e0564673c315
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: David Naori 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Igor Lvovsky 
Gerrit-Reviewer: Saggi Mizrahi

Change in vdsm[master]: Remove check for incoming migration in _highWrite

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: Remove check for incoming migration in _highWrite
......................................................................

Patch Set 4: Verified; Looks good to me, approved

--
To view, visit http://gerrit.usersys.redhat.com/706
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1c27d429b1c610a5a2d6d1c5b342e0564673c315
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: David Naori 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Igor Lvovsky 
Gerrit-Reviewer: Saggi Mizrahi

Change in vdsm[master]: Remove check for incoming migration in _highWrite

[Dan Kenigsberg]

Dan Kenigsberg has submitted this change and it was merged.

Change subject: Remove check for incoming migration in _highWrite
......................................................................

Remove check for incoming migration in _highWrite

Change-Id: I1c27d429b1c610a5a2d6d1c5b342e0564673c315
---
M vdsm/libvirtvm.py
1 file changed, 0 insertions(+), 3 deletions(-)

Approvals:
  Dan Kenigsberg: Verified; Looks good to me, approved

--
To view, visit http://gerrit.usersys.redhat.com/706
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I1c27d429b1c610a5a2d6d1c5b342e0564673c315
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: David Naori 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Igor Lvovsky 
Gerrit-Reviewer: Saggi Mizrahi