From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: tests: Fix wrong usage of @broken_on_ci
......................................................................
tests: Fix wrong usage of @broken_on_ci
Both @brokentest and @broken_on_ci must be actually called. If they are
not called, the test is practically disabled and will never run.
The recommend usage is:
@broken_on_ci(msg="why this test is disabled on ci...")
def test_flaky(self):
...
Fixes commit b2ee97f30c9f (tests: Mark some scheduler tests as broken on
CI) to use @broken_on_ci() with a descriptive message.
Change-Id: Ia2f23c3facee68366a0eee8e8f858d29f3272977
Signed-off-by: Nir Soffer <nsoffer(a)redhat.com>
---
M tests/scheduleTests.py
1 file changed, 5 insertions(+), 4 deletions(-)
Approvals:
Nir Soffer: Verified
Jenkins CI: Passed CI tests
Dan Kenigsberg: Looks good to me, approved
Milan Zamazal: Looks good to me, but someone else must approve
--
To view, visit
https://gerrit.ovirt.org/67326
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia2f23c3facee68366a0eee8e8f858d29f3272977
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Milan Zamazal <mzamazal(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>