Change in vdsm[ovirt-3.6]: spec: install bonding-defaults.json with 644 permissions, no...

Ondřej Svoboda has uploaded a new change for review.

Change subject: spec: install bonding-defaults.json with 644 permissions, not 600
......................................................................

spec: install bonding-defaults.json with 644 permissions, not 600

This way make check succeeds under non-root account for
testIterNetworkHierarchy, testTextualRepr and testValidateBondingOptions
which previously failed to read the file.

Change-Id: I3090cb77c8b6329c4885c6dbd43b04998df20dfe
Signed-off-by: Ondřej Svoboda <osvoboda(a)redhat.com&gt;
Reviewed-on: https://gerrit.ovirt.org/46395
Continuous-Integration: Jenkins CI
Reviewed-by: Dan Kenigsberg <danken(a)redhat.com&gt;
---
M vdsm.spec.in
1 file changed, 2 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/01/46401/1

diff --git a/vdsm.spec.in b/vdsm.spec.in
index f000f63..8772640 100644
--- a/vdsm.spec.in
+++ b/vdsm.spec.in
@@ -1006,7 +1006,6 @@
 %dir %{_sysconfdir}/pki/%{vdsm_name}/certs
 %dir %{_sysconfdir}/pki/%{vdsm_name}/libvirt-spice
 %config(noreplace) %{_sysconfdir}/pki/%{vdsm_name}/keys/libvirt_password
-%{_localstatedir}/lib/%{vdsm_name}/bonding-defaults.json
 %dir %{_localstatedir}/lib/%{vdsm_name}
 %dir %{_localstatedir}/lib/%{vdsm_name}/netconfback
 %dir %{_localstatedir}/lib/%{vdsm_name}/persistence
@@ -1018,6 +1017,8 @@
 %dir %{_localstatedir}/run/%{vdsm_name}/v2v
 %dir %{_localstatedir}/log/%{vdsm_name}
 %dir %{_localstatedir}/log/%{vdsm_name}/backup
+%defattr(644, %{vdsm_user}, %{vdsm_group}, -)
+%{_localstatedir}/lib/%{vdsm_name}/bonding-defaults.json
 
 %files python
 %defattr(-, root, root, -)


-- 
To view, visit https://gerrit.ovirt.org/46401
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I3090cb77c8b6329c4885c6dbd43b04998df20dfe
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Ondřej Svoboda <osvoboda(a)redhat.com&gt;

automation(a)ovirt.org has posted comments on this change.

Change subject: spec: install bonding-defaults.json with 644 permissions, not 600
......................................................................


Patch Set 1:

* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and
is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5',
'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/46401
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3090cb77c8b6329c4885c6dbd43b04998df20dfe
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Ondřej Svoboda <osvoboda(a)redhat.com&gt;
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-HasComments: No

automation(a)ovirt.org has posted comments on this change.

Change subject: spec: install bonding-defaults.json with 644 permissions, not 600
......................................................................


Patch Set 2:

* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and
is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5',
'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/46401
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3090cb77c8b6329c4885c6dbd43b04998df20dfe
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Ondřej Svoboda <osvoboda(a)redhat.com&gt;
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-HasComments: No

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: spec: install bonding-defaults.json with 644 permissions, not 600
......................................................................


Patch Set 2: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/46401
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3090cb77c8b6329c4885c6dbd43b04998df20dfe
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Ondřej Svoboda <osvoboda(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-HasComments: No

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: spec: install bonding-defaults.json with 644 permissions, not 600
......................................................................


Patch Set 2: Continuous-Integration+1

Unrelated failure

 MountError: (32, ';mount:
/tmp/tmpW9PEah/vmId_iso.50aa5f97368744b2b6145e55360e5180.img: failed to setup loop device:
No such

-- 
To view, visit https://gerrit.ovirt.org/46401
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3090cb77c8b6329c4885c6dbd43b04998df20dfe
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Ondřej Svoboda <osvoboda(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-HasComments: No

Ondřej Svoboda has posted comments on this change.

Change subject: spec: install bonding-defaults.json with 644 permissions, not 600
......................................................................


Patch Set 2: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/46401
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3090cb77c8b6329c4885c6dbd43b04998df20dfe
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Ondřej Svoboda <osvoboda(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda <osvoboda(a)redhat.com&gt;
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-HasComments: No

[Dan Kenigsberg]

Dan Kenigsberg has submitted this change and it was merged.

Change subject: spec: install bonding-defaults.json with 644 permissions, not 600
......................................................................


spec: install bonding-defaults.json with 644 permissions, not 600

This way make check succeeds under non-root account for
testIterNetworkHierarchy, testTextualRepr and testValidateBondingOptions
which previously failed to read the file.

Change-Id: I3090cb77c8b6329c4885c6dbd43b04998df20dfe
Signed-off-by: Ondřej Svoboda <osvoboda(a)redhat.com&gt;
Reviewed-on: https://gerrit.ovirt.org/46395
Continuous-Integration: Jenkins CI
Reviewed-by: Dan Kenigsberg <danken(a)redhat.com&gt;
Reviewed-on: https://gerrit.ovirt.org/46401
Continuous-Integration: Dan Kenigsberg <danken(a)redhat.com&gt;
---
M vdsm.spec.in
1 file changed, 2 insertions(+), 1 deletion(-)

Approvals:
  Ondřej Svoboda: Verified
  Dan Kenigsberg: Looks good to me, approved; Passed CI tests

Objections:
  Jenkins CI: Failed CI tests



-- 
To view, visit https://gerrit.ovirt.org/46401
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I3090cb77c8b6329c4885c6dbd43b04998df20dfe
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Ondřej Svoboda <osvoboda(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda <osvoboda(a)redhat.com&gt;
Gerrit-Reviewer: automation(a)ovirt.org

automation(a)ovirt.org has posted comments on this change.

Change subject: spec: install bonding-defaults.json with 644 permissions, not 600
......................................................................


Patch Set 3:

* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.

-- 
To view, visit https://gerrit.ovirt.org/46401
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3090cb77c8b6329c4885c6dbd43b04998df20dfe
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Ondřej Svoboda <osvoboda(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda <osvoboda(a)redhat.com&gt;
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-HasComments: No

Ondřej Svoboda has posted comments on this change.

Change subject: spec: install bonding-defaults.json with 644 permissions, not 600
......................................................................


Patch Set 3:

DEBUG util.py:377:  failure:
repodata/278150d1e92408b1d07a6ea603dd56861f74a3801a306f4e10b45fbe47d084bb-primary.sqlite.xz
from epel-testing: [Errno 256] No more mirrors to try.
DEBUG util.py:377: 
http://download.fedoraproject.org/pub/epel/testing/7/x86_64/repodata/2781...:
[Errno 14] HTTP Error 404 - Not Found

-- 
To view, visit https://gerrit.ovirt.org/46401
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3090cb77c8b6329c4885c6dbd43b04998df20dfe
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Ondřej Svoboda <osvoboda(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda <osvoboda(a)redhat.com&gt;
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-HasComments: No