Change in vdsm[master]: Add deathSignal options to better peopen

Saggi Mizrahi has uploaded a new change for review.

Change subject: Add deathSignal options to better peopen
......................................................................

Add deathSignal options to better peopen

This allows VDSM to specify as signal that will be sent by the kernel to
the child when VDSM dies.

- Also fixes problem in the makefile that would cause make not to
  recompile the SO when the C file was changed

Change-Id: I9f987129cea112e2a75d6f02477369417cc50dc7
Signed-off-by: Saggi Mizrahi 
---
M vdsm/betterPopen/Makefile.am
M vdsm/betterPopen/__init__.py
M vdsm/betterPopen/createprocess.c
3 files changed, 35 insertions(+), 5 deletions(-)

git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/41/6241/1
--
To view, visit http://gerrit.ovirt.org/6241
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I9f987129cea112e2a75d6f02477369417cc50dc7
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi

Ayal Baron has posted comments on this change.

Change subject: Add deathSignal options to better peopen
......................................................................

Patch Set 3: (3 inline comments)

....................................................
Commit Message
Line 9: This allows VDSM to specify as signal that will be sent by the kernel to
s/as/a/

....................................................
File vdsm/betterPopen/__init__.py
Line 37:             # deathDignal is the signal that will be sent to the child process
s/Dignal/Signal/

Line 39:             # popen and when using standard peopen we should make sure we
s/peopen/popen/

--
To view, visit http://gerrit.ovirt.org/6241
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9f987129cea112e2a75d6f02477369417cc50dc7
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi 
Gerrit-Reviewer: Ayal Baron 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Saggi Mizrahi

[Federico Simoncelli]

Federico Simoncelli has posted comments on this change.

Change subject: Add deathSignal options to better peopen
......................................................................

Patch Set 3: Looks good to me, but someone else must approve

(1 inline comment)

....................................................
File vdsm/betterPopen/createprocess.c
Line 262:             // setting the death signal
Ah thanks for getting this. I remember that it came to my mind when we finished our discussion.

--
To view, visit http://gerrit.ovirt.org/6241
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9f987129cea112e2a75d6f02477369417cc50dc7
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi 
Gerrit-Reviewer: Ayal Baron 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Saggi Mizrahi

Ewoud Kohl van Wijngaarden has posted comments on this change.

Change subject: Add deathSignal options to better peopen
......................................................................

Patch Set 5: I would prefer that you didn't submit this

(2 inline comments)

Looks good, just nitpicking on the commit message.

....................................................
Commit Message
Line 9: This allows VDSM to specify as signal that will be sent by the kernel to
s/as/the

Line 13:   recompile the SO when the C file was changed
No need to indent this block.

--
To view, visit http://gerrit.ovirt.org/6241
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9f987129cea112e2a75d6f02477369417cc50dc7
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi 
Gerrit-Reviewer: Ayal Baron 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Ewoud Kohl van Wijngaarden 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Saggi Mizrahi

Ewoud Kohl van Wijngaarden has posted comments on this change.

Change subject: Add deathSignal options to better peopen
......................................................................

Patch Set 6: Looks good to me, but someone else must approve

Not that familiar with C, but I think it looks good.

--
To view, visit http://gerrit.ovirt.org/6241
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9f987129cea112e2a75d6f02477369417cc50dc7
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi 
Gerrit-Reviewer: Ayal Baron 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Ewoud Kohl van Wijngaarden 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Saggi Mizrahi

[Xu He Jie]

Xu He Jie has posted comments on this change.

Change subject: Add deathSignal options to better peopen
......................................................................

Patch Set 6: Verified; Looks good to me, but someone else must approve

--
To view, visit http://gerrit.ovirt.org/6241
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9f987129cea112e2a75d6f02477369417cc50dc7
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi 
Gerrit-Reviewer: Ayal Baron 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Ewoud Kohl van Wijngaarden 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Saggi Mizrahi 
Gerrit-Reviewer: Xu He Jie

Shu Ming has posted comments on this change.

Change subject: Add deathSignal options to better peopen
......................................................................

Patch Set 6: I would prefer that you didn't submit this

(2 inline comments)

....................................................
File vdsm/betterPopen/createprocess.c
Line 260:             errno = prctl(PR_SET_PDEATHSIG, deathSignal);
errno is actually a reserved variable in C library. It should not set by the application.  Usually,  in linux C library, if the return value of prtcl is negative which means some errors hapen,  errno can be checked to know which kind of error occurs.

Line 262:             // setting the death signal
"//" is not C-native.  "/*" and  "*/" should be used for standard C comments.

I prefer this format: 
/*
   Check that parent did not already die between fork and us
   setting the death signal
 */

--
To view, visit http://gerrit.ovirt.org/6241
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9f987129cea112e2a75d6f02477369417cc50dc7
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi 
Gerrit-Reviewer: Ayal Baron 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Ewoud Kohl van Wijngaarden 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Saggi Mizrahi 
Gerrit-Reviewer: Shu Ming 
Gerrit-Reviewer: Xu He Jie

Saggi Mizrahi has posted comments on this change.

Change subject: Add deathSignal options to better peopen
......................................................................

Patch Set 6: (1 inline comment)

....................................................
File vdsm/betterPopen/createprocess.c
Line 262:             // setting the death signal
They are actually available in c99. But I'll change it.

--
To view, visit http://gerrit.ovirt.org/6241
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9f987129cea112e2a75d6f02477369417cc50dc7
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi 
Gerrit-Reviewer: Ayal Baron 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Ewoud Kohl van Wijngaarden 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Saggi Mizrahi 
Gerrit-Reviewer: Shu Ming 
Gerrit-Reviewer: Xu He Jie

Ayal Baron has posted comments on this change.

Change subject: Add deathSignal options to better peopen
......................................................................

Patch Set 9: Looks good to me, but someone else must approve

(4 inline comments)

....................................................
Commit Message
Line 7: Add deathSignal options to better peopen
s/peopen/popen/

....................................................
File vdsm/betterPopen/__init__.py
Line 37:             # deathDignal is the signal that will be sent to the child process
s/Dignal/Signal

Line 39:             # popen and when using standard peopen we should make sure we
s/peopen/popen/

Line 40:             # reimplement this.
have you suggested this in upstream python?

--
To view, visit http://gerrit.ovirt.org/6241
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9f987129cea112e2a75d6f02477369417cc50dc7
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi 
Gerrit-Reviewer: Ayal Baron 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Ewoud Kohl van Wijngaarden 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Saggi Mizrahi 
Gerrit-Reviewer: Shu Ming 
Gerrit-Reviewer: Xu He Jie 
Gerrit-Reviewer: oVirt Jenkins CI Server

Ewoud Kohl van Wijngaarden has posted comments on this change.

Change subject: Add deathSignal options to better peopen
......................................................................

Patch Set 9: I would prefer that you didn't submit this

Please fix the typos as pointed out by Ayal

--
To view, visit http://gerrit.ovirt.org/6241
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9f987129cea112e2a75d6f02477369417cc50dc7
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi 
Gerrit-Reviewer: Ayal Baron 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Ewoud Kohl van Wijngaarden 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Saggi Mizrahi 
Gerrit-Reviewer: Shu Ming 
Gerrit-Reviewer: Xu He Jie 
Gerrit-Reviewer: oVirt Jenkins CI Server

Saggi Mizrahi has posted comments on this change.

Change subject: Add deathSignal options to better peopen
......................................................................

Patch Set 9: (1 inline comment)

....................................................
File vdsm/betterPopen/__init__.py
Line 36:     def __init__(self, args, close_fds=False, cwd=None, env=None,
Line 37:             # deathDignal is the signal that will be sent to the child process
Line 38:             # once the parent dies. This is not part of the standard python
Line 39:             # popen and when using standard peopen we should make sure we
Line 40:             # reimplement this.
No, it's a Linux specific API with a very odd semantic. I doubt it's going to get included upstream.
Line 41:             deathSignal=0):
Line 42:         if not isinstance(args, list):
Line 43:             args = list(args)
Line 44:

--
To view, visit http://gerrit.ovirt.org/6241
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9f987129cea112e2a75d6f02477369417cc50dc7
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi 
Gerrit-Reviewer: Ayal Baron 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Ewoud Kohl van Wijngaarden 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Saggi Mizrahi 
Gerrit-Reviewer: Shu Ming 
Gerrit-Reviewer: Xu He Jie 
Gerrit-Reviewer: oVirt Jenkins CI Server

Change in vdsm[master]: Add deathSignal options to better popen

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: Add deathSignal options to better popen
......................................................................

Patch Set 10:

Build Failed

http://jenkins.ovirt.info/job/patch_vdsm_unit_tests/424/ : FAILURE

--
To view, visit http://gerrit.ovirt.org/6241
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9f987129cea112e2a75d6f02477369417cc50dc7
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi 
Gerrit-Reviewer: Ayal Baron 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Ewoud Kohl van Wijngaarden 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Saggi Mizrahi 
Gerrit-Reviewer: Shu Ming 
Gerrit-Reviewer: Xu He Jie 
Gerrit-Reviewer: oVirt Jenkins CI Server

Change in vdsm[master]: Add deathSignal options to better popen

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: Add deathSignal options to better popen
......................................................................

Patch Set 10: Looks good to me, but someone else must approve

I would have expected that you, of all people, would add a unit test for the new functionality.

--
To view, visit http://gerrit.ovirt.org/6241
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9f987129cea112e2a75d6f02477369417cc50dc7
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi 
Gerrit-Reviewer: Ayal Baron 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Ewoud Kohl van Wijngaarden 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Saggi Mizrahi 
Gerrit-Reviewer: Shu Ming 
Gerrit-Reviewer: Xu He Jie 
Gerrit-Reviewer: oVirt Jenkins CI Server

Change in vdsm[master]: Add deathSignal options to better popen

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: Add deathSignal options to better popen
......................................................................

Patch Set 11: Fails

(3 inline comments)

`make check-local` fails.

....................................................
File tests/betterPopenTests.py
Line 150:         p.wait()
Line 151:         self.assertTrue(p.returncode == 0,
Line 152:                 "Process failed: %s" % os.strerror(p.returncode))
Line 153: 
Line 154:         self.assertEquals(p.stdout.read(), data)
a pep8 fairy just died.
Line 155:     def testDeathSignal(self):
Line 156:         procPtr = [None]
Line 157:         def spawn():
Line 158:             procPtr[0] = BetterPopen(["sleep", "10"], deathSignal=signal.SIGKILL)

Line 152:                 "Process failed: %s" % os.strerror(p.returncode))
Line 153: 
Line 154:         self.assertEquals(p.stdout.read(), data)
Line 155:     def testDeathSignal(self):
Line 156:         procPtr = [None]
this pointer trick should have an auto-completion rule for adding a comment...
Line 157:         def spawn():
Line 158:             procPtr[0] = BetterPopen(["sleep", "10"], deathSignal=signal.SIGKILL)
Line 159:         t = threading.Thread(target=spawn)
Line 160:         t.start()

Line 154:         self.assertEquals(p.stdout.read(), data)
Line 155:     def testDeathSignal(self):
Line 156:         procPtr = [None]
Line 157:         def spawn():
Line 158:             procPtr[0] = BetterPopen(["sleep", "10"], deathSignal=signal.SIGKILL)
and another one here.
Line 159:         t = threading.Thread(target=spawn)
Line 160:         t.start()
Line 161:         t.join()
Line 162:         start = time.time()

--
To view, visit http://gerrit.ovirt.org/6241
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9f987129cea112e2a75d6f02477369417cc50dc7
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi 
Gerrit-Reviewer: Ayal Baron 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Ewoud Kohl van Wijngaarden 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Saggi Mizrahi 
Gerrit-Reviewer: Shu Ming 
Gerrit-Reviewer: Xu He Jie 
Gerrit-Reviewer: oVirt Jenkins CI Server

Change in vdsm[master]: Add deathSignal options to better popen

Shu Ming has posted comments on this change.

Change subject: Add deathSignal options to better popen
......................................................................

Patch Set 12: I would prefer that you didn't submit this

(1 inline comment)

....................................................
File vdsm/betterPopen/createprocess.c
Line 310: 
Line 311:     if (deathSignal) {
Line 312:         /* death signal sync point */
Line 313:         if (read(errnofd[0], &childErrno, sizeof(int)) != sizeof(int)) {
Line 314:             PyErr_SetString(PyExc_OSError, strerror(childErrno));
It is more robust to check the return code of  read() to know what the status of read() system is.  Normally, EAGIN and EINTR should be checked.
Line 315:             goto fail;
Line 316:         }
Line 317: 
Line 318:         if (childErrno != 0) {

--
To view, visit http://gerrit.ovirt.org/6241
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9f987129cea112e2a75d6f02477369417cc50dc7
Gerrit-PatchSet: 12
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi 
Gerrit-Reviewer: Ayal Baron 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Ewoud Kohl van Wijngaarden 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Saggi Mizrahi 
Gerrit-Reviewer: Shu Ming 
Gerrit-Reviewer: Xu He Jie 
Gerrit-Reviewer: oVirt Jenkins CI Server

Change in vdsm[master]: Add deathSignal options to better popen

Shu Ming has posted comments on this change.

Change subject: Add deathSignal options to better popen
......................................................................

Patch Set 13: I would prefer that you didn't submit this

(1 inline comment)

....................................................
File vdsm/betterPopen/createprocess.c
Line 315:             rv = read(errnofd[0], &childErrno, sizeof(int));
Line 316:             if (rv < 0) {
Line 317:                 switch (errno) {
Line 318:                     case EINTR:
Line 319:                     case EAGAIN:
errnofd[] are blocking  IO fds here, see the code line 226.  pipe() system call should return non-blocking fds without O_NONBLOCK set manually.  So EAGAIN is not a possible error value for the read() call here, EAGAIN is only for non-blocking fds.  Tough it is not harmful to handle  EAGAIN case here, I would suggest to remove EAGAIN in case of  confusing.  Please ignore my previous comments about EAGAIN.  So you only need handle EINTR here.
Line 320:                         break;
Line 321:                     default:
Line 322:                         PyErr_SetString(PyExc_OSError, strerror(childErrno));
Line 323:                         goto fail;

--
To view, visit http://gerrit.ovirt.org/6241
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9f987129cea112e2a75d6f02477369417cc50dc7
Gerrit-PatchSet: 13
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi 
Gerrit-Reviewer: Ayal Baron 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Ewoud Kohl van Wijngaarden 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Saggi Mizrahi 
Gerrit-Reviewer: Shu Ming 
Gerrit-Reviewer: Xu He Jie 
Gerrit-Reviewer: oVirt Jenkins CI Server

Change in vdsm[master]: Add deathSignal options to better popen

Saggi Mizrahi has posted comments on this change.

Change subject: Add deathSignal options to better popen
......................................................................

Patch Set 13: (1 inline comment)

....................................................
File vdsm/betterPopen/createprocess.c
Line 315:             rv = read(errnofd[0], &childErrno, sizeof(int));
Line 316:             if (rv < 0) {
Line 317:                 switch (errno) {
Line 318:                     case EINTR:
Line 319:                     case EAGAIN:
I already knew that EAGAIN is impossible. I just thought I'll put it here and be done with it. I don't think this fix merits another iteration.
Line 320:                         break;
Line 321:                     default:
Line 322:                         PyErr_SetString(PyExc_OSError, strerror(childErrno));
Line 323:                         goto fail;

--
To view, visit http://gerrit.ovirt.org/6241
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9f987129cea112e2a75d6f02477369417cc50dc7
Gerrit-PatchSet: 13
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi 
Gerrit-Reviewer: Ayal Baron 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Ewoud Kohl van Wijngaarden 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Saggi Mizrahi 
Gerrit-Reviewer: Shu Ming 
Gerrit-Reviewer: Xu He Jie 
Gerrit-Reviewer: oVirt Jenkins CI Server

Change in vdsm[master]: Add deathSignal options to better popen

Shu Ming has posted comments on this change.

Change subject: Add deathSignal options to better popen
......................................................................

Patch Set 13: No score

(1 inline comment)

....................................................
File vdsm/betterPopen/createprocess.c
Line 315:             rv = read(errnofd[0], &childErrno, sizeof(int));
Line 316:             if (rv < 0) {
Line 317:                 switch (errno) {
Line 318:                     case EINTR:
Line 319:                     case EAGAIN:
I am Okay with that.
Line 320:                         break;
Line 321:                     default:
Line 322:                         PyErr_SetString(PyExc_OSError, strerror(childErrno));
Line 323:                         goto fail;

--
To view, visit http://gerrit.ovirt.org/6241
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9f987129cea112e2a75d6f02477369417cc50dc7
Gerrit-PatchSet: 13
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi 
Gerrit-Reviewer: Ayal Baron 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Ewoud Kohl van Wijngaarden 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Saggi Mizrahi 
Gerrit-Reviewer: Shu Ming 
Gerrit-Reviewer: Xu He Jie 
Gerrit-Reviewer: oVirt Jenkins CI Server

Change in vdsm[master]: Add deathSignal options to better popen

[Dan Kenigsberg]

Dan Kenigsberg has abandoned this change.

Change subject: Add deathSignal options to better popen
......................................................................

Abandoned

merged out of vdsm's tree.