Change in vdsm[master]: Fix HSM flows should not change rw permissions.

Eduardo has uploaded a new change for review.

Change subject: Fix HSM flows should not change rw permissions.
......................................................................

Fix HSM flows should not change rw permissions.

This whole setrw flow should not be done in HSM flows, as prepare
volume is.
In blocks domains can change VG metadata!
Minimal fix needs further development.

Change-Id: Ia53f0008cf3e7b25e14c7f03798c1ae527056725
---
M vdsm/storage/volume.py
1 file changed, 1 insertion(+), 1 deletion(-)

git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/97/797/1
--
To view, visit http://gerrit.ovirt.org/797
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia53f0008cf3e7b25e14c7f03798c1ae527056725
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: Fix HSM flows should not change rw permissions.
......................................................................

Patch Set 1: Looks good to me, but someone else must approve

This is a theoretical race, so we have time enough to solve it properly. However, I understand your disgust of hsm changing metadata.

--
To view, visit http://gerrit.ovirt.org/797
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia53f0008cf3e7b25e14c7f03798c1ae527056725
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo 
Gerrit-Reviewer: Dan Kenigsberg

[Igor Lvovsky]

Igor Lvovsky has posted comments on this change.

Change subject: Fix HSM flows should not change rw permissions.
......................................................................

Patch Set 1: Looks good to me, but someone else must approve

--
To view, visit http://gerrit.ovirt.org/797
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia53f0008cf3e7b25e14c7f03798c1ae527056725
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Igor Lvovsky

Ayal Baron has posted comments on this change.

Change subject: Fix HSM flows should not change rw permissions.
......................................................................

Patch Set 1: I would prefer that you didn't submit this

(1 inline comment)

....................................................
Commit Message
Line 12: Minimal fix needs further development.
s/.*/
changing permissions on LV/File is a clustered operation and should never be done in HSM.
Prepare is used by HSM therefore should not change permissions/

--
To view, visit http://gerrit.ovirt.org/797
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia53f0008cf3e7b25e14c7f03798c1ae527056725
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo 
Gerrit-Reviewer: Ayal Baron 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Igor Lvovsky

Ayal Baron has posted comments on this change.

Change subject: Fix HSM flows should not change rw permissions.
......................................................................

Patch Set 2: Looks good to me, approved

--
To view, visit http://gerrit.ovirt.org/797
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia53f0008cf3e7b25e14c7f03798c1ae527056725
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo 
Gerrit-Reviewer: Ayal Baron 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Eduardo 
Gerrit-Reviewer: Igor Lvovsky

Change in vdsm[master]: BZ#773666 - Fix HSM flows should not change rw permissions.

Ayal Baron has posted comments on this change.

Change subject: BZ#773666 - Fix HSM flows should not change rw permissions.
......................................................................

Patch Set 3: Looks good to me, approved

--
To view, visit http://gerrit.ovirt.org/797
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia53f0008cf3e7b25e14c7f03798c1ae527056725
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo 
Gerrit-Reviewer: Ayal Baron 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Eduardo 
Gerrit-Reviewer: Igor Lvovsky

Change in vdsm[master]: BZ#773666 - Fix HSM flows should not change rw permissions.

[Dan Kenigsberg]

Dan Kenigsberg has submitted this change and it was merged.

Change subject: BZ#773666 - Fix HSM flows should not change rw permissions.
......................................................................

BZ#773666 - Fix HSM flows should not change rw permissions.

Changing permissions on LV/File is a clustered operation and
should never be done in HSM.
Prepare is used by HSM therefore should not change permissions.
Minimal fix needs further development.

Change-Id: Ia53f0008cf3e7b25e14c7f03798c1ae527056725
---
M vdsm/storage/volume.py
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Ayal Baron: Looks good to me, approved
  Dan Kenigsberg: Verified

--
To view, visit http://gerrit.ovirt.org/797
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ia53f0008cf3e7b25e14c7f03798c1ae527056725
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo 
Gerrit-Reviewer: Ayal Baron 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Eduardo 
Gerrit-Reviewer: Igor Lvovsky

Change in vdsm[master]: BZ#773666 - Fix HSM flows should not change rw permissions.

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: BZ#773666 - Fix HSM flows should not change rw permissions.
......................................................................

Patch Set 3: Verified

Ok... let's take it as is and work on a comprehensive solution later. Edu, this is your responsibility.

--
To view, visit http://gerrit.ovirt.org/797
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia53f0008cf3e7b25e14c7f03798c1ae527056725
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo 
Gerrit-Reviewer: Ayal Baron 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Eduardo 
Gerrit-Reviewer: Igor Lvovsky