7:52 a.m.
Federico Simoncelli has uploaded a new change for review.
Change subject: vm: fix _devices access in _highWrite
......................................................................
vm: fix _devices access in _highWrite
Change-Id: I4fd790986b81402847b06810529841cfd7bae119
Signed-off-by: Federico Simoncelli <fsimonce(a)redhat.com>
---
M vdsm/vm.py
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/66/20966/1
diff --git a/vdsm/vm.py b/vdsm/vm.py
index 796735f..91cc0e8 100644
--- a/vdsm/vm.py
+++ b/vdsm/vm.py
@@ -494,7 +494,7 @@
return
try:
- self._extendVmDrives(self._devices[DISK_DEVICES])
+ self._extendVmDrives(self._vm._devices[DISK_DEVICES])
except InvalidAllocError as e:
self._log.error("Error extending VM drives: %s", e)
self._vm.pause(pauseCode='EOTHER')
--
To view, visit http://gerrit.ovirt.org/20966
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I4fd790986b81402847b06810529841cfd7bae119
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
3:34 a.m.
New subject: Change in vdsm[master]: vm: unify _highWrite and _onAbnormalStop
Dan Kenigsberg has submitted this change and it was merged.
Change subject: vm: unify _highWrite and _onAbnormalStop
......................................................................
vm: unify _highWrite and _onAbnormalStop
Both _highWrite and _onAbnormalStop should share the same logic about
the volume extension.
Change-Id: I4fd790986b81402847b06810529841cfd7bae119
Signed-off-by: Federico Simoncelli <fsimonce(a)redhat.com>
Reviewed-on: http://gerrit.ovirt.org/20966
Reviewed-by: Sergey Gotliv <sgotliv(a)redhat.com>
Reviewed-by: Ayal Baron <abaron(a)redhat.com>
---
M vdsm/vm.py
1 file changed, 24 insertions(+), 35 deletions(-)
Approvals:
Ayal Baron: Looks good to me, approved
Federico Simoncelli: Verified
Sergey Gotliv: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/20966
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I4fd790986b81402847b06810529841cfd7bae119
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
6:05 a.m.
New subject: Change in vdsm[master]: vm: unify _highWrite and _onAbnormalStop
Nir Soffer has posted comments on this change.
Change subject: vm: unify _highWrite and _onAbnormalStop
......................................................................
Patch Set 6:
Rebase?
--
To view, visit http://gerrit.ovirt.org/20966
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4fd790986b81402847b06810529841cfd7bae119
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
6:03 a.m.
New subject: Change in vdsm[master]: vm: unify _highWrite and _onAbnormalStop
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vm: unify _highWrite and _onAbnormalStop
......................................................................
Patch Set 6:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4559/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5359/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5438/ : SUCCESS
--
To view, visit http://gerrit.ovirt.org/20966
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4fd790986b81402847b06810529841cfd7bae119
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
11:12 p.m.
New subject: Change in vdsm[master]: vm: unify _highWrite and _onAbnormalStop
Sergey Gotliv has posted comments on this change.
Change subject: vm: unify _highWrite and _onAbnormalStop
......................................................................
Patch Set 5:
(2 comments)
I would consider to change the name of the method, except of that looks great.
....................................................
File vdsm/vm.py
Line 2279: self.log.debug('new rtc offset %s', timeOffset)
Line 2280: with self._confLock:
Line 2281: self.conf['timeOffset'] = timeOffset
Line 2282:
Line 2283: def checkDrivesForExtension(self):
Agree.
Line 2284: extend = []
Line 2285:
Line 2286: for drive in self._devices[DISK_DEVICES]:
Line 2287: if not drive.blockDev or drive.format != 'cow':
Line 2298: drive.volumeID, drive.domainID, drive.apparentsize, capacity,
Line 2299: alloc, physical)
Line 2300: self.extendDriveVolume(drive)
Line 2301:
Line 2302: return len(extend) > 0
I don't agree here, more than that this patch won't be merged without another, we
all know that, so...
Line 2303:
Line 2304: def extendDriveVolume(self, vmDrive):
Line 2305: if not vmDrive.blockDev:
Line 2306: return
--
To view, visit http://gerrit.ovirt.org/20966
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4fd790986b81402847b06810529841cfd7bae119
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
5:03 p.m.
New subject: Change in vdsm[master]: vm: unify _highWrite and _onAbnormalStop
Nir Soffer has posted comments on this change.
Change subject: vm: unify _highWrite and _onAbnormalStop
......................................................................
Patch Set 5:
(1 comment)
....................................................
File vdsm/vm.py
Line 2298: drive.volumeID, drive.domainID, drive.apparentsize, capacity,
Line 2299: alloc, physical)
Line 2300: self.extendDriveVolume(drive)
Line 2301:
Line 2302: return len(extend) > 0
I see that there is another patch depending on this, that will use the extend list.
However if this patch will be merge without the other then we are left with strange code.
The extend list should be added by the other patch.
Line 2303:
Line 2304: def extendDriveVolume(self, vmDrive):
Line 2305: if not vmDrive.blockDev:
Line 2306: return
--
To view, visit http://gerrit.ovirt.org/20966
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4fd790986b81402847b06810529841cfd7bae119
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
4:11 p.m.
New subject: Change in vdsm[master]: vm: unify _highWrite and _onAbnormalStop
Nir Soffer has posted comments on this change.
Change subject: vm: unify _highWrite and _onAbnormalStop
......................................................................
Patch Set 5:
(3 comments)
....................................................
File vdsm/vm.py
Line 2279: self.log.debug('new rtc offset %s', timeOffset)
Line 2280: with self._confLock:
Line 2281: self.conf['timeOffset'] = timeOffset
Line 2282:
Line 2283: def checkDrivesForExtension(self):
This name is misleading - you don't expect that "check" will trigger an
extension.
How about:
def extendDrivesIfNeeded():
One can expect that this method will check which drives should be extended and extend
them.
Line 2284: extend = []
Line 2285:
Line 2286: for drive in self._devices[DISK_DEVICES]:
Line 2287: if not drive.blockDev or drive.format != 'cow':
Line 2298: drive.volumeID, drive.domainID, drive.apparentsize, capacity,
Line 2299: alloc, physical)
Line 2300: self.extendDriveVolume(drive)
Line 2301:
Line 2302: return len(extend) > 0
Now that we don't have the check for alloc > capacity, why do we need the extend
list?
We can do:
extended = 0
for drive in drives:
skip irelevant drives
get drive info
if drive needs extension:
log
extend it
extended +=1
return extended
Line 2303:
Line 2304: def extendDriveVolume(self, vmDrive):
Line 2305: if not vmDrive.blockDev:
Line 2306: return
Line 4277: self.conf['pauseCode'] = err.upper()
Line 4278: self._guestCpuRunning = False
Line 4279: if err.upper() == 'ENOSPC':
Line 4280: if not self.checkDrivesForExtension():
Line 4281: self.log.info("No VM drives were extended")
Warning or an error?
Line 4282:
Line 4283: def _acpiShutdown(self):
Line 4284: self._dom.shutdownFlags(libvirt.VIR_DOMAIN_SHUTDOWN_ACPI_POWER_BTN)
Line 4285:
--
To view, visit http://gerrit.ovirt.org/20966
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4fd790986b81402847b06810529841cfd7bae119
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
5:52 a.m.
New subject: Change in vdsm[master]: vm: unify _highWrite and _onAbnormalStop
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vm: unify _highWrite and _onAbnormalStop
......................................................................
Patch Set 4:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4472/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5272/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5350/ : SUCCESS
--
To view, visit http://gerrit.ovirt.org/20966
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4fd790986b81402847b06810529841cfd7bae119
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
5:42 a.m.
Federico Simoncelli has posted comments on this change.
Change subject: vm: fix _devices access in _highWrite
......................................................................
Patch Set 3:
(2 comments)
....................................................
File vdsm/vm.py
Line 2280: self.log.debug('new rtc offset %s', timeOffset)
Line 2281: with self._confLock:
Line 2282: self.conf['timeOffset'] = timeOffset
Line 2283:
Line 2284: def checkDrivesForExtension(self):
Actually it's not extending, It's checking if one or more extensions are in order.
Calling this method is not always resulting in an extension. I'll happily accept any
better name that is conveying that idea.
Line 2285: extend = []
Line 2286:
Line 2287: for drive in self._devices[DISK_DEVICES]:
Line 2288: if not drive.blockDev or drive.format != 'cow':
Line 2299: "capacity %s for volume %s on domain %s", alloc,
Line 2300: capacity, drive.domainID, drive.volumeID)
Line 2301: self.pause(pauseCode='EOTHER')
Line 2302:
Line 2303: for drive, capacity, alloc, physical in extend:
I'm not entirely sure about this one, I understand you want to skip the extension (and
pause) for the faulty one, but I don't see any relevant reason to prevent also the
other ones. Anyway we'll address this in another patch. I'm going to transform
this into just a plain refactor.
Line 2304: self.log.info('%s/%s apparent: %s capacity: %s, alloc: %s,
'
Line 2305: 'physical: %s', drive.domainID,
drive.volumeID,
Line 2306: drive.apparentsize, capacity, alloc, physical)
Line 2307: self.extendDriveVolume(drive)
--
To view, visit http://gerrit.ovirt.org/20966
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4fd790986b81402847b06810529841cfd7bae119
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com>
Gerrit-HasComments: Yes
10:10 p.m.
Ayal Baron has posted comments on this change.
Change subject: vm: fix _devices access in _highWrite
......................................................................
Patch Set 3:
(2 comments)
....................................................
File vdsm/vm.py
Line 2280: self.log.debug('new rtc offset %s', timeOffset)
Line 2281: with self._confLock:
Line 2282: self.conf['timeOffset'] = timeOffset
Line 2283:
Line 2284: def checkDrivesForExtension(self):
this isn't 'checking' this is actually extending
Line 2285: extend = []
Line 2286:
Line 2287: for drive in self._devices[DISK_DEVICES]:
Line 2288: if not drive.blockDev or drive.format != 'cow':
Line 2299: "capacity %s for volume %s on domain %s", alloc,
Line 2300: capacity, drive.domainID, drive.volumeID)
Line 2301: self.pause(pauseCode='EOTHER')
Line 2302:
Line 2303: for drive, capacity, alloc, physical in extend:
Sergey is correct, I don't deem it safe to extend any drive if VM has a device with
alloc > capacity
Line 2304: self.log.info('%s/%s apparent: %s capacity: %s, alloc: %s,
'
Line 2305: 'physical: %s', drive.domainID,
drive.volumeID,
Line 2306: drive.apparentsize, capacity, alloc, physical)
Line 2307: self.extendDriveVolume(drive)
--
To view, visit http://gerrit.ovirt.org/20966
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4fd790986b81402847b06810529841cfd7bae119
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com>
Gerrit-HasComments: Yes
12:37 p.m.
Sergey Gotliv has posted comments on this change.
Change subject: vm: fix _devices access in _highWrite
......................................................................
Patch Set 3:
(1 comment)
....................................................
File vdsm/vm.py
Line 2297: self.log.error(
Line 2298: "Allocated size %s cannot be higher than the disk
"
Line 2299: "capacity %s for volume %s on domain %s", alloc,
Line 2300: capacity, drive.domainID, drive.volumeID)
Line 2301: self.pause(pauseCode='EOTHER')
It looks like you change original logic:
One of previous comments was that there is no need to extend drives if one of them has
alloc > capacity.
Line 2302:
Line 2303: for drive, capacity, alloc, physical in extend:
Line 2304: self.log.info('%s/%s apparent: %s capacity: %s, alloc: %s,
'
Line 2305: 'physical: %s', drive.domainID,
drive.volumeID,
--
To view, visit http://gerrit.ovirt.org/20966
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4fd790986b81402847b06810529841cfd7bae119
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
11:58 a.m.
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vm: fix _devices access in _highWrite
......................................................................
Patch Set 3: Verified-1
Build Failed
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4463/ : FAILURE
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5264/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5342/ : SUCCESS
--
To view, visit http://gerrit.ovirt.org/20966
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4fd790986b81402847b06810529841cfd7bae119
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
11:58 a.m.
Federico Simoncelli has posted comments on this change.
Change subject: vm: fix _devices access in _highWrite
......................................................................
Patch Set 3:
(2 comments)
....................................................
Commit Message
Line 3: AuthorDate: 2013-11-06 08:50:57 -0500
Line 4: Commit: Federico Simoncelli <fsimonce(a)redhat.com>
Line 5: CommitDate: 2013-11-06 12:46:50 -0500
Line 6:
Line 7: vm: fix _devices access in _highWrite
We probably need a new commit message.
Line 8:
Line 9: Main focus of this patch was to fix two attribute errors:
Line 10:
Line 11: - self._devices (in VmStatsThread._extendVmDrives)
Line 14: It soon appeared clear that it would have been more logical to
Line 15: move _extendVmDrives to the VM object in order to solve them all
Line 16: at once.
Line 17:
Line 18: In this patch:
Maybe we need to split all this. As far as I'm concerned I'd prefer to keep them
all together.
Line 19: - rename _extendVmDrives to checkDrivesForExtension and move it
Line 20: to the Vm object
Line 21: - remove (the now unused) InvalidAllocError
Line 22: - move the "No VM drives were extended" logging message to the
--
To view, visit http://gerrit.ovirt.org/20966
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4fd790986b81402847b06810529841cfd7bae119
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
11:12 a.m.
Federico Simoncelli has posted comments on this change.
Change subject: vm: fix _devices access in _highWrite
......................................................................
Patch Set 2:
(2 comments)
....................................................
File vdsm/vm.py
Line 509: capacity, alloc, physical = self._vm._dom.blockInfo(
Line 510: drive.path, 0)
Line 511:
Line 512: if physical < alloc:
Line 513: raise InvalidAllocError('Implausible alloc %s > physical
%s '
This is actually possible. When we're hitting ENOSPC the allocated space is slightly
larger (which is actually the required space). E.g. as it just happened to me, allocated
271187456 and physical 268435456 (256Mb) (I use chunks of 128Mb vs 1G in order to better
test the extensions).
Line 514: 'in volume %s.' %
Line 515: (alloc, physical, drive.path))
Line 516:
Line 517: if physical - alloc < drive.watermarkLimit:
Line 4294: if err.upper() == 'ENOSPC':
Line 4295: drives = [vmDrive for vmDrive in self._devices[DISK_DEVICES]
Line 4296: if vmDrive.alias == blockDevAlias]
Line 4297: try:
Line 4298: if not self._extendVmDrives(drives):
Moving _extendVmDrives to the VM object.
Line 4299: self._log.info("No VM drives were extended")
Line 4300: except InvalidAllocError as e:
Line 4301: self._log.error("Error extending VM drives: %s", e)
Line 4302:
--
To view, visit http://gerrit.ovirt.org/20966
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4fd790986b81402847b06810529841cfd7bae119
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
10:53 a.m.
Sergey Gotliv has posted comments on this change.
Change subject: vm: fix _devices access in _highWrite
......................................................................
Patch Set 2:
Federico,
1. Please, add a bug url, without that fix my fix of highWrite is useless.
2. Can you just move _extendDrives to VM? Let's remember that unfortunately I left
VDSM in a bad shape after my patch, so I want a quick fix here.
--
To view, visit http://gerrit.ovirt.org/20966
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4fd790986b81402847b06810529841cfd7bae119
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
10:19 a.m.
Federico Simoncelli has posted comments on this change.
Change subject: vm: fix _devices access in _highWrite
......................................................................
Patch Set 2: Code-Review-1
(1 comment)
....................................................
File vdsm/vm.py
Line 4294: if err.upper() == 'ENOSPC':
Line 4295: drives = [vmDrive for vmDrive in self._devices[DISK_DEVICES]
Line 4296: if vmDrive.alias == blockDevAlias]
Line 4297: try:
Line 4298: if not self._extendVmDrives(drives):
Actually this is wrong, _extendVmDrives is part of the VmStatsThread object.
Line 4299: self._log.info("No VM drives were extended")
Line 4300: except InvalidAllocError as e:
Line 4301: self._log.error("Error extending VM drives: %s", e)
Line 4302:
--
To view, visit http://gerrit.ovirt.org/20966
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4fd790986b81402847b06810529841cfd7bae119
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
9:40 a.m.
Dan Kenigsberg has posted comments on this change.
Change subject: vm: fix _devices access in _highWrite
......................................................................
Patch Set 2: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/20966
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4fd790986b81402847b06810529841cfd7bae119
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
8:33 a.m.
Sergey Gotliv has posted comments on this change.
Change subject: vm: fix _devices access in _highWrite
......................................................................
Patch Set 2: Code-Review+1
Nice!
--
To view, visit http://gerrit.ovirt.org/20966
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4fd790986b81402847b06810529841cfd7bae119
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
8:27 a.m.
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vm: fix _devices access in _highWrite
......................................................................
Patch Set 2: Verified-1
Build Failed
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4452/ : FAILURE
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5254/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5332/ : SUCCESS
--
To view, visit http://gerrit.ovirt.org/20966
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4fd790986b81402847b06810529841cfd7bae119
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
8:25 a.m.
Federico Simoncelli has posted comments on this change.
Change subject: vm: fix _devices access in _highWrite
......................................................................
Patch Set 2:
(1 comment)
....................................................
File vdsm/vm.py
Line 500: self._vm.pause(pauseCode='EOTHER')
Line 501:
Line 502: def _extendVmDrives(self, vmDrives):
Line 503: extend = []
Line 504:
Sorry, I tried, but I couldn't resist it :-)
Line 505: for drive in vmDrives:
Line 506: if not drive.blockDev or drive.format != 'cow':
Line 507: continue
Line 508:
--
To view, visit http://gerrit.ovirt.org/20966
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4fd790986b81402847b06810529841cfd7bae119
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
7:55 a.m.
Sergey Gotliv has posted comments on this change.
Change subject: vm: fix _devices access in _highWrite
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/20966
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4fd790986b81402847b06810529841cfd7bae119
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
7:54 a.m.
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vm: fix _devices access in _highWrite
......................................................................
Patch Set 1: Verified-1
Build Failed
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4450/ : FAILURE
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5252/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5330/ : SUCCESS
--
To view, visit http://gerrit.ovirt.org/20966
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4fd790986b81402847b06810529841cfd7bae119
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
10 a.m.
New subject: Change in vdsm[master]: vm: unify _highWrite and _onAbnormalStop
Ayal Baron has posted comments on this change.
Change subject: vm: unify _highWrite and _onAbnormalStop
......................................................................
Patch Set 7: Code-Review+2
The refactoring here looks fine
--
To view, visit http://gerrit.ovirt.org/20966
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4fd790986b81402847b06810529841cfd7bae119
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
9:12 a.m.
New subject: Change in vdsm[master]: vm: unify _highWrite and _onAbnormalStop
Sergey Gotliv has posted comments on this change.
Change subject: vm: unify _highWrite and _onAbnormalStop
......................................................................
Patch Set 7: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/20966
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4fd790986b81402847b06810529841cfd7bae119
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
9:10 a.m.
New subject: Change in vdsm[master]: vm: unify _highWrite and _onAbnormalStop
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vm: unify _highWrite and _onAbnormalStop
......................................................................
Patch Set 7:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4573/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5373/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5452/ : SUCCESS
--
To view, visit http://gerrit.ovirt.org/20966
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4fd790986b81402847b06810529841cfd7bae119
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
9:10 a.m.
New subject: Change in vdsm[master]: vm: unify _highWrite and _onAbnormalStop
Federico Simoncelli has posted comments on this change.
Change subject: vm: unify _highWrite and _onAbnormalStop
......................................................................
Patch Set 7: Verified+1
Verified (before the renaming).
--
To view, visit http://gerrit.ovirt.org/20966
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4fd790986b81402847b06810529841cfd7bae119
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
11:19 a.m.
New subject: Change in vdsm[master]: vm: unify _highWrite and _onAbnormalStop
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vm: unify _highWrite and _onAbnormalStop
......................................................................
Patch Set 5:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4540/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5340/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5419/ : SUCCESS
--
To view, visit http://gerrit.ovirt.org/20966
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4fd790986b81402847b06810529841cfd7bae119
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
4:22 a.m.
New subject: Change in vdsm[master]: vm: unify _highWrite and _onAbnormalStop
Sergey Gotliv has posted comments on this change.
Change subject: vm: unify _highWrite and _onAbnormalStop
......................................................................
Patch Set 4: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/20966
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4fd790986b81402847b06810529841cfd7bae119
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
3878
days inactive
3885
days old
vdsm-patches@lists.fedorahosted.org
27 comments
6 participants
participants (6)
-
abaron＠redhat.com -
Dan Kenigsberg -
Federico Simoncelli -
Jenkins CI RO -
Nir Soffer -
sgotliv＠redhat.com