Change in vdsm[master]: Add persistentDictTests

Saggi Mizrahi has uploaded a new change for review.

Change subject: Add persistentDictTests
......................................................................

Add persistentDictTests

Change-Id: Ib00d930051341dce6f1a986ac44cf0690b97c000
Signed-off-by: Saggi Mizrahi 
---
M tests/Makefile.am
A tests/persistentDictTests.py
2 files changed, 94 insertions(+), 0 deletions(-)

git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/96/3496/1
--
To view, visit http://gerrit.ovirt.org/3496
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib00d930051341dce6f1a986ac44cf0690b97c000
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi

Ayal Baron has posted comments on this change.

Change subject: Add persistentDictTests
......................................................................

Patch Set 2: I would prefer that you didn't submit this

(3 inline comments)

....................................................
File tests/persistentDictTests.py
Line 29:                            # (C) Valve - Portal 2
is it legal to put these quotes here? or is it copyright infringement?

Line 60:                'he thought to himself, "where the worst type of women"'
s/where/were/
Are you quoting from memory? because I think you are not true to the source here.

Line 65:     def testFaileNestedTransaction(self):
testFaile"d"?

--
To view, visit http://gerrit.ovirt.org/3496
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib00d930051341dce6f1a986ac44cf0690b97c000
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi 
Gerrit-Reviewer: Ayal Baron 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Peter V. Saveliev 
Gerrit-Reviewer: Saggi Mizrahi

Peter V. Saveliev has posted comments on this change.

Change subject: Add persistentDictTests
......................................................................

Patch Set 3: Verified; Looks good to me, but someone else must approve

--
To view, visit http://gerrit.ovirt.org/3496
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib00d930051341dce6f1a986ac44cf0690b97c000
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi 
Gerrit-Reviewer: Ayal Baron 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Peter V. Saveliev 
Gerrit-Reviewer: Saggi Mizrahi

Ayal Baron has posted comments on this change.

Change subject: Add persistentDictTests
......................................................................

Patch Set 3: Looks good to me, but someone else must approve

--
To view, visit http://gerrit.ovirt.org/3496
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib00d930051341dce6f1a986ac44cf0690b97c000
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi 
Gerrit-Reviewer: Ayal Baron 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Peter V. Saveliev 
Gerrit-Reviewer: Saggi Mizrahi

Saggi Mizrahi has posted comments on this change.

Change subject: Add persistentDictTests
......................................................................

Patch Set 2: (1 inline comment)

....................................................
File tests/persistentDictTests.py
Line 60:                'he thought to himself, "where the worst type of women"'
I am quoting from memory and it is a bit off.
"Scotty had a will of her own, which was always dangerous in a woman."
http://www.octobot.net/library/Dick,%20Philip%20K/Dick,%20Philip%20K%20-%20T...

I think it is a record about how pedantic you can get reviewing a patch.

--
To view, visit http://gerrit.ovirt.org/3496
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib00d930051341dce6f1a986ac44cf0690b97c000
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi 
Gerrit-Reviewer: Ayal Baron 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Peter V. Saveliev 
Gerrit-Reviewer: Saggi Mizrahi

Peter V. Saveliev has posted comments on this change.

Change subject: Add persistentDictTests
......................................................................

Patch Set 5: Verified; Looks good to me, but someone else must approve

--
To view, visit http://gerrit.ovirt.org/3496
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib00d930051341dce6f1a986ac44cf0690b97c000
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi 
Gerrit-Reviewer: Ayal Baron 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Peter V. Saveliev 
Gerrit-Reviewer: Saggi Mizrahi

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: Add persistentDictTests
......................................................................

Patch Set 5: Looks good to me, approved

--
To view, visit http://gerrit.ovirt.org/3496
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib00d930051341dce6f1a986ac44cf0690b97c000
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi 
Gerrit-Reviewer: Ayal Baron 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Peter V. Saveliev 
Gerrit-Reviewer: Saggi Mizrahi

[Dan Kenigsberg]

Dan Kenigsberg has submitted this change and it was merged.

Change subject: Add persistentDictTests
......................................................................

Add persistentDictTests

Change-Id: Ib00d930051341dce6f1a986ac44cf0690b97c000
Signed-off-by: Saggi Mizrahi 
---
M tests/Makefile.am
A tests/persistentDictTests.py
2 files changed, 78 insertions(+), 0 deletions(-)

Approvals:
  Dan Kenigsberg: Looks good to me, approved
  Peter V. Saveliev: Verified; Looks good to me, but someone else must approve

--
To view, visit http://gerrit.ovirt.org/3496
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ib00d930051341dce6f1a986ac44cf0690b97c000
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi 
Gerrit-Reviewer: Ayal Baron 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Peter V. Saveliev 
Gerrit-Reviewer: Saggi Mizrahi