Change in vdsm[ovirt-3.3]: netinfo.speed: avoid log spam

[Dan Kenigsberg]

Dan Kenigsberg has uploaded a new change for review.

Change subject: netinfo.speed: avoid log spam
......................................................................

netinfo.speed: avoid log spam

Some network device drivers, such as infiniband, do not expose their
"speed". In such cases we report speed "0", and fill vdsm.log with a
persistent exception traceback. With this patch, Vdsm no longer seem
surprised by a nic with invalid speed pseudofile.

Change-Id: I4b03470139fb383fd03eaa2dc356539eae80d1c0
Signed-off-by: Dan Kenigsberg <danken(a)redhat.com&gt;
---
M lib/vdsm/netinfo.py
1 file changed, 3 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/97/24197/1

diff --git a/lib/vdsm/netinfo.py b/lib/vdsm/netinfo.py
index 790c099..7d12bb3 100644
--- a/lib/vdsm/netinfo.py
+++ b/lib/vdsm/netinfo.py
@@ -297,6 +297,9 @@
                 s = int(speedFile.read())
             if s not in (2 ** 16 - 1, 2 ** 32 - 1) or s > 0:
                 return s
+    except IOError as ose:
+        if ose.errno != errno.EINVAL:
+            logging.exception('cannot read %s nic speed', dev)
     except Exception:
         logging.exception('cannot read %s speed', dev)
     return 0


-- 
To view, visit http://gerrit.ovirt.org/24197
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I4b03470139fb383fd03eaa2dc356539eae80d1c0
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.3
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com&gt;

Yaniv Bronhaim has submitted this change and it was merged.

Change subject: netinfo.speed: avoid log spam
......................................................................


netinfo.speed: avoid log spam

Some network device drivers, such as infiniband, do not expose their
"speed". In such cases we report speed "0", and fill vdsm.log with a
persistent exception traceback. With this patch, Vdsm no longer seem
surprised by a nic with invalid speed pseudofile.

Thanks for Trey Dockendorf for reporting the issue on
http://lists.ovirt.org/pipermail/users/2014-February/020987.html

Bug-Url: https://bugzilla.redhat.com/1063433
Change-Id: I4b03470139fb383fd03eaa2dc356539eae80d1c0
Signed-off-by: Dan Kenigsberg <danken(a)redhat.com&gt;
Reviewed-on: http://gerrit.ovirt.org/24197
Reviewed-by: Antoni Segura Puimedon <asegurap(a)redhat.com&gt;
Reviewed-by: Yaniv Bronhaim <ybronhei(a)redhat.com&gt;
---
M lib/vdsm/netinfo.py
1 file changed, 3 insertions(+), 0 deletions(-)

Approvals:
  Yaniv Bronhaim: Looks good to me, approved
  Antoni Segura Puimedon: Looks good to me, but someone else must approve
  Dan Kenigsberg: Verified



-- 
To view, visit http://gerrit.ovirt.org/24197
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I4b03470139fb383fd03eaa2dc356539eae80d1c0
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.3
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Itzik Brown <itzikb(a)mellanox.com&gt;
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com&gt;
Gerrit-Reviewer: automation(a)ovirt.org

Yaniv Bronhaim has posted comments on this change.

Change subject: netinfo.speed: avoid log spam
......................................................................


Patch Set 2: Code-Review+2

-- 
To view, visit http://gerrit.ovirt.org/24197
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4b03470139fb383fd03eaa2dc356539eae80d1c0
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.3
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Itzik Brown <itzikb(a)mellanox.com&gt;
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com&gt;
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-HasComments: No

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: netinfo.speed: avoid log spam
......................................................................


Patch Set 2: Verified+1

Verified by Trey Dockendorf.

-- 
To view, visit http://gerrit.ovirt.org/24197
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4b03470139fb383fd03eaa2dc356539eae80d1c0
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.3
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Itzik Brown <itzikb(a)mellanox.com&gt;
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-HasComments: No

Antoni Segura Puimedon has posted comments on this change.

Change subject: netinfo.speed: avoid log spam
......................................................................


Patch Set 1: Code-Review+1

It seems like a reasonable logspam fix for a "buggish" behavior that fortunately
does not exist on master anymore. Wholeheartedly +2 if I had it.

-- 
To view, visit http://gerrit.ovirt.org/24197
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4b03470139fb383fd03eaa2dc356539eae80d1c0
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.3
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Itzik Brown <itzikb(a)mellanox.com&gt;
Gerrit-HasComments: No

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: netinfo.speed: avoid log spam
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.ovirt.org/#/c/24197/1//COMMIT_MSG
Commit Message:

Line 8: 
Line 9: Some network device drivers, such as infiniband, do not expose their
Line 10: "speed". In such cases we report speed "0", and fill vdsm.log
with a
Line 11: persistent exception traceback. With this patch, Vdsm no longer seem
Line 12: surprised by a nic with invalid speed pseudofile.
should add a link to

http://lists.ovirt.org/pipermail/users/2014-February/020987.html
Line 13: 
Line 14: Change-Id: I4b03470139fb383fd03eaa2dc356539eae80d1c0


-- 
To view, visit http://gerrit.ovirt.org/24197
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4b03470139fb383fd03eaa2dc356539eae80d1c0
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.3
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Itzik Brown <itzikb(a)mellanox.com&gt;
Gerrit-HasComments: Yes