Change in vdsm[master]: vm: add direct import of advancedstats helpers

Francesco Romani has uploaded a new change for review.

Change subject: vm: add direct import of advancedstats helpers
......................................................................

vm: add direct import of advancedstats helpers

This is purely a transitional patch towards
the move of VmStatsThread from vm.py to sampling.py.

This patch adds directly import of the VmStatsThread
dependencies, in order to make the move of such class
exactly a trivial matter of cut/paste plus fixing imports,
with exactly zero changes needed to VmStatsThread itself.

Thus the final patch will be more easily
verifiable.

Change-Id: I6b009f4a0cb0179fa1f1b74774ba61fd6638d8a9
Signed-off-by: Francesco Romani <fromani(a)redhat.com&gt;
---
M vdsm/virt/vm.py
1 file changed, 10 insertions(+), 9 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/80/28480/1

diff --git a/vdsm/virt/vm.py b/vdsm/virt/vm.py
index 0e6f291..3b8a16b 100644
--- a/vdsm/virt/vm.py
+++ b/vdsm/virt/vm.py
@@ -45,6 +45,7 @@
 from vdsm.config import config
 from vdsm.define import ERROR, NORMAL, doneCode, errCode
 from vdsm.netinfo import DUMMY_BRIDGE
+from vdsm.sampling import AdvancedStatsFunction, AdvancedStatsThread
 from vdsm.utils import isVdsmImage
 from storage import outOfProcess as oop
 from storage import sd
@@ -147,44 +148,44 @@
     pass
 
 
-class VmStatsThread(sampling.AdvancedStatsThread):
+class VmStatsThread(AdvancedStatsThread):
     MBPS_TO_BPS = 10 ** 6 / 8
 
     def __init__(self, vm):
-        sampling.AdvancedStatsThread.__init__(self, log=vm.log, daemon=True)
+        AdvancedStatsThread.__init__(self, log=vm.log, daemon=True)
         self._vm = vm
 
         self.highWrite = (
-            sampling.AdvancedStatsFunction(
+            AdvancedStatsFunction(
                 self._highWrite,
                 config.getint('vars', 'vm_watermark_interval')))
         self.updateVolumes = (
-            sampling.AdvancedStatsFunction(
+            AdvancedStatsFunction(
                 self._updateVolumes,
                 config.getint('irs', 'vol_size_sample_interval')))
 
         self.sampleCpu = (
-            sampling.AdvancedStatsFunction(
+            AdvancedStatsFunction(
                 self._sampleCpu,
                 config.getint('vars', 'vm_sample_cpu_interval'),
                 config.getint('vars', 'vm_sample_cpu_window')))
         self.sampleDisk = (
-            sampling.AdvancedStatsFunction(
+            AdvancedStatsFunction(
                 self._sampleDisk,
                 config.getint('vars', 'vm_sample_disk_interval'),
                 config.getint('vars', 'vm_sample_disk_window')))
         self.sampleDiskLatency = (
-            sampling.AdvancedStatsFunction(
+            AdvancedStatsFunction(
                 self._sampleDiskLatency,
                 config.getint('vars',
'vm_sample_disk_latency_interval'),
                 config.getint('vars', 'vm_sample_disk_latency_window')))
         self.sampleNet = (
-            sampling.AdvancedStatsFunction(
+            AdvancedStatsFunction(
                 self._sampleNet,
                 config.getint('vars', 'vm_sample_net_interval'),
                 config.getint('vars', 'vm_sample_net_window')))
         self.sampleBalloon = (
-            sampling.AdvancedStatsFunction(
+            AdvancedStatsFunction(
                 self._sampleBalloon,
                 config.getint('vars', 'vm_sample_balloon_interval'),
                 config.getint('vars', 'vm_sample_balloon_window')))


-- 
To view, visit http://gerrit.ovirt.org/28480
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I6b009f4a0cb0179fa1f1b74774ba61fd6638d8a9
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani(a)redhat.com&gt;

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: vm: add direct import of advancedstats helpers
......................................................................


Patch Set 12:

Build Successful 

http://jenkins.ovirt.org/job/vdsm_master_create-rpms_merged/1548/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_verify-error-codes_merged/5533/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/3691/ : SUCCESS

-- 
To view, visit http://gerrit.ovirt.org/28480
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6b009f4a0cb0179fa1f1b74774ba61fd6638d8a9
Gerrit-PatchSet: 12
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com&gt;
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com&gt;
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No

[Dan Kenigsberg]

Dan Kenigsberg has submitted this change and it was merged.

Change subject: vm: add direct import of advancedstats helpers
......................................................................


vm: add direct import of advancedstats helpers

This is purely a transitional patch towards
the move of VmStatsThread from vm.py to sampling.py.

This patch adds directly import of the VmStatsThread
dependencies, in order to make the move of such class
exactly a trivial matter of cut/paste plus fixing imports,
with exactly zero changes needed to VmStatsThread itself.

Thus the final patch will be more easily
verifiable.

Change-Id: I6b009f4a0cb0179fa1f1b74774ba61fd6638d8a9
Signed-off-by: Francesco Romani <fromani(a)redhat.com&gt;
Reviewed-on: http://gerrit.ovirt.org/28480
Reviewed-by: Nir Soffer <nsoffer(a)redhat.com&gt;
Reviewed-by: Dan Kenigsberg <danken(a)redhat.com&gt;
---
M vdsm/virt/vm.py
1 file changed, 13 insertions(+), 13 deletions(-)

Approvals:
  Nir Soffer: Looks good to me, but someone else must approve
  Dan Kenigsberg: Looks good to me, approved
  Francesco Romani: Verified



-- 
To view, visit http://gerrit.ovirt.org/28480
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I6b009f4a0cb0179fa1f1b74774ba61fd6638d8a9
Gerrit-PatchSet: 12
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com&gt;
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com&gt;
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: vm: add direct import of advancedstats helpers
......................................................................


Patch Set 11: Code-Review+2

-- 
To view, visit http://gerrit.ovirt.org/28480
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6b009f4a0cb0179fa1f1b74774ba61fd6638d8a9
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com&gt;
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com&gt;
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: vm: add direct import of advancedstats helpers
......................................................................


Patch Set 11:

Build Failed 

http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9734/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/10519/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/1062/ : There was an
infra issue, please contact infra(a)ovirt.org

http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/10676/ : SUCCESS

-- 
To view, visit http://gerrit.ovirt.org/28480
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6b009f4a0cb0179fa1f1b74774ba61fd6638d8a9
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani(a)redhat.com&gt;
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com&gt;
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com&gt;
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: vm: add direct import of advancedstats helpers
......................................................................


Patch Set 10:

Build Failed 

http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9687/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/10472/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/1032/ : There was an
infra issue, please contact infra(a)ovirt.org

http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/10629/ : SUCCESS

-- 
To view, visit http://gerrit.ovirt.org/28480
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6b009f4a0cb0179fa1f1b74774ba61fd6638d8a9
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani(a)redhat.com&gt;
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com&gt;
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com&gt;
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: vm: add direct import of advancedstats helpers
......................................................................


Patch Set 8:

Build Failed 

http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9617/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/10402/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/10559/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_verify-error-codes_merged/5483/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/3641/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/1000/ : There was an
infra issue, please contact infra(a)ovirt.org

-- 
To view, visit http://gerrit.ovirt.org/28480
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6b009f4a0cb0179fa1f1b74774ba61fd6638d8a9
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani(a)redhat.com&gt;
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com&gt;
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com&gt;
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No

[Nir Soffer]

Nir Soffer has posted comments on this change.

Change subject: vm: add direct import of advancedstats helpers
......................................................................


Patch Set 9: Code-Review+1

-- 
To view, visit http://gerrit.ovirt.org/28480
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6b009f4a0cb0179fa1f1b74774ba61fd6638d8a9
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani(a)redhat.com&gt;
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com&gt;
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com&gt;
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: vm: add direct import of advancedstats helpers
......................................................................


Patch Set 7:

Build Successful 

http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9596/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/10380/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/10537/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_verify-error-codes_merged/5462/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/3620/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/992/ : SUCCESS

-- 
To view, visit http://gerrit.ovirt.org/28480
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6b009f4a0cb0179fa1f1b74774ba61fd6638d8a9
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani(a)redhat.com&gt;
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com&gt;
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com&gt;
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: vm: add direct import of advancedstats helpers
......................................................................


Patch Set 6:

Build Successful 

http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9561/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/10344/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/10501/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_verify-error-codes_merged/5426/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/3584/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/969/ : SUCCESS

-- 
To view, visit http://gerrit.ovirt.org/28480
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6b009f4a0cb0179fa1f1b74774ba61fd6638d8a9
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani(a)redhat.com&gt;
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com&gt;
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com&gt;
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No

Francesco Romani has posted comments on this change.

Change subject: vm: add direct import of advancedstats helpers
......................................................................


Patch Set 9: Verified+1

trivial patch. Verified by just running a VM on a patched VDSM and looking on the VDSM
logs for the (lack of) errors.

-- 
To view, visit http://gerrit.ovirt.org/28480
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6b009f4a0cb0179fa1f1b74774ba61fd6638d8a9
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani(a)redhat.com&gt;
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com&gt;
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com&gt;
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: vm: add direct import of advancedstats helpers
......................................................................


Patch Set 9:

Build Failed 

http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9622/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/10407/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/10564/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_verify-error-codes_merged/5488/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/3646/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/1004/ : There was an
infra issue, please contact infra(a)ovirt.org

-- 
To view, visit http://gerrit.ovirt.org/28480
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6b009f4a0cb0179fa1f1b74774ba61fd6638d8a9
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani(a)redhat.com&gt;
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com&gt;
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com&gt;
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: vm: add direct import of advancedstats helpers
......................................................................


Patch Set 5:

Build Failed 

http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9487/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/10271/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/10427/ : FAILURE

http://jenkins.ovirt.org/job/vdsm_master_verify-error-codes_merged/5353/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/3511/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/938/ : SUCCESS

-- 
To view, visit http://gerrit.ovirt.org/28480
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6b009f4a0cb0179fa1f1b74774ba61fd6638d8a9
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani(a)redhat.com&gt;
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com&gt;
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com&gt;
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No

Francesco Romani has posted comments on this change.

Change subject: vm: add direct import of advancedstats helpers
......................................................................


Patch Set 5: Verified+1

rebased; no code changes.

-- 
To view, visit http://gerrit.ovirt.org/28480
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6b009f4a0cb0179fa1f1b74774ba61fd6638d8a9
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani(a)redhat.com&gt;
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com&gt;
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com&gt;
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No

Francesco Romani has posted comments on this change.

Change subject: vm: add direct import of advancedstats helpers
......................................................................


Patch Set 4: Verified+1

trivial import juggling. Verified by unit and functional tests.

-- 
To view, visit http://gerrit.ovirt.org/28480
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6b009f4a0cb0179fa1f1b74774ba61fd6638d8a9
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani(a)redhat.com&gt;
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com&gt;
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com&gt;
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: vm: add direct import of advancedstats helpers
......................................................................


Patch Set 4:

Build Successful 

http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9146/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9931/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/812/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/10086/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_verify-error-codes_merged/5013/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/3170/ : SUCCESS

-- 
To view, visit http://gerrit.ovirt.org/28480
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6b009f4a0cb0179fa1f1b74774ba61fd6638d8a9
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani(a)redhat.com&gt;
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com&gt;
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com&gt;
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No

[Nir Soffer]

Nir Soffer has posted comments on this change.

Change subject: vm: add direct import of advancedstats helpers
......................................................................


Patch Set 4:

But please move the thread to sampling.py in the next patch in this topic.

-- 
To view, visit http://gerrit.ovirt.org/28480
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6b009f4a0cb0179fa1f1b74774ba61fd6638d8a9
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani(a)redhat.com&gt;
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com&gt;
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com&gt;
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No

[Nir Soffer]

Nir Soffer has posted comments on this change.

Change subject: vm: add direct import of advancedstats helpers
......................................................................


Patch Set 4: Code-Review+1

-- 
To view, visit http://gerrit.ovirt.org/28480
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6b009f4a0cb0179fa1f1b74774ba61fd6638d8a9
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani(a)redhat.com&gt;
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com&gt;
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com&gt;
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: vm: add direct import of advancedstats helpers
......................................................................


Patch Set 2:

Build Successful 

http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8893/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9677/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/673/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9832/ : SUCCESS

-- 
To view, visit http://gerrit.ovirt.org/28480
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6b009f4a0cb0179fa1f1b74774ba61fd6638d8a9
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani(a)redhat.com&gt;
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com&gt;
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No

Francesco Romani has posted comments on this change.

Change subject: vm: add direct import of advancedstats helpers
......................................................................


Patch Set 2:

rebased

-- 
To view, visit http://gerrit.ovirt.org/28480
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6b009f4a0cb0179fa1f1b74774ba61fd6638d8a9
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani(a)redhat.com&gt;
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com&gt;
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: vm: add direct import of advancedstats helpers
......................................................................


Patch Set 1: Code-Review-1 Verified-1

Build Failed 

http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9793/ : FAILURE

http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8855/ : FAILURE

http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9640/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/660/ : The patch
does not pass the virt functional tests

-- 
To view, visit http://gerrit.ovirt.org/28480
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6b009f4a0cb0179fa1f1b74774ba61fd6638d8a9
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani(a)redhat.com&gt;
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No