Change in vdsm[master]: vdsm-reg: collect vdsm-config.log

[Dan Kenigsberg]

Dan Kenigsberg has uploaded a new change for review.

Change subject: vdsm-reg: collect vdsm-config.log
......................................................................

vdsm-reg: collect vdsm-config.log

Change-Id: I124442ecc81fa1ff849ddd57af406a8a68c40f9e
Signed-off-by: Dan Kenigsberg 
---
M vdsm_reg/vdsm-config
1 file changed, 1 insertion(+), 1 deletion(-)

git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/62/24862/1

diff --git a/vdsm_reg/vdsm-config b/vdsm_reg/vdsm-config
index 19d0ff8..5e4d16c 100755
--- a/vdsm_reg/vdsm-config
+++ b/vdsm_reg/vdsm-config
@@ -8,7 +8,7 @@
 VDSM_CONFIG=/etc/vdsm/vdsm.conf
 GETCONFITEM=/usr/share/vdsm/get-conf-item
 DEPLOY_UTIL=/usr/share/vdsm-reg/deployUtil.pyc
-LOG=/var/log/vdsm-config
+LOG=/var/log/vdsm-reg/vdsm-config
 fWriteConfig=0
 strRHEVMAddress=""

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: vdsm-reg: collect vdsm-config.log
......................................................................

Patch Set 1:

Build Successful

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6447/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7231/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/7349/ : SUCCESS

[Douglas Schilling Landgraf]

Douglas Schilling Landgraf has posted comments on this change.

Change subject: vdsm-reg: collect vdsm-config.log
......................................................................

Patch Set 1: Code-Review+1

Yaniv Bronhaim has posted comments on this change.

Change subject: vdsm-reg: collect vdsm-config.log
......................................................................

Patch Set 1:

(1 comment)

http://gerrit.ovirt.org/#/c/24862/1//COMMIT_MSG
Commit Message:

Line 7: collect
you change the log location, please explain why or where was this location change firstly introduced?

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: vdsm-reg: collect vdsm-config.log
......................................................................

Patch Set 1:

(1 comment)

http://gerrit.ovirt.org/#/c/24862/1//COMMIT_MSG
Commit Message:

Line 3: AuthorDate: 2014-02-21 11:52:22 +0000
Line 4: Commit:     Dan Kenigsberg 
Line 5: CommitDate: 2014-02-21 11:58:27 +0000
Line 6: 
Line 7: vdsm-reg: collect vdsm-config.log
> you change the log location, please explain why or where was this location

I do not think much thought has been invested into the former location of /var/log/vdsm-config. /var/log/vdsm-reg/vdsm-config is clearer (since vdsm-config is part of the registration flow) and is collected by sosreport.

Are you looking for a deeper reasoning?
Line 8: 
Line 9: Change-Id: I124442ecc81fa1ff849ddd57af406a8a68c40f9e

Yaniv Bronhaim has posted comments on this change.

Change subject: vdsm-reg: collect vdsm-config.log
......................................................................

Patch Set 1:

(1 comment)

http://gerrit.ovirt.org/#/c/24862/1//COMMIT_MSG
Commit Message:

Line 3: AuthorDate: 2014-02-21 11:52:22 +0000
Line 4: Commit:     Dan Kenigsberg 
Line 5: CommitDate: 2014-02-21 11:58:27 +0000
Line 6: 
Line 7: vdsm-reg: collect vdsm-config.log
> I do not think much thought has been invested into the former location of /

that's the all point of this change. why is it required? because its more clearer is also a reason, but should be specified
Line 8: 
Line 9: Change-Id: I124442ecc81fa1ff849ddd57af406a8a68c40f9e

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: vdsm-reg: collect vdsm-config.log
......................................................................

Patch Set 2:

Build Successful

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6460/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7244/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/7362/ : SUCCESS

Yaniv Bronhaim has posted comments on this change.

Change subject: vdsm-reg: collect vdsm-config.log
......................................................................

Patch Set 2: Code-Review+1

[Douglas Schilling Landgraf]

Douglas Schilling Landgraf has posted comments on this change.

Change subject: vdsm-reg: collect vdsm-config.log
......................................................................

Patch Set 2: Verified+1

I have tested under ovirt-node the change, it generate the log under /var/log/vdsm-reg/vdsm-config and sosreport -o vdsm collected the file.

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: vdsm-reg: collect vdsm-config.log
......................................................................

Patch Set 2: Code-Review+2

[Dan Kenigsberg]

Dan Kenigsberg has submitted this change and it was merged.

Change subject: vdsm-reg: collect vdsm-config.log
......................................................................

vdsm-reg: collect vdsm-config.log

vdsm-config's log file was dumped in the catch-all /var/log directory.
Placing it under /var/log/vdsm-reg makes a nicer compartmentalization,
and makes vdsm's sosreport plugin collect it.

Change-Id: I124442ecc81fa1ff849ddd57af406a8a68c40f9e
Signed-off-by: Dan Kenigsberg 
Reviewed-on: http://gerrit.ovirt.org/24862
Reviewed-by: Douglas Schilling Landgraf 
Reviewed-by: Yaniv Bronhaim 
Tested-by: Douglas Schilling Landgraf 
---
M vdsm_reg/vdsm-config
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Douglas Schilling Landgraf: Verified; Looks good to me, but someone else must approve
  Yaniv Bronhaim: Looks good to me, but someone else must approve
  Dan Kenigsberg: Looks good to me, approved