From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: network: todo py3 nettestlib Tap
......................................................................
Patch Set 3:
(1 comment)
https://gerrit.ovirt.org/#/c/78863/3/tests/network/nettestlib.py
File tests/network/nettestlib.py:
Line 186:
Line 187: _deviceListener = None
Line 188:
Line 189: def addDevice(self):
Line 190: self._cloneDevice = open('/dev/net/tun', 'r+b',
buffering=0)
use io.open to have better control on file encoding
Line 191: ifr = struct.pack('16sH', conv.to_binary(self.devName),
self._IFF_TAP |
Line 192: self._IFF_NO_PI)
Line 193: fcntl.ioctl(self._cloneDevice, self._TUNSETIFF, ifr)
Line 194: self.up()
--
To view, visit
https://gerrit.ovirt.org/78863
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9d899d6e8bfe332174b722362136cc79de982c28
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horacek <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes