Change in vdsm[master]: Add the acquireHostIdAsync method to the StorageDomain

[Federico Simoncelli]

Federico Simoncelli has uploaded a new change for review.

Change subject: Add the acquireHostIdAsync method to the StorageDomain
......................................................................

Add the acquireHostIdAsync method to the StorageDomain

Signed-off-by: Federico Simoncelli 
Change-Id: Ibb42237c23023e7b31ca95c8cdb9908d916301a7
---
M vdsm/storage/sd.py
1 file changed, 21 insertions(+), 1 deletion(-)

git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/30/3930/1
--
To view, visit http://gerrit.ovirt.org/3930
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ibb42237c23023e7b31ca95c8cdb9908d916301a7
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli

Saggi Mizrahi has posted comments on this change.

Change subject: Add the acquireHostIdAsync method to the StorageDomain
......................................................................

Patch Set 1: Looks good to me, but someone else must approve

--
To view, visit http://gerrit.ovirt.org/3930
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibb42237c23023e7b31ca95c8cdb9908d916301a7
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli 
Gerrit-Reviewer: Saggi Mizrahi

[Federico Simoncelli]

Federico Simoncelli has posted comments on this change.

Change subject: Add the acquireHostIdAsync method to the StorageDomain
......................................................................

Patch Set 1: I would prefer that you didn't submit this

(1 inline comment)

....................................................
File vdsm/storage/sd.py
Line 250:         self._acquireHostIdLock = threading.RLock()
Move this to the dict in the pool. The domain object must be lightweight.

--
To view, visit http://gerrit.ovirt.org/3930
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibb42237c23023e7b31ca95c8cdb9908d916301a7
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Saggi Mizrahi

[Federico Simoncelli]

Federico Simoncelli has abandoned this change.

Change subject: Add the acquireHostIdAsync method to the StorageDomain
......................................................................

Patch Set 1: Abandoned

Squashed with http://gerrit.ovirt.org/3931

--
To view, visit http://gerrit.ovirt.org/3930
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: Ibb42237c23023e7b31ca95c8cdb9908d916301a7
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Saggi Mizrahi