[NEW PATCH] BZ#725241 Don't rotate a log file before it reaches a certain size (via gerrit-bot)

[Yotam Oron]

New patch submitted by Yotam Oron (yoron(a)redhat.com)

You can review this change at: http://gerrit.usersys.redhat.com/743

commit 268c190df397881b59cad1170224c50e4333eddd
Author: Yotam Oron <yoron(a)redhat.com&gt;
Date:   Mon Jul 25 15:36:26 2011 +0300

    BZ#725241 Don't rotate a log file before it reaches a certain size
    
    No need to rotate log files if they are too small, so set the minimum rotation size.
    
    Change-Id: I57a6f611146e4fc5b00109b52c071478e350db78

diff --git a/vdsm/vdsm-logrotate.conf b/vdsm/vdsm-logrotate.conf
index 12e16ad..4f02521 100644
--- a/vdsm/vdsm-logrotate.conf
+++ b/vdsm/vdsm-logrotate.conf
@@ -3,6 +3,7 @@
     missingok
     copytruncate
     size 15M
+    minsize 15M
     compress
     compresscmd /usr/bin/xz
     uncompresscmd /usr/bin/unxz

Change in vdsm[master]: BZ#725241 Don't rotate a log file before it reaches a certai...

[Yotam Oron]

Yotam Oron has posted comments on this change.

Change subject: BZ#725241 Don't rotate a log file before it reaches a certain size
......................................................................


Patch Set 1: (1 inline comment)

....................................................
File vdsm/vdsm-logrotate.conf
Line 6:     minsize 15M
minsize means that a file will not be rotated if the minimum size is reached OR the
temporal rotate time has been reached (hourly, daily etc).
You can read more here:
https://bugzilla.redhat.com/show_bug.cgi?id=173088
I think that this is exactly the functionality we are looking for.

--
To view, visit http://gerrit.usersys.redhat.com/743
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I57a6f611146e4fc5b00109b52c071478e350db78
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yotam Oron <yoron(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Yotam Oron <yoron(a)redhat.com&gt;

Change in vdsm[master]: BZ#725241 Don't rotate a log file before it reaches a certai...

[Yotam Oron]

Yotam Oron has abandoned this change.

Change subject: BZ#725241 Don't rotate a log file before it reaches a certain size
......................................................................


Patch Set 1: Abandoned

Abandoning this change - it didn't reproduce for the QE

--
To view, visit http://gerrit.usersys.redhat.com/743
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: I57a6f611146e4fc5b00109b52c071478e350db78
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yotam Oron <yoron(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Yotam Oron <yoron(a)redhat.com&gt;

Change in vdsm[master]: BZ#725241 Don't rotate a log file before it reaches a certai...

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: BZ#725241 Don't rotate a log file before it reaches a certain size
......................................................................


Patch Set 1: I would prefer that you didn't submit this

--
To view, visit http://gerrit.usersys.redhat.com/743
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I57a6f611146e4fc5b00109b52c071478e350db78
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yotam Oron <yoron(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;

Change in vdsm[master]: BZ#725241 Don't rotate a log file before it reaches a certai...

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: BZ#725241 Don't rotate a log file before it reaches a certain size
......................................................................


Patch Set 1: (1 inline comment)

Did you actually manage to reproduce the reported issue?

....................................................
File vdsm/vdsm-logrotate.conf
Line 6:     minsize 15M
does this work together with "size", and without one of (daily, weekly, monthly,
yearly)? this is not my understanding of logrotate(8). Please verify.

--
To view, visit http://gerrit.usersys.redhat.com/743
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I57a6f611146e4fc5b00109b52c071478e350db78
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yotam Oron <yoron(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;