Dan Kenigsberg has posted comments on this change.
Change subject: Stupid logger to get mount errors
......................................................................
Patch Set 1: (1 inline comment)
unless we get
http://gerrit.usersys.redhat.com/985 to quickly work, we should at least
have this one ready to post for reproducers.
....................................................
File vdsm/storage/fileUtils.py
Line 71: logDir = "/var/log/vdsm/mount/"
Line 72: def _stupidLogger(out):
Line 73: if not os.path.exists(logDir):
Line 74: os.makedirs(logDir)
Line 75: logFile = logDir + str(os.getpid())
It would be better to call logging.basicConfig with the filename. this way we'd get
all logging.bla for free.
Line 76: with open(logFile, 'a') as f:
Line 77: f.write(out + "\n")
Line 78:
Line 79: def mount(resource, mountPoint, mountType):
--
To view, visit
http://gerrit.usersys.redhat.com/986
To unsubscribe, visit
http://gerrit.usersys.redhat.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I7530424ead0588e0843cece29c5c78216b505d0e
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>