Change in vdsm[ovirt-3.4]: Create destination image as preallocated only if format is RAW

Tal Nisan has uploaded a new change for review.

Change subject: Create destination image as preallocated only if format is RAW
......................................................................

Create destination image as preallocated only if format is RAW

Create a destination image as preallocated only when the destination
domain does not supports sparseness and the image format is RAW, otherwise
create it as sparse

Signed-off-by: Tal Nisan 
Bug-Url: https://bugzilla.redhat.com/1091956
Change-Id: I209bae70252a52f8a66be42a718c3dd73f2a6bd3
---
M vdsm/storage/image.py
1 file changed, 2 insertions(+), 1 deletion(-)

git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/74/27274/1

diff --git a/vdsm/storage/image.py b/vdsm/storage/image.py
index 637d4c8..830c9c5 100644
--- a/vdsm/storage/image.py
+++ b/vdsm/storage/image.py
@@ -358,7 +358,8 @@
                     # we create the target as a sparse volume (since it will be
                     # soon filled with the data coming from the copy) and then
                     # we change its metadata back to the original value.
-                    if destDom.supportsSparseness:
+                    if (destDom.supportsSparseness or
+                            volParams['volFormat'] != volume.RAW_FORMAT):
                         tmpVolPreallocation = volume.SPARSE_VOL
                     else:
                         tmpVolPreallocation = volume.PREALLOCATED_VOL

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: Create destination image as preallocated only if format is RAW
......................................................................

Patch Set 1: Code-Review+2

[Nir Soffer]

Nir Soffer has posted comments on this change.

Change subject: Create destination image as preallocated only if format is RAW
......................................................................

Patch Set 1: Code-Review+1

[Allon Mureinik]

Allon Mureinik has posted comments on this change.

Change subject: Create destination image as preallocated only if format is RAW
......................................................................

Patch Set 1: Verified+1

Tal Nisan has posted comments on this change.

Change subject: Create destination image as preallocated only if format is RAW
......................................................................

Patch Set 1:

Verified by:
Cold move in the same storage type (block/file)
Cold move in the different storage types (block/file)

Tal Nisan has posted comments on this change.

Change subject: Create destination image as preallocated only if format is RAW
......................................................................

Patch Set 1: Verified+1

Yaniv Bronhaim has submitted this change and it was merged.

Change subject: Create destination image as preallocated only if format is RAW
......................................................................

Create destination image as preallocated only if format is RAW

Create a destination image as preallocated only when the destination
domain does not supports sparseness and the image format is RAW, otherwise
create it as sparse

Signed-off-by: Tal Nisan 
Bug-Url: https://bugzilla.redhat.com/1091956
Change-Id: I209bae70252a52f8a66be42a718c3dd73f2a6bd3
Reviewed-on: http://gerrit.ovirt.org/27274
Reviewed-by: Dan Kenigsberg 
Reviewed-by: Nir Soffer 
Tested-by: Allon Mureinik 
---
M vdsm/storage/image.py
1 file changed, 2 insertions(+), 1 deletion(-)

Approvals:
  Nir Soffer: Looks good to me, but someone else must approve
  Tal Nisan: Verified
  Allon Mureinik: Verified
  Dan Kenigsberg: Looks good to me, approved