Change in vdsm[master]: lib: executor: log pool status on discard

Francesco Romani has uploaded a new change for review.

Change subject: lib: executor: log pool status on discard
......................................................................

lib: executor: log pool status on discard

Log the pool size and content when a worker is discarded,
to make troubleshooting and debug easier.

Change-Id: I949181968a97a7bcec703bc36ef9e1a0f30c6858
Signed-off-by: Francesco Romani <fromani(a)redhat.com&gt;
---
M lib/vdsm/executor.py
1 file changed, 9 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/33/48333/1

diff --git a/lib/vdsm/executor.py b/lib/vdsm/executor.py
index 1ce14bc..82c8d8c 100644
--- a/lib/vdsm/executor.py
+++ b/lib/vdsm/executor.py
@@ -127,6 +127,11 @@
         with self._lock:
             if self._running:
                 self._add_worker()
+        # this is a debug aid, it is not that important to be precise;
+        # intentionally done outside the lock
+        self._log.info('pool[%i]: (%s)',
+                       len(self._workers),
+                       ' '.join(str(w) for w in self._workers))
 
     def _worker_stopped(self, worker):
         """
@@ -222,10 +227,12 @@
         if self._discarded:
             raise AssertionError("Attempt to discard worker twice")
         self._discarded = True
-        self._log.debug("Worker %s discarded while doing '%s'",
-                        self.name, self._task.name)
+        self._log.debug("Worker %s discarded", str(self))
         self._executor._worker_discarded(self)
 
+    def __str__(self):
+        return '%s on %s' % (self.name, self._task.name)
+
 
 class TaskQueue(object):
     """


-- 
To view, visit https://gerrit.ovirt.org/48333
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I949181968a97a7bcec703bc36ef9e1a0f30c6858
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani(a)redhat.com&gt;

automation(a)ovirt.org has posted comments on this change.

Change subject: lib: executor: log pool status on discard
......................................................................


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and
is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5',
'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/48333
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I949181968a97a7bcec703bc36ef9e1a0f30c6858
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani(a)redhat.com&gt;
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-HasComments: No

automation(a)ovirt.org has posted comments on this change.

Change subject: lib: executor: log pool status on discard
......................................................................


Patch Set 2:

* #1250839::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1250839::OK, public bug
* Check Product::#1250839::OK, Correct classification oVirt
* Check TM::SKIP, not in a monitored branch (ovirt-3.5 ovirt-3.4 ovirt-3.3 ovirt-3.2)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5',
'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/48333
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I949181968a97a7bcec703bc36ef9e1a0f30c6858
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani(a)redhat.com&gt;
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-HasComments: No

Francesco Romani has posted comments on this change.

Change subject: lib: executor: log pool status on discard
......................................................................


Patch Set 2: Verified+1

verified together: 48191, 48193, 48192, 48333
verified with 48332 using steps provided in
https://bugzilla.redhat.com/show_bug.cgi?id=1250839#c7

-- 
To view, visit https://gerrit.ovirt.org/48333
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I949181968a97a7bcec703bc36ef9e1a0f30c6858
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani(a)redhat.com&gt;
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com&gt;
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-HasComments: No

automation(a)ovirt.org has posted comments on this change.

Change subject: lib: executor: log pool status on discard
......................................................................


Patch Set 3:

* #1250839::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1250839::OK, public bug
* Check Product::#1250839::OK, Correct classification oVirt
* Check TM::SKIP, not in a monitored branch (ovirt-3.5 ovirt-3.4 ovirt-3.3 ovirt-3.2)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5',
'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/48333
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I949181968a97a7bcec703bc36ef9e1a0f30c6858
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani(a)redhat.com&gt;
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com&gt;
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-HasComments: No

Francesco Romani has posted comments on this change.

Change subject: lib: executor: log pool status on discard
......................................................................


Patch Set 3: Verified+1

verified - actually on branch 3.6, while checking https://gerrit.ovirt.org/#/c/48348/

logs as expected.

-- 
To view, visit https://gerrit.ovirt.org/48333
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I949181968a97a7bcec703bc36ef9e1a0f30c6858
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani(a)redhat.com&gt;
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com&gt;
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-HasComments: No

gerrit-hooks has posted comments on this change.

Change subject: lib: executor: log pool status on discard
......................................................................


Patch Set 4:

* #1250839::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1250839::OK, public bug
* Check Product::#1250839::OK, Correct classification oVirt
* Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-3.5 ovirt-3.4 ovirt-3.3
ovirt-3.2)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6',
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/48333
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I949181968a97a7bcec703bc36ef9e1a0f30c6858
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani(a)redhat.com&gt;
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com&gt;
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org&gt;
Gerrit-HasComments: No

gerrit-hooks has posted comments on this change.

Change subject: lib: executor: log pool status on discard
......................................................................


Patch Set 5:

* #1250839::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1250839::OK, public bug
* Check Product::#1250839::OK, Correct classification oVirt
* Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-3.5 ovirt-3.4 ovirt-3.3
ovirt-3.2)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6',
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/48333
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I949181968a97a7bcec703bc36ef9e1a0f30c6858
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani(a)redhat.com&gt;
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com&gt;
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org&gt;
Gerrit-HasComments: No