10:35 a.m.
Laszlo Hornyak has uploaded a new change for review.
Change subject: vdsm: [CpuPinning] support for cpuPinning
......................................................................
vdsm: [CpuPinning] support for cpuPinning
Adds cpuPinning attributes to createDomain
Change-Id: Ia7016848d365d0e59454372461d66d167b100e7e
Signed-off-by: Laszlo Hornyak <lhornyak(a)redhat.com>
---
M vdsm/libvirtvm.py
1 file changed, 14 insertions(+), 0 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/30/4630/1
--
To view, visit http://gerrit.ovirt.org/4630
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia7016848d365d0e59454372461d66d167b100e7e
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Laszlo Hornyak <lhornyak(a)redhat.com>
4:53 a.m.
Dan Kenigsberg has posted comments on this change.
Change subject: vdsm: [CpuPinning] support for cpuPinning
......................................................................
Patch Set 7: I would prefer that you didn't submit this
(4 inline comments)
....................................................
Commit Message
Line 7: vdsm: [CpuPinning] support for cpuPinning
there's still no reason to mention vdsm in the subject, nor to say cpuPinnging twice.
Line 9: Adds support code to the createDomain functionality in the
my other comment was ignored, too.
....................................................
File vdsm/libvirtvm.py
Line 713: # see http://www.ovirt.org/wiki/Features/Design/cpu-pinning
url is not updated with new API, I believe.
Line 720: vcpupin.setAttribute('cpuset',
cpuPin.get('pin'))
why "pin" and not "cpuset"? libvirt name is clear, so why stir away of
it? you said you're fine with keeping it.
--
To view, visit http://gerrit.ovirt.org/4630
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia7016848d365d0e59454372461d66d167b100e7e
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Laszlo Hornyak <lhornyak(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com>
Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Peter V. Saveliev <peet(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
3:26 a.m.
New subject: Change in vdsm[master]: CpuPinning
Dan Kenigsberg has submitted this change and it was merged.
Change subject: CpuPinning
......................................................................
CpuPinning
Adds support code to the "Vm.create()" (in backendcreateDomain) functionality in
the
method _DomXML.appendCpu. This code will create a <cputune> tag and
append fill with <vcpupin> tags.
http://libvirt.org/formatdomain.html#elementsCPUTuning
http://www.ovirt.org/wiki/Features/Design/cpu-pinning
Change-Id: Ia7016848d365d0e59454372461d66d167b100e7e
Signed-off-by: Laszlo Hornyak <lhornyak(a)redhat.com>
---
M vdsm/libvirtvm.py
1 file changed, 12 insertions(+), 0 deletions(-)
Approvals:
Laszlo Hornyak: Verified
Dan Kenigsberg: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/4630
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia7016848d365d0e59454372461d66d167b100e7e
Gerrit-PatchSet: 14
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Laszlo Hornyak <lhornyak(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com>
Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Peter V. Saveliev <peet(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
3:26 a.m.
New subject: Change in vdsm[master]: CpuPinning
Dan Kenigsberg has posted comments on this change.
Change subject: CpuPinning
......................................................................
Patch Set 14: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/4630
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia7016848d365d0e59454372461d66d167b100e7e
Gerrit-PatchSet: 14
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Laszlo Hornyak <lhornyak(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com>
Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Peter V. Saveliev <peet(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
2:19 a.m.
New subject: Change in vdsm[master]: CpuPinning
Laszlo Hornyak has posted comments on this change.
Change subject: CpuPinning
......................................................................
Patch Set 14: Verified
--
To view, visit http://gerrit.ovirt.org/4630
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia7016848d365d0e59454372461d66d167b100e7e
Gerrit-PatchSet: 14
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Laszlo Hornyak <lhornyak(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com>
Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Peter V. Saveliev <peet(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
2:36 p.m.
New subject: Change in vdsm[master]: CpuPinning
Dan Kenigsberg has posted comments on this change.
Change subject: CpuPinning
......................................................................
Patch Set 13: Looks good to me, but someone else must approve
(1 inline comment)
....................................................
File vdsm/libvirtvm.py
Line 713: # see http://www.ovirt.org/wiki/Features/Design/cpu-pinning
url is still not updated.
--
To view, visit http://gerrit.ovirt.org/4630
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia7016848d365d0e59454372461d66d167b100e7e
Gerrit-PatchSet: 13
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Laszlo Hornyak <lhornyak(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com>
Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Peter V. Saveliev <peet(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
2:34 p.m.
New subject: Change in vdsm[master]: CpuPinning
Dan Kenigsberg has posted comments on this change.
Change subject: CpuPinning
......................................................................
Patch Set 12: (1 inline comment)
....................................................
File vdsm/libvirtvm.py
Line 716: cpuPinning = self.conf.get('cpuPinning')
no, it wasn't. but thanks for taking the simpler api route.
--
To view, visit http://gerrit.ovirt.org/4630
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia7016848d365d0e59454372461d66d167b100e7e
Gerrit-PatchSet: 12
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Laszlo Hornyak <lhornyak(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com>
Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Peter V. Saveliev <peet(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
9:15 a.m.
New subject: Change in vdsm[master]: CpuPinning
Laszlo Hornyak has posted comments on this change.
Change subject: CpuPinning
......................................................................
Patch Set 13: Verified
--
To view, visit http://gerrit.ovirt.org/4630
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia7016848d365d0e59454372461d66d167b100e7e
Gerrit-PatchSet: 13
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Laszlo Hornyak <lhornyak(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com>
Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Peter V. Saveliev <peet(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
4:11 a.m.
New subject: Change in vdsm[master]: CpuPinning
Dan Kenigsberg has posted comments on this change.
Change subject: CpuPinning
......................................................................
Patch Set 12: (1 inline comment)
....................................................
File vdsm/libvirtvm.py
Line 716: cpuPinning = self.conf.get('cpuPinning')
I've noticed it only now, but why not use a simpler api, with vcpu as key and cpuset
ans value of a single dictionary? this api has a lot of repetitiveness.
--
To view, visit http://gerrit.ovirt.org/4630
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia7016848d365d0e59454372461d66d167b100e7e
Gerrit-PatchSet: 12
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Laszlo Hornyak <lhornyak(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com>
Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Peter V. Saveliev <peet(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
4:21 a.m.
New subject: Change in vdsm[master]: CpuPinning
Laszlo Hornyak has posted comments on this change.
Change subject: CpuPinning
......................................................................
Patch Set 12: (1 inline comment)
....................................................
File vdsm/libvirtvm.py
Line 716: cpuPinning = self.conf.get('cpuPinning')
is this a blocking issue?
--
To view, visit http://gerrit.ovirt.org/4630
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia7016848d365d0e59454372461d66d167b100e7e
Gerrit-PatchSet: 12
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Laszlo Hornyak <lhornyak(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com>
Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Peter V. Saveliev <peet(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
9:21 a.m.
New subject: Change in vdsm[master]: CpuPinning
Laszlo Hornyak has posted comments on this change.
Change subject: CpuPinning
......................................................................
Patch Set 11: Verified
--
To view, visit http://gerrit.ovirt.org/4630
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia7016848d365d0e59454372461d66d167b100e7e
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Laszlo Hornyak <lhornyak(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com>
Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Peter V. Saveliev <peet(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
3:07 p.m.
New subject: Change in vdsm[master]: CpuPinning
Dan Kenigsberg has posted comments on this change.
Change subject: CpuPinning
......................................................................
Patch Set 10: Looks good to me, but someone else must approve
have you noticed my comment regarding vdsClient?
--
To view, visit http://gerrit.ovirt.org/4630
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia7016848d365d0e59454372461d66d167b100e7e
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Laszlo Hornyak <lhornyak(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com>
Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Peter V. Saveliev <peet(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
3:09 p.m.
New subject: Change in vdsm[master]: CpuPinning
Laszlo Hornyak has posted comments on this change.
Change subject: CpuPinning
......................................................................
Patch Set 10:
Dan, not sure what you meant with _parseNestedSpec, could you give a more detailed
requirement?
--
To view, visit http://gerrit.ovirt.org/4630
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia7016848d365d0e59454372461d66d167b100e7e
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Laszlo Hornyak <lhornyak(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com>
Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Peter V. Saveliev <peet(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
3:03 p.m.
New subject: Change in vdsm[master]: CpuPinning
Laszlo Hornyak has posted comments on this change.
Change subject: CpuPinning
......................................................................
Patch Set 9: (1 inline comment)
....................................................
File vdsm/libvirtvm.py
Line 723: #end of cpu-pinning support
Done
--
To view, visit http://gerrit.ovirt.org/4630
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia7016848d365d0e59454372461d66d167b100e7e
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Laszlo Hornyak <lhornyak(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com>
Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Peter V. Saveliev <peet(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
1:44 p.m.
New subject: Change in vdsm[master]: CpuPinning
Dan Kenigsberg has posted comments on this change.
Change subject: CpuPinning
......................................................................
Patch Set 9: Looks good to me, but someone else must approve
(1 inline comment)
but a very minor comment within.
please verify that it works with your Engine implementation.
hmm, come to think of it, you'd better supply a means to pass the new param via
vdsClient (see _parseNestedSpec).
....................................................
File vdsm/libvirtvm.py
Line 723: #end of cpu-pinning support
sorry for not having noticed this before, but I do not really like the ending comment. we
can see that this is the end since it is the end of the python block.
--
To view, visit http://gerrit.ovirt.org/4630
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia7016848d365d0e59454372461d66d167b100e7e
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Laszlo Hornyak <lhornyak(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com>
Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Peter V. Saveliev <peet(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
1:35 p.m.
New subject: Change in vdsm[master]: CpuPinning
Dan Kenigsberg has posted comments on this change.
Change subject: CpuPinning
......................................................................
Patch Set 7: (1 inline comment)
....................................................
Commit Message
Line 7: vdsm: [CpuPinning] support for cpuPinning
if you do not understand a comment, it's better to ask politely, or even say out loud
that the reviewer is stupid. Ignoring a comment is bad practice.
I do not see the point of having each vdsm commit mention that it is a vdsm commit.
--
To view, visit http://gerrit.ovirt.org/4630
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia7016848d365d0e59454372461d66d167b100e7e
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Laszlo Hornyak <lhornyak(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com>
Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Peter V. Saveliev <peet(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
6:49 a.m.
New subject: Change in vdsm[master]: CpuPinning
Laszlo Hornyak has posted comments on this change.
Change subject: CpuPinning
......................................................................
Patch Set 7: (3 inline comments)
....................................................
Commit Message
Line 7: vdsm: [CpuPinning] support for cpuPinning
Ah ok, I did not understand the first time, but all the other teas require that
'$projectname:' prefix in the commit message.
Line 9: Adds support code to the createDomain functionality in the
Done
....................................................
File vdsm/libvirtvm.py
Line 720: vcpupin.setAttribute('cpuset',
cpuPin.get('pin'))
Done
--
To view, visit http://gerrit.ovirt.org/4630
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia7016848d365d0e59454372461d66d167b100e7e
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Laszlo Hornyak <lhornyak(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com>
Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Peter V. Saveliev <peet(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
8:50 a.m.
Laszlo Hornyak has posted comments on this change.
Change subject: vdsm: [CpuPinning] support for cpuPinning
......................................................................
Patch Set 6: (1 inline comment)
....................................................
File vdsm/libvirtvm.py
Line 717: for cpuPinStr in cpuPinningStr.split('_'):
I am not against breaking it down to a list of cpu-pinnings, if all agree with that.
cpuset: so be it
--
To view, visit http://gerrit.ovirt.org/4630
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia7016848d365d0e59454372461d66d167b100e7e
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Laszlo Hornyak <lhornyak(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com>
Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Peter V. Saveliev <peet(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
7:13 a.m.
Laszlo Hornyak has posted comments on this change.
Change subject: vdsm: [CpuPinning] support for cpuPinning
......................................................................
Patch Set 6: Verified
--
To view, visit http://gerrit.ovirt.org/4630
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia7016848d365d0e59454372461d66d167b100e7e
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Laszlo Hornyak <lhornyak(a)redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com>
Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Peter V. Saveliev <peet(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
8:17 a.m.
Laszlo Hornyak has posted comments on this change.
Change subject: vdsm: [CpuPinning] support for cpuPinning
......................................................................
Patch Set 5: Verified
--
To view, visit http://gerrit.ovirt.org/4630
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia7016848d365d0e59454372461d66d167b100e7e
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Laszlo Hornyak <lhornyak(a)redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com>
Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Peter V. Saveliev <peet(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
8:17 a.m.
Laszlo Hornyak has posted comments on this change.
Change subject: vdsm: [CpuPinning] support for cpuPinning
......................................................................
Patch Set 5:
moved the cputune tag out of the cpu tag (libvirt silently ignored it)
--
To view, visit http://gerrit.ovirt.org/4630
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia7016848d365d0e59454372461d66d167b100e7e
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Laszlo Hornyak <lhornyak(a)redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com>
Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Peter V. Saveliev <peet(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
3:05 a.m.
Laszlo Hornyak has posted comments on this change.
Change subject: vdsm: [CpuPinning] support for cpuPinning
......................................................................
Patch Set 4: (2 inline comments)
....................................................
Commit Message
Line 9: Adds cpuPinning attributes to createDomain
Do you want to come up with a better description?
....................................................
File vdsm/libvirtvm.py
Line 716: cpuPinningStr = self.conf.get('cpuPinning')
it is checked just two lines above:
if 'cpuPinning' in self.conf:
--
To view, visit http://gerrit.ovirt.org/4630
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia7016848d365d0e59454372461d66d167b100e7e
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Laszlo Hornyak <lhornyak(a)redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com>
Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Peter V. Saveliev <peet(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
10:34 p.m.
Mark Wu has posted comments on this change.
Change subject: vdsm: [CpuPinning] support for cpuPinning
......................................................................
Patch Set 4: I would prefer that you didn't submit this
(2 inline comments)
....................................................
Commit Message
Line 9: Adds cpuPinning attributes to createDomain
What does createDomain mean? It's confusing
....................................................
File vdsm/libvirtvm.py
Line 716: cpuPinningStr = self.conf.get('cpuPinning')
You need check if the option 'cpuPinning' appears in vm.conf. Otherwise, the
following code will raise exception because cpuPinningStr is None.
And I also mentioned to add a pattern validation for string in my last comment. Do you
think it's necessary?
--
To view, visit http://gerrit.ovirt.org/4630
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia7016848d365d0e59454372461d66d167b100e7e
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Laszlo Hornyak <lhornyak(a)redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com>
Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Peter V. Saveliev <peet(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
9:28 p.m.
Mark Wu has posted comments on this change.
Change subject: vdsm: [CpuPinning] support for cpuPinning
......................................................................
Patch Set 2: I would prefer that you didn't submit this
(1 inline comment)
....................................................
File vdsm/libvirtvm.py
Line 716: cpuPinningStr = self.conf.get('smpCoresPerSocket')
I don't understand why you get cpu pinning string from
vm.conf['smpCoresPerSocket'], which should be used to specify the core number of
each socket. I think you need introduce a new field to store the pinning string.
Additionally, I suggest you add a pattern validation here. Perhaps it is already covered
on ovirt engine side. But it's better to add it to vdsm too because vdsm could run in
a standalone mode in future.
--
To view, visit http://gerrit.ovirt.org/4630
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia7016848d365d0e59454372461d66d167b100e7e
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Laszlo Hornyak <lhornyak(a)redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com>
Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Peter V. Saveliev <peet(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
3:44 p.m.
Saggi Mizrahi has posted comments on this change.
Change subject: vdsm: [CpuPinning] support for cpuPinning
......................................................................
Patch Set 2: I would prefer that you didn't submit this
(1 inline comment)
....................................................
File vdsm/libvirtvm.py
Line 716: cpuPinningStr = self.conf.get('smpCoresPerSocket')
If you use get() it means you expect the key to might not exist an None to be returned.
There is no handling for that case in your code. Either use the [] operator or handle
None.
--
To view, visit http://gerrit.ovirt.org/4630
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia7016848d365d0e59454372461d66d167b100e7e
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Laszlo Hornyak <lhornyak(a)redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com>
Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com>
Gerrit-Reviewer: Peter V. Saveliev <peet(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
4140
days inactive
4151
days old
vdsm-patches@lists.fedorahosted.org
24 comments
4 participants
participants (4)
-
Dan Kenigsberg -
lhornyak＠redhat.com -
smizrahi＠redhat.com -
wudxw＠linux.vnet.ibm.com